Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f4bc4e7e-b9d4-432b-2157-f5b30c160a3a@rock-chips.com>
Date:   Fri, 16 Jun 2023 11:03:14 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: usb: typec: tcpm: fix cc role at port reset
Content-Language: en-US
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org,
        sebastian.reichel@collabora.com, heiko@sntech.de,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-rockchip@lists.infradead.org, huangtao@rock-chips.com,
        william.wu@rock-chips.com, jianwei.zheng@rock-chips.com,
        yubing.zhang@rock-chips.com, wmc@rock-chips.com
References: <20230616022001.25819-1-frank.wang@rock-chips.com>
 <3c3fbecd-caf9-c432-0890-93cceade98c1@roeck-us.net>
From:   Frank Wang <frank.wang@rock-chips.com>
In-Reply-To: <3c3fbecd-caf9-c432-0890-93cceade98c1@roeck-us.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Guenter,

On 2023/6/16 10:27, Guenter Roeck wrote:
> On 6/15/23 19:20, Frank Wang wrote:
>> In the current implementation, the tcpm set CC1/CC2 role to open when
>> it do port reset would cause the VBUS removed by the Type-C partner.
>>
>> This sets CC1/CC2 according to the default state of port to fix it.
>>
>> Comments are suggested by Guenter Roeck.
>>
>
> I have no idea (recollection) of what I suggested here :-(

Aha, this is also an old patch I have sent before, you suggested that 
the cc role should require some tweaking based on the port type or 
default state, do you remember it now?

Anyway, Can you help to review this patch again?


BR.
Frank

>
> Guenter
>
>> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
>> ---
>>   drivers/usb/typec/tcpm/tcpm.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/typec/tcpm/tcpm.c 
>> b/drivers/usb/typec/tcpm/tcpm.c
>> index 3c6b0c8e2d3ae..9f6aaa3e70ca8 100644
>> --- a/drivers/usb/typec/tcpm/tcpm.c
>> +++ b/drivers/usb/typec/tcpm/tcpm.c
>> @@ -4885,7 +4885,8 @@ static void run_state_machine(struct tcpm_port 
>> *port)
>>           break;
>>       case PORT_RESET:
>>           tcpm_reset_port(port);
>> -        tcpm_set_cc(port, TYPEC_CC_OPEN);
>> +        tcpm_set_cc(port, tcpm_default_state(port) == SNK_UNATTACHED ?
>> +                TYPEC_CC_RD : tcpm_rp_cc(port));
>>           tcpm_set_state(port, PORT_RESET_WAIT_OFF,
>>                      PD_T_ERROR_RECOVERY);
>>           break;
>