Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2036284rwd; Thu, 15 Jun 2023 20:51:16 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4rlUwRXx2jXRQifgwM79tit83tH2FH/ZP7qJDY0gSi5JuUiqrYHXmWbwg2TRrJ0EOwFl/v X-Received: by 2002:a0d:d9ca:0:b0:56c:fd03:dba with SMTP id b193-20020a0dd9ca000000b0056cfd030dbamr657550ywe.35.1686887475913; Thu, 15 Jun 2023 20:51:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686887475; cv=none; d=google.com; s=arc-20160816; b=rXwgp71bFGcyfjDQ8HJtPzBZGlWar1pNKZinFWGJej3djvQaBPl4LJZFgQuVGy0FXq 0uZPJVlwvFVajDnXU0FYiuvCNK8gI6Lh9mZo9i4RIwwVy17zjo6YOCW+LOkiUklOBw+H Hh6ZVfUbCxUyIR2IImwxAMwKxizC6Kd39ifE2IEpb35dAe4+ElOrP1ZNYgkEgBEeL0Lj ZeGHSiHYOkAbvXwBu+470tPVOdM69dCRDaoeHx2bKCXQXDEh9v6kX76h3keQHjy6VBC9 F8Q7ngsY1F/anET8SFciIRGSfwHaN1SVnsKOXqNSYZ3X8dDD+wul0deie9JAaYfjqcS+ Bhmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=ssboqFuJsuzuCpdbRQ+L+w3xrtVqrpdJ2PznGonY4y4=; b=ikXZOWP8MnDJzjSw4jAMyCQ9WJAaZbmCANLYGe0LWp2QUon9l3fTHbTmyhhzRVCgtn 8tZegCbPnKxeXSUJng6IbyS28xSP9yL0TWU9hljZrR0RyD+Grg7CbFpEwICkbTbU3hPv pAcFllwAqpEWiem+8RQuFPSpXKAwvmKJUlak5/YkO/GWeAmjG6ev0YlXvdEDlP2LgynP 70ZmApsHa+IxS7a3KdzQUCTSlWAFb51ZIUS4ItKb3TT/NZ0HhOFZSOjP3+IlXa9boHks VDSrsXbJrRR8S6Amm0jm/YkOHO8YlGQy2qItv3zbzruLj6Rpbto7S22fWFxLXnCEKmmm aEfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=d2AvKjRR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h124-20020a636c82000000b0053592069d66si14511686pgc.467.2023.06.15.20.51.02; Thu, 15 Jun 2023 20:51:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=d2AvKjRR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241727AbjFPDI5 (ORCPT + 99 others); Thu, 15 Jun 2023 23:08:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241688AbjFPDIw (ORCPT ); Thu, 15 Jun 2023 23:08:52 -0400 Received: from mail-vk1-xa29.google.com (mail-vk1-xa29.google.com [IPv6:2607:f8b0:4864:20::a29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BF772D59 for ; Thu, 15 Jun 2023 20:08:50 -0700 (PDT) Received: by mail-vk1-xa29.google.com with SMTP id 71dfb90a1353d-4714ec7e30eso1809e0c.1 for ; Thu, 15 Jun 2023 20:08:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1686884929; x=1689476929; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ssboqFuJsuzuCpdbRQ+L+w3xrtVqrpdJ2PznGonY4y4=; b=d2AvKjRRoiVHcqXfjX+XcACUNe5ZTaFoeBkqwyRBv+zr4ioeULu8utJj12aZsFcCEL Cb9D3qb0Q4RI4jqJ14EKgvYwpb0KjzXcAOx3ljqUU464Xvmica0Eak6cu9KXAeEWqC/m gLmvtREDwQAfwajnK4PuGDPJ600BuT40OnBy0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686884929; x=1689476929; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ssboqFuJsuzuCpdbRQ+L+w3xrtVqrpdJ2PznGonY4y4=; b=fh3MGoFONyRcxmbDcA0u+Ll6g06/J1BqPWorsbVx8D4nA6OdAVOSQ0AAXYv+BI5kS1 Fp0latitTul98QVfEifIcsKPKx76iQ+sDEBtCacGQwIAI69zH061BHdtGWQpjnCbp2kq Zj++RVWovXimoJ8LCSaQqlXqNrwkHRvSAqlV+6OblccB8xZeAn7NxX+m+M+H9pUcTpjP TLAdrSe7+BmR2zCd+crUo9voFhwEQLx4mY+EPn6G8V5Nkhnv09fuqbNiykL7L8bpiLVf codm9O+cCzVWeNrStT/20HYQV6pWn882hSSqL1BracdRF6+QurBX/y4zIHDQjy9rtTbi eHcQ== X-Gm-Message-State: AC+VfDw64VgSIbPRoMYuXm0uPrdwfmB0IEM7QsnMZKwmG0C40V1mlwtz RKUsrfXmMtzWP0eVg5ojq6k6s7Kb2UxHW9ROW9o/KA== X-Received: by 2002:a1f:4308:0:b0:44f:e6ff:f30e with SMTP id q8-20020a1f4308000000b0044fe6fff30emr1067981vka.10.1686884929582; Thu, 15 Jun 2023 20:08:49 -0700 (PDT) MIME-Version: 1.0 References: <20230615122051.546985-1-angelogioacchino.delregno@collabora.com> <20230615122051.546985-4-angelogioacchino.delregno@collabora.com> In-Reply-To: <20230615122051.546985-4-angelogioacchino.delregno@collabora.com> From: Chen-Yu Tsai Date: Fri, 16 Jun 2023 11:08:38 +0800 Message-ID: Subject: Re: [PATCH 3/3] clk: mediatek: clk-mt8173-apmixedsys: Fix iomap not released issue To: AngeloGioacchino Del Regno Cc: sboyd@kernel.org, mturquette@baylibre.com, matthias.bgg@gmail.com, u.kleine-koenig@pengutronix.de, msp@baylibre.com, miles.chen@mediatek.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 15, 2023 at 8:21=E2=80=AFPM AngeloGioacchino Del Regno wrote: > > In case of error after of_ioremap() the resource must be released: > call iounmap() where appropriate to fix that. > > Fixes: 41138fbf876c ("clk: mediatek: mt8173: Migrate to platform driver a= nd common probe") > Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Chen-Yu Tsai