Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 07:44:32 +0200
From:   Frank Wunderlich <frank-w@public-files.de>
To:     arinc9.unal@gmail.com,
        =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>,
        Daniel Golle <daniel@makrotopia.org>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Sean Wang <sean.wang@mediatek.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Russell King <linux@armlinux.org.uk>
CC:     Landen Chao <landen.chao@mediatek.com>,
        Bartel Eerdekens <bartel.eerdekens@constell8.be>,
        mithat.guner@xeront.com, erkin.bozoglu@xeront.com,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net v5 4/6] net: dsa: mt7530: fix handling of LLDP frames
User-Agent: K-9 Mail for Android
Reply-to: frank-w@public-files.de
In-Reply-To: <20230616025327.12652-5-arinc.unal@arinc9.com>
References: <20230616025327.12652-1-arinc.unal@arinc9.com> <20230616025327.12652-5-arinc.unal@arinc9.com>
Message-ID: <CFD0E43B-1D0F-4BC3-8DB8-8CFA09F8AA94@public-files.de>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:drprUYgIsko=;lfwGdT9vdEHSO876eZlvpXiTruf
 bPKCupHUQU481noFTmxoTV+MAdHAdySN+LsY41W07L1W/ZwuyTr3HaZ4mBC0lTQY0RWfWS7DF
 jdoeKrWf+/BZ2VSWYIhDwiWOkq1oohhlxs7h1xwOqQR0j4hb6qopX4BJtuERvbY7eBdxwjkvI
 mrB1ou0/C7+iyqmYbXnbHFXwfzF4eF0dKaWaQbDQPFBHo8ju2vPZFBhvi+N6+hAt+T+vbRxQ9
 EOcaevb8UJ1w12/CvOEGZydfzbXNoUzstE+V8j2zSt6utty885YOLA1XWbAFskZ4nXFNbU+az
 yte4HmG2lZlskrCHk4plSMvAdqQeVHb8mdfG/L7HuVc1InlTCSTcJRLoz9qXf021Z2G+2qmwy
 y8oE4HfyzV9r3Jp3qIcJzny9i+w5Jmr8K/T2bmAB3R8Gpzpup8/1lWKGd1U+YSp7sY527tfgN
 FEM/m50nG7SJdcXQZURQKWyRo2UIhcygFfgOqZ9/AlBuQdsMZwShq5agFY/kxJrit9M0uOv/K
 f4JF53TYE8viqipgN7mg80n2tdpSR902jRiw4ZBmxFGXqsoCTncYsjVyPCVEN7y7qmSdAw70U
 +EN1kf8Pjx3mm8DDIKrKP7WqAH2dtEpr0wG/DtDKoSdqr9w+0HCXJ4ep9d4+iQ/bfbscOgqgA
 4g0AYxdmQzXhNIJq0w0iYhQjwD9vKZX3IuImhfoo2ova1IgsWZAqR8fO8vWnxHoNeATjMSwYd
 GdLetfkFJ8zGshBpg0Mp0bpas6faP37TBZHKAcyE6HETF89/sJDSM/RSFL2tqshSSBt5//M8c
 /TgXyKZVY5oHgWjSeoFg8wjU2zfEceHkmuZAkJ4a2aMuWjVxRp4th50cPGNnSO2D2fe+rl8SO
 M2YkVLL/AcscZdnAipmVUI236Cy4IW3XMMSCXxrDZnNOS/ijV+qtTI+nwE/gGKwvhOBnK2bIZ
 zxOhs9A3On0k74n6U4jb8Bzd7X0=
Precedence: bulk

Am 16=2E Juni 2023 04:53:25 MESZ schrieb arinc9=2Eunal@gmail=2Ecom:
>From: Ar=C4=B1n=C3=A7 =C3=9CNAL <arinc=2Eunal@arinc9=2Ecom>
>
>LLDP frames are link-local frames, therefore they must be trapped to the
>CPU port=2E Currently, the MT753X switches treat LLDP frames as regular
>multicast frames, therefore flooding them to user ports=2E To fix this, s=
et
>LLDP frames to be trapped to the CPU port(s)=2E
>
>Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek MT7530 =
switch")
>Signed-off-by: Ar=C4=B1n=C3=A7 =C3=9CNAL <arinc=2Eunal@arinc9=2Ecom>
>---
> drivers/net/dsa/mt7530=2Ec | 8 ++++++++
> drivers/net/dsa/mt7530=2Eh | 5 +++++
> 2 files changed, 13 insertions(+)
>
>diff --git a/drivers/net/dsa/mt7530=2Ec b/drivers/net/dsa/mt7530=2Ec
>index 7b72cf3a0e30=2E=2Ec85876fd9107 100644
>--- a/drivers/net/dsa/mt7530=2Ec
>+++ b/drivers/net/dsa/mt7530=2Ec
>@@ -2266,6 +2266,10 @@ mt7530_setup(struct dsa_switch *ds)
> 	mt7530_rmw(priv, MT753X_BPC, MT753X_BPDU_PORT_FW_MASK,
> 		   MT753X_BPDU_CPU_ONLY);
>=20
>+	/* Trap LLDP frames with :0E MAC DA to the CPU port */
>+	mt7530_rmw(priv, MT753X_RGAC2, MT753X_R0E_PORT_FW_MASK,
>+		   MT753X_R0E_PORT_FW(MT753X_BPDU_CPU_ONLY));
>+
> 	/* Enable and reset MIB counters */
> 	mt7530_mib_reset(ds);
>=20
>@@ -2369,6 +2373,10 @@ mt7531_setup_common(struct dsa_switch *ds)
> 	mt7530_rmw(priv, MT753X_BPC, MT753X_BPDU_PORT_FW_MASK,
> 		   MT753X_BPDU_CPU_ONLY);
>=20
>+	/* Trap LLDP frames with :0E MAC DA to the CPU port(s) */
>+	mt7530_rmw(priv, MT753X_RGAC2, MT753X_R0E_PORT_FW_MASK,
>+		   MT753X_R0E_PORT_FW(MT753X_BPDU_CPU_ONLY));
>+
> 	/* Enable and reset MIB counters */
> 	mt7530_mib_reset(ds);
>=20


I though these 2 hunks should go into some common function as these are re=
dundant or am i wrong?

Btw=2Ethx for your work on this driver :)

regards Frank