Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230616031420.3751973-1-kan.liang@linux.intel.com> <20230616031420.3751973-6-kan.liang@linux.intel.com>
In-Reply-To: <20230616031420.3751973-6-kan.liang@linux.intel.com>
From:   Ian Rogers <irogers@google.com>
Date:   Thu, 15 Jun 2023 22:57:29 -0700
Message-ID: <CAP-5=fUOJFkV7Dtb973qOb0QLkg1EgoGKRqVDF23zUDwJTDvbg@mail.gmail.com>
Subject: Re: [PATCH V4 5/5] perf vendor events arm64: Add default tags for
 Hisi hip08 L1 metrics
To:     kan.liang@linux.intel.com
Cc:     acme@kernel.org, mingo@redhat.com, peterz@infradead.org,
        namhyung@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        ak@linux.intel.com, eranian@google.com, ahmad.yasin@intel.com,
        John Garry <john.g.garry@oracle.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jun 15, 2023 at 8:15=E2=80=AFPM <kan.liang@linux.intel.com> wrote:
>
> From: Kan Liang <kan.liang@linux.intel.com>
>
> Add the default tags for Hisi hip08 as well.
>
> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> Cc: John Garry <john.g.garry@oracle.com>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  .../arch/arm64/hisilicon/hip08/metrics.json          | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/metrics.jso=
n b/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/metrics.json
> index 6443a061e22a..6463531b9941 100644
> --- a/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/metrics.json
> +++ b/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/metrics.json
> @@ -3,28 +3,32 @@
>          "MetricExpr": "FETCH_BUBBLE / (4 * CPU_CYCLES)",
>          "PublicDescription": "Frontend bound L1 topdown metric",
>          "BriefDescription": "Frontend bound L1 topdown metric",
> -        "MetricGroup": "TopDownL1",
> +        "DefaultMetricgroupName": "TopDownL1",
> +        "MetricGroup": "Default;TopDownL1",
>          "MetricName": "frontend_bound"
>      },
>      {
>          "MetricExpr": "(INST_SPEC - INST_RETIRED) / (4 * CPU_CYCLES)",
>          "PublicDescription": "Bad Speculation L1 topdown metric",
>          "BriefDescription": "Bad Speculation L1 topdown metric",
> -        "MetricGroup": "TopDownL1",
> +        "DefaultMetricgroupName": "TopDownL1",
> +        "MetricGroup": "Default;TopDownL1",
>          "MetricName": "bad_speculation"
>      },
>      {
>          "MetricExpr": "INST_RETIRED / (CPU_CYCLES * 4)",
>          "PublicDescription": "Retiring L1 topdown metric",
>          "BriefDescription": "Retiring L1 topdown metric",
> -        "MetricGroup": "TopDownL1",
> +        "DefaultMetricgroupName": "TopDownL1",
> +        "MetricGroup": "Default;TopDownL1",
>          "MetricName": "retiring"
>      },
>      {
>          "MetricExpr": "1 - (frontend_bound + bad_speculation + retiring)=
",
>          "PublicDescription": "Backend Bound L1 topdown metric",
>          "BriefDescription": "Backend Bound L1 topdown metric",
> -        "MetricGroup": "TopDownL1",
> +        "DefaultMetricgroupName": "TopDownL1",
> +        "MetricGroup": "Default;TopDownL1",
>          "MetricName": "backend_bound"
>      },
>      {
> --
> 2.35.1
>