Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 08:06:00 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Frank Wang <frank.wang@rock-chips.com>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        heikki.krogerus@linux.intel.com, sebastian.reichel@collabora.com,
        heiko@sntech.de, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
        huangtao@rock-chips.com, william.wu@rock-chips.com,
        jianwei.zheng@rock-chips.com, yubing.zhang@rock-chips.com,
        wmc@rock-chips.com
Subject: Re: usb: typec: tcpm: fix cc role at port reset
Message-ID: <2023061643-uplifting-sequester-0152@gregkh>
References: <20230616022001.25819-1-frank.wang@rock-chips.com>
 <3c3fbecd-caf9-c432-0890-93cceade98c1@roeck-us.net>
 <f4bc4e7e-b9d4-432b-2157-f5b30c160a3a@rock-chips.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f4bc4e7e-b9d4-432b-2157-f5b30c160a3a@rock-chips.com>
Precedence: bulk

On Fri, Jun 16, 2023 at 11:03:14AM +0800, Frank Wang wrote:
> Hi Guenter,
> 
> On 2023/6/16 10:27, Guenter Roeck wrote:
> > On 6/15/23 19:20, Frank Wang wrote:
> > > In the current implementation, the tcpm set CC1/CC2 role to open when
> > > it do port reset would cause the VBUS removed by the Type-C partner.
> > > 
> > > This sets CC1/CC2 according to the default state of port to fix it.
> > > 
> > > Comments are suggested by Guenter Roeck.
> > > 
> > 
> > I have no idea (recollection) of what I suggested here :-(
> 
> Aha, this is also an old patch I have sent before, you suggested that the cc
> role should require some tweaking based on the port type or default state,
> do you remember it now?

Please version the patch, and provide the change information as
documented.

thanks,

greg k-h