Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Hongyu Xie <xiehongyu1@kylinos.cn>
To:     linux@armlinux.org.uk, gregkh@linuxfoundation.org,
        jirislaby@kernel.org, corbet@lwn.net
Cc:     rdunlap@infradead.org, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org, xy521521@gmail.com,
        oe-kbuild-all@lists.linux.dev, lkp@intel.com, bagasdotme@gmail.com,
        Hongyu Xie <xiehongyu1@kylinos.cn>
Subject: Re: [RESEND PATCH v4 -next] tty: serial: add panic serial helper
Date:   Fri, 16 Jun 2023 14:19:50 +0800
Message-Id: <32e022c7-f041-3bf2-2f68-3ed2119c951d@kylinos.cn>
In-Reply-To: <2023061606-hunk-overdraft-8d04@gregkh>
References: <20230614025512.27746-1-xiehongyu1@kylinos.cn> <2023061502-submerge-preachy-4413@gregkh> <fbfbbad5-2418-5c1a-87f1-dc2ca20204aa@kylinos.cn> <2023061606-hunk-overdraft-8d04@gregkh>
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0
Content-Language: en-US
Fcc:    imap://xiehongyu1%40kylinos.cn@imap.kylinos.cn/Sent
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8BIT
Precedence: bulk

在 2023/6/16 14:03, Greg KH 写道:

> On Fri, Jun 16, 2023 at 10:31:15AM +0800, Hongyu Xie wrote:

>> 在 2023/6/15 18:17, Greg KH 写道:

>>> On Wed, Jun 14, 2023 at 10:55:12AM +0800, Hongyu Xie wrote:

>>>> It was inspired by kgdboc.

>>>>

>>>> This is a debug module that allows you to get all kernel logs

>>>> after panic.

>>>>

>>>> Normally you need to attach a USB-to-UART tool or enable kdump

>>>> before panic happens to get log from kernel after panic. If you

>>>> didn't do that and kdump is not working, you can't get any log to

>>>> know what happened before panic. If you have a USB-to-UART tool

>>>> and the UART port on your computer is working. This module helps

>>>> you to get all kernel log after panic() is called.

>>>>

>>>> To use this, see Documentation/dev-tools/panic_serial_helper.rst.

>>>>

>>>> Tested on an arm64 device.

>>>>

>>>> Signed-off-by: Hongyu Xie <xiehongyu1@kylinos.cn>

>>>> ---

>>>

>>> Why  is this a RESEND?  What's wrong with the previous version?

>> Nobody review v4 for over a week.

> 

> That's fine, but you need to say _why_ this is being resent, otherwise

> we have no idea, and this just moves to the bottom of our review queue.

"Nobody review v4 for over a week." was the reason. I should resubmit 

the same patch or ping instead of using "RESEND", is that what you mean?


> 

> thanks,

> 

> greg k-h

thanks,


Hongyu Xie