Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230616012136.3047071-1-yukuai1@huaweicloud.com>
In-Reply-To: <20230616012136.3047071-1-yukuai1@huaweicloud.com>
From:   Song Liu <song@kernel.org>
Date:   Thu, 15 Jun 2023 23:27:47 -0700
Message-ID: <CAPhsuW6aSvCEa1khjjmDYGozUEs+Tx75RxfaE1+xL2Y1T6aN=Q@mail.gmail.com>
Subject: Re: [PATCH] md/raid1-10: fix casting from randomized structure in raid1_submit_write()
To:     Yu Kuai <yukuai1@huaweicloud.com>
Cc:     axboe@kernel.dk, nathan@kernel.org, ndesaulniers@google.com,
        yukuai3@huawei.com, linux-raid@vger.kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
        yi.zhang@huawei.com, yangerkun@huawei.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jun 15, 2023 at 6:26=E2=80=AFPM Yu Kuai <yukuai1@huaweicloud.com> w=
rote:
>
> From: Yu Kuai <yukuai3@huawei.com>
>
> Following build error triggered while build with clang version 17.0.0
> with W=3D1(this can't be reporduced with gcc 13.1.0):
>
> drivers/md/raid1-10.c:117:25: error: casting from randomized structure
> pointer type 'struct block_device *' to 'struct md_rdev *'
>      117 |         struct md_rdev *rdev =3D (struct md_rdev *)bio->bi_bde=
v;
>          |                                ^
>
> Fix this by casting 'bio->bi_bdev' to 'void *', as it used to be.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202306142042.fmjfmTF8-lkp@int=
el.com/
> Fixes: 8295efbe68c0 ("md/raid1-10: factor out a helper to submit normal w=
rite")
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>

Applied to md-next.

Thanks,
Song

> ---
>  drivers/md/raid1-10.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid1-10.c b/drivers/md/raid1-10.c
> index 169ebe296f2d..3f22edec70e7 100644
> --- a/drivers/md/raid1-10.c
> +++ b/drivers/md/raid1-10.c
> @@ -116,7 +116,7 @@ static void md_bio_reset_resync_pages(struct bio *bio=
, struct resync_pages *rp,
>
>  static inline void raid1_submit_write(struct bio *bio)
>  {
> -       struct md_rdev *rdev =3D (struct md_rdev *)bio->bi_bdev;
> +       struct md_rdev *rdev =3D (void *)bio->bi_bdev;
>
>         bio->bi_next =3D NULL;
>         bio_set_dev(bio, rdev->bdev);
> --
> 2.39.2
>