Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230614084740.1493969-1-linan666@huaweicloud.com> <5c6ff37b-4285-f62a-c910-67401b0b9c1f@huaweicloud.com>
In-Reply-To: <5c6ff37b-4285-f62a-c910-67401b0b9c1f@huaweicloud.com>
From:   Song Liu <song@kernel.org>
Date:   Fri, 16 Jun 2023 00:03:53 -0700
Message-ID: <CAPhsuW54rgL-b3e-oGPsxAdd4FAJ-eEFTcpkZRi8dNxsuAheow@mail.gmail.com>
Subject: Re: [PATCH 0/3] md/raid10: record rdev/replacement in r10bio
To:     Yu Kuai <yukuai1@huaweicloud.com>
Cc:     linan666@huaweicloud.com, neilb@suse.de,
        linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
        linan122@huawei.com, yi.zhang@huawei.com, houtao1@huawei.com,
        yangerkun@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jun 14, 2023 at 8:31=E2=80=AFPM Yu Kuai <yukuai1@huaweicloud.com> w=
rote:
>
> Hi,
>
> =E5=9C=A8 2023/06/14 16:47, linan666@huaweicloud.com =E5=86=99=E9=81=93:
> > From: Li Nan <linan122@huawei.com>
> >
> > Replacement can replace rdev during replacement io pending.
> > mirror->rdev/replacement might be changed during io pending. Get rdev f=
rom
> > it is risky. This patch series record rdev/replacement in r10bio, and g=
et
> > rdev from r10bio to fix bugs in normal write. And I want to do
> > this for each io type later.
>
> I personally don't like this, do things by half. I'm good with this
> approch for raid10, but can you send a new version to use this for all
> io?

Agreed. Please send the fix for all types.

Thanks,
Song