Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 15:07:32 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Karny, Wyes" <Wyes.Karny@amd.com>
Cc:     "rafael@kernel.org" <rafael@kernel.org>,
        "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
        "trenn@suse.com" <trenn@suse.com>,
        "shuah@kernel.org" <shuah@kernel.org>,
        "Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 1/6] amd-pstate: Make amd-pstate epp driver name
 hyphenated
Message-ID: <ZIwKNI6OvhZles5F@amd.com>
References: <20230612113615.205353-1-wyes.karny@amd.com>
 <20230612113615.205353-2-wyes.karny@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230612113615.205353-2-wyes.karny@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LWAihQUS4nJVYCxPIAaqSzyxQqVCd36C1J91JyojzrZQ2xiHM0e+PPMMvdZ6?=
 =?us-ascii?Q?sxSvoFZjlA0mcBIT/xq2Adja/XeA+7mQGms9q66VRjeuxWGOUTi5lx4SqN2J?=
 =?us-ascii?Q?eaiiPv4ug7CO4uLhkMRKRMX8yFzn40XvWq1jqCNdutgYgTbWheSbE1Qe7DK8?=
 =?us-ascii?Q?T9cUbtiNyXl9ryM5wDZvF0tTdc1x0ojsVFSvNpJ1oqlLRpqzHS6Vs1u70djP?=
 =?us-ascii?Q?8lYCmOJqPRd3vQcOfoGNnXG90MJ3SORLrIIbNwYSkU36vPDa2ht2Dnu9R30d?=
 =?us-ascii?Q?T3h7ZibgW33uWA+SX+KiVETvOG7lfflT6fkLHmmj76sAD2vUbFRWGxmvN/vD?=
 =?us-ascii?Q?t7i8YDgYyWiSWwhI6qjzUQsJy+CUpswOTmxj85+GwWdgGkRbQulbMFBj3e2G?=
 =?us-ascii?Q?LWVQFjJXK5glt4RI+S0svDGwqeH86Mp31+ywD/nnUYq5HRR9HlG7qp2BrHvY?=
 =?us-ascii?Q?yim2edXU3G64wGPVmlKnrYoVinZOp0M6eIUhH2YMMW9MJ9pUT9WHG1dXV4Qh?=
 =?us-ascii?Q?YzN6NUTsBoKS1FrUMuV/gf7oNoSTHPE1/nxCe5F8MXXdJznksD55upm/RrAw?=
 =?us-ascii?Q?De8xRBEvKjkgyRgSU2jhy6x7tsugMbjF+DLF1hH+OJH0B2D7kdLOSEkQsHCN?=
 =?us-ascii?Q?dM7GP8eLWxzFfDRiMKOi15MOhfZ9rM7lM/MaUG4E15fHDcSihB/jXeXVY7S4?=
 =?us-ascii?Q?FNeJ6OfzfJ6s5CJ0bY3tIn9dH5ZWv1U29p3eIns3LFJoilhY637Kjfzus+rj?=
 =?us-ascii?Q?xxDGCgTTjgXcRJvIQOVMVFASLvm/yoMETxJIqBysXEdLAwjimZMSa+qT4bY2?=
 =?us-ascii?Q?kaAtON39m/pYkA8DRFulRwc1hKNfQ+NrLvRKfVIDcV2z9Qfn/h+/cX9S1p7t?=
 =?us-ascii?Q?jS2l3OQXWcBcyRPgrQNuW3DvWhfu0E+i/jL4zx+IK6HfxE5K4FR4i5BAHmUE?=
 =?us-ascii?Q?Pj4XaGm2qhXphskesoBCkZFO7SpeitO+miyDY0ibl1hQX3jqvhICCtgXbHS2?=
 =?us-ascii?Q?DhfEyVJiVtzEOdr/8mMsBPMdMUNqeZKbkSNuB+JzlJv8GiqE2nS0GHVhpltM?=
 =?us-ascii?Q?HogMR7W9HNRE/HTtnN5hOjsb8mJRkRBrgzcF3GUPnF9nBDTqZQRF1ZQE7Fhy?=
 =?us-ascii?Q?42PZPeL76UmV7mokzA+zDvj26HPGuZSAipaAOPfp9wWXHtUX4nqa/rBVvks9?=
 =?us-ascii?Q?B9Lrx8fEYErb4v5nB+l5RQZIZ26IyCYI8VnHG9ndjjHYWOjOfbDKgIEAn2Es?=
 =?us-ascii?Q?MyB5BhCzyTf/2WvFXjEydAXDXMH7a2hsIDLZ74GyPPg/xq8cTws8s7+xPpz1?=
 =?us-ascii?Q?82V74JcE+/XD/ZS6Ts8IlB2RYmQ5P9lfuC6vhMXjnyMsXQgeczElXA0Rq89b?=
 =?us-ascii?Q?405il/9oVhlDL7cbgzhQFjXhYISy1H0k6aLZufb6f/Bi9mC7NOsziTsveH4Q?=
 =?us-ascii?Q?Yr5SzZkXUHnioXFvKngUFjm5SOBl0rmWiPnrCgsix+m2mpHLZdmOx5BfflXv?=
 =?us-ascii?Q?hXkaYy7gilkvEqNwe5ll8HVlbl0h+pUX8Fv+Tdbt3ihW/S/l8Df1dmvmyh5K?=
 =?us-ascii?Q?wum3Y4rGXw797sztzszngyWrwzcrB/jr10WtLepa?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c4274686-20f1-4041-74e3-08db6e386a44
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 07:07:58.5346
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3KsdnPVXMT2KLF2TaKGbKdu062gQbwG4O7DYQ5BF8RoVCYOmD8NV/xUKEPf3DE7IoFLWsT1PnN9QOdwCQssypQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8018
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 12, 2023 at 07:36:10PM +0800, Karny, Wyes wrote:
> amd-pstate passive mode driver is hyphenated. So make amd-pstate active
> mode driver consistent with that rename "amd_pstate_epp" to
> "amd-pstate-epp".
> 
> Cc: stable@vger.kernel.org
> Fixes: ffa5096a7c33 ("cpufreq: amd-pstate: implement Pstate EPP support for the AMD processors")
> Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
> Signed-off-by: Wyes Karny <wyes.karny@amd.com>

Acked-by: Huang Rui <ray.huang@amd.com>

And yes, we should seprate it from cpupower as Rafael mentioned. cpupower
tool may go to another repo.

Thanks,
Ray

> ---
>  drivers/cpufreq/amd-pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index ddd346a239e0..a5764946434c 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1356,7 +1356,7 @@ static struct cpufreq_driver amd_pstate_epp_driver = {
>  	.online		= amd_pstate_epp_cpu_online,
>  	.suspend	= amd_pstate_epp_suspend,
>  	.resume		= amd_pstate_epp_resume,
> -	.name		= "amd_pstate_epp",
> +	.name		= "amd-pstate-epp",
>  	.attr		= amd_pstate_epp_attr,
>  };
>  
> -- 
> 2.34.1
>