Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 15:29:59 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Karny, Wyes" <Wyes.Karny@amd.com>
Cc:     "rafael@kernel.org" <rafael@kernel.org>,
        "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
        "trenn@suse.com" <trenn@suse.com>,
        "shuah@kernel.org" <shuah@kernel.org>,
        "Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/6] cpupower: Add turbo-boost support in cpupower
Message-ID: <ZIwPdzc8Bfv/cvTh@amd.com>
References: <20230612113615.205353-1-wyes.karny@amd.com>
 <20230612113615.205353-7-wyes.karny@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230612113615.205353-7-wyes.karny@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?79qyINxMXhhga0MLHAQIMRS1P9E4oLq9VaYOvO/Nu7TWoIGkChNvv9aemjpS?=
 =?us-ascii?Q?mjK+g+2f/0hfUeFDrdgablm5o/g9phy5FHKkJdyytvbeh5L2Qh2Cox9UlH3l?=
 =?us-ascii?Q?6GJUNCMEaUJo3PCcY24OIi2z9+FSA8sXWVJJejKFGHD10KyG9UxC8DiD+iaG?=
 =?us-ascii?Q?2udg2aFuYqj5hZKSt5cdjcVvCtN8Si47vTwZ4GRkl63oF8/7rgNkjQpgtrDK?=
 =?us-ascii?Q?IoJ556RaeoFW2baxxowO8wZDWmtkNv5tSc/TTNGowu3eyGCz2OJmrlaMutZZ?=
 =?us-ascii?Q?qtjNoZiAiMPQBZ6xyknutwDIqfceZiani+whDWgmBU7NmBV87KcBDDByIqou?=
 =?us-ascii?Q?QfIJYTbjEzwceBOUijmgibqDwK1CQbc+dOKM8ZqbzYtIIEfLavTU+1v8YvHK?=
 =?us-ascii?Q?ABIBpAaWjqEG1sZn/HI1x2/TQGYSImIUThTmEWngIoIasWPJH4s+dcsi2XsQ?=
 =?us-ascii?Q?0/FCpPTBFlUrD5UjLdE2auu2CDuCWh+B2xZbsprT1lZbSH0kCnOOtNWBZfI9?=
 =?us-ascii?Q?+bDOS2mJ16qPJTcXitu+6c3NoRC7o1MbZtEqrZLnnmWPpHYlSkhfE21AdcdX?=
 =?us-ascii?Q?ccG8aAK7CtqIgcBGNa7TYRQPrQ/0gcNtPEUj3xQozEEzLOHYwfC/Lk8zNiHM?=
 =?us-ascii?Q?NRPUxI/kHgLy9fttQyNVk0Sf1ZGBNYafRoq1m8yMvKi5kzVt9sa4NOa4E7rL?=
 =?us-ascii?Q?Pzc4RQOUPCZ4fVUyBrPqhWuAHsLe4Diq8MjGh24Df6oRMwuihplSxVn3Rpy/?=
 =?us-ascii?Q?mncSLRRd19csSdtrAPBGXXYrqZuwx+MSwy4n1fQJ3W4zCiihJVEZ8WVs5FoG?=
 =?us-ascii?Q?6PqpYTA59xMNyHK83Csdrw0KpcsMbpZrW05XWfMhv9obI6zDrerxV/ulrJR8?=
 =?us-ascii?Q?e8NXHKjiYrsDQskLKIiKiksGobR9UMJ0Wgd4EZ3y4Cu+yk0PKDaVASy3pCNC?=
 =?us-ascii?Q?Rsblzt0KMe9kcp5+J1aIvlta49GSh+RFRVYjFycbFvn/mW7LAJm/NV6o/mO8?=
 =?us-ascii?Q?oXrY5FXozMRTJnbhYMm/4DLuBn2QF5Iu8nmv626uMXKoELC/itaLNmq57wi1?=
 =?us-ascii?Q?PD7lslKlyd1GVV4QGz2ny5ecFLDcthHRNEH74vXroNz8s5ip/I6Yl+hbSPXl?=
 =?us-ascii?Q?hXvBLlKQ9pco4ZxCvp+9KVJS9eAW66FeMWAg/jj7UaJc+7FFeG62JAx61m2A?=
 =?us-ascii?Q?kv4ie0sI1tCvVTvNCkCsXLNx7gGHdOQKdgWEK/OdmstCRSLaUOXuuIJ0EFfm?=
 =?us-ascii?Q?HtNoYFNkJnRbGiLvC+CISpxINWZFDWBy6sfrNfxLRCwCXrrFO3oaNOWxxnH+?=
 =?us-ascii?Q?XbR4xn3rK5h5k+/0QjqZnUBI5rmsmqsiv3z0nQUK/zuGMthSNEJ4W6z3GRaU?=
 =?us-ascii?Q?o0SYqLMSwVqyF7N3dCNIOcq5Tz+6Dm/v9emfvJepE0Aktuv6EWaHmULRHq15?=
 =?us-ascii?Q?k4hoby+3YV5dV08J5Qexsq7aAmqsrETEdbLlGzybDFTqUrfOEEjM3OBUKfxC?=
 =?us-ascii?Q?ItTO0iWqY8vtsZYJajEPZxptzWYSoi5t9LDoZQYddOGyzr6TVXqYY+1gQzG8?=
 =?us-ascii?Q?6ORlDVJ0Z8vIZMbT9kb828hSkT9f+V5GqOiE17zr?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d8f8cc8c-daff-44b7-875d-08db6e3b8c3f
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 07:30:23.9585
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Dey0fGABrpHmtvmunMPTu+iyN7dx0GW2PErJ9T1TPEEPYytzm4oqRzYcwDylul45AdMZmXjE1Kr1SeNg9ExvsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4065
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 12, 2023 at 07:36:15PM +0800, Karny, Wyes wrote:
> If boost sysfs (/sys/devices/system/cpu/cpufreq/boost) file is present
> turbo-boost is feature is supported in the hardware. By default this
> feature should be enabled. But to disable/enable it write to the sysfs
> file. Use the same to control this feature via cpupower.
> 
> To enable:
> cpupower set --turbo-boost 1
> 
> To disable:
> cpupower set --turbo-boost 0
> 
> Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
> Signed-off-by: Wyes Karny <wyes.karny@amd.com>

Acked-by: Huang Rui <ray.huang@amd.com>

> ---
>  tools/power/cpupower/utils/cpupower-set.c    | 22 +++++++++++++++++++-
>  tools/power/cpupower/utils/helpers/helpers.h |  3 +++
>  tools/power/cpupower/utils/helpers/misc.c    | 18 ++++++++++++++++
>  3 files changed, 42 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/power/cpupower/utils/cpupower-set.c b/tools/power/cpupower/utils/cpupower-set.c
> index c2ba69b7ea54..0677b58374ab 100644
> --- a/tools/power/cpupower/utils/cpupower-set.c
> +++ b/tools/power/cpupower/utils/cpupower-set.c
> @@ -20,6 +20,7 @@ static struct option set_opts[] = {
>  	{"perf-bias", required_argument, NULL, 'b'},
>  	{"epp", required_argument, NULL, 'e'},
>  	{"amd-pstate-mode", required_argument, NULL, 'm'},
> +	{"turbo-boost", required_argument, NULL, 't'},
>  	{ },
>  };
>  
> @@ -41,10 +42,11 @@ int cmd_set(int argc, char **argv)
>  			int perf_bias:1;
>  			int epp:1;
>  			int mode:1;
> +			int turbo_boost:1;
>  		};
>  		int params;
>  	} params;
> -	int perf_bias = 0;
> +	int perf_bias = 0, turbo_boost = 1;
>  	int ret = 0;
>  	char epp[30], mode[20];
>  
> @@ -94,6 +96,18 @@ int cmd_set(int argc, char **argv)
>  			}
>  			params.mode = 1;
>  			break;
> +		case 't':
> +			if (params.turbo_boost)
> +				print_wrong_arg_exit();
> +			turbo_boost = atoi(optarg);
> +			if (turbo_boost < 0 || turbo_boost > 1) {
> +				printf("--turbo-boost param out of range [0-1]\n");
> +				print_wrong_arg_exit();
> +			}
> +			params.turbo_boost = 1;
> +			break;
> +
> +
>  		default:
>  			print_wrong_arg_exit();
>  		}
> @@ -108,6 +122,12 @@ int cmd_set(int argc, char **argv)
>  			fprintf(stderr, "Error setting mode\n");
>  	}
>  
> +	if (params.turbo_boost) {
> +		ret = cpupower_set_turbo_boost(turbo_boost);
> +		if (ret)
> +			fprintf(stderr, "Error setting turbo-boost\n");
> +	}
> +
>  	/* Default is: set all CPUs */
>  	if (bitmask_isallclear(cpus_chosen))
>  		bitmask_setall(cpus_chosen);
> diff --git a/tools/power/cpupower/utils/helpers/helpers.h b/tools/power/cpupower/utils/helpers/helpers.h
> index d35596631eef..95749b8ee475 100644
> --- a/tools/power/cpupower/utils/helpers/helpers.h
> +++ b/tools/power/cpupower/utils/helpers/helpers.h
> @@ -118,6 +118,7 @@ extern unsigned long long msr_intel_get_turbo_ratio(unsigned int cpu);
>  
>  extern int cpupower_set_epp(unsigned int cpu, char *epp);
>  extern int cpupower_set_amd_pstate_mode(char *mode);
> +extern int cpupower_set_turbo_boost(int turbo_boost);
>  
>  /* Read/Write msr ****************************/
>  
> @@ -180,6 +181,8 @@ static inline int cpupower_set_epp(unsigned int cpu, char *epp)
>  { return -1; };
>  static inline int cpupower_set_amd_pstate_mode(char *mode)
>  { return -1; };
> +static inline int cpupower_set_turbo_boost(int turbo_boost)
> +{ return -1; };
>  
>  /* Read/Write msr ****************************/
>  
> diff --git a/tools/power/cpupower/utils/helpers/misc.c b/tools/power/cpupower/utils/helpers/misc.c
> index 9df9af8a969e..fc822a0e6b7b 100644
> --- a/tools/power/cpupower/utils/helpers/misc.c
> +++ b/tools/power/cpupower/utils/helpers/misc.c
> @@ -124,6 +124,24 @@ int cpupower_set_amd_pstate_mode(char *mode)
>  	return 0;
>  }
>  
> +int cpupower_set_turbo_boost(int turbo_boost)
> +{
> +	char path[SYSFS_PATH_MAX];
> +	char linebuf[2] = {};
> +
> +	snprintf(path, sizeof(path), PATH_TO_CPU "cpufreq/boost");
> +
> +	if (!is_valid_path(path))
> +		return -1;
> +
> +	snprintf(linebuf, sizeof(linebuf), "%d", turbo_boost);
> +
> +	if (cpupower_write_sysfs(path, linebuf, 2) <= 0)
> +		return -1;
> +
> +	return 0;
> +}
> +
>  bool cpupower_amd_pstate_enabled(void)
>  {
>  	char *driver = cpufreq_get_driver(0);
> -- 
> 2.34.1
>