Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alison Wang <alison.wang@nxp.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Leo Li <leoyang.li@nxp.com>, Forrest Shi <xuelin.shi@nxp.com>,
        "X.F. Ren" <xiaofeng.ren@nxp.com>, Feng Guo <feng.guo@nxp.com>
Subject: RE: [EXT] Re: [PATCH 1/8] ethosu: Add Arm Ethos-U driver
Thread-Topic: [EXT] Re: [PATCH 1/8] ethosu: Add Arm Ethos-U driver
Thread-Index: AQHZoBVsg6habxYIbEmfvjjh7HkyA6+M9tUAgAAaD2A=
Date:   Fri, 16 Jun 2023 08:28:59 +0000
Message-ID: <AM9PR04MB890708494C6FBC3FC0DE63CFF458A@AM9PR04MB8907.eurprd04.prod.outlook.com>
References: <20230616055913.2360-1-alison.wang@nxp.com>
 <20230616055913.2360-2-alison.wang@nxp.com>
 <2023061638-lushness-jeeringly-314d@gregkh>
In-Reply-To: <2023061638-lushness-jeeringly-314d@gregkh>
Accept-Language: en-US, zh-CN
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UeR29XgknuwlpX0nZOvkykvpCWwT5ls2wgiFXwvQyPU21JLuoZNog7z//9Yk?=
 =?us-ascii?Q?m/kjsGxVoQPZ8HUds0JWehHBl3VLFk1KSwyAGctPucY/Ehdx5m4LBh9JEbuZ?=
 =?us-ascii?Q?LtA6BYPMLTzWdekr9Gbzf8/RkrbMW5p1ec9AAdGS0k+A/qw+zhJtfW4PjKKj?=
 =?us-ascii?Q?Y/SI15DD3cqamEjnAFBfx68ZA7wiDdA1BW6Z5xlC43TQziYutsJWZPYfX3p5?=
 =?us-ascii?Q?qDQxk3L9cGfy4pEuS8cSJXKVHiDs+228nzhzkop6TlV52qGZrScWZ50jHpcy?=
 =?us-ascii?Q?VE9NBQ1vkXtNwZufaCXQEO7z2OXLivPvG7QglgGas9sNXCmo12NBSg0WfMb2?=
 =?us-ascii?Q?HoGrxVJ0gavFP4mE6N756LxZQgAPQJ8j8f84Ja2cDxU0QVm85ugrafpb9YN6?=
 =?us-ascii?Q?uyoMKMpKs04LE2u4bbIjciqJL7EKzksP2XrhIRSGkp1Y0iO1+HU6BoDXgddk?=
 =?us-ascii?Q?BVXPzmYCsjAE61FKf9zWVQ9PZ0WRgwacrNhlHT+Nbu/kLPmnesKvsh3aBtas?=
 =?us-ascii?Q?/EvSQr92aAy0k2HD+GZJ/kfwXCNzg36ggmtIN6sPct1fTjAfZ7EeRiwEkkvA?=
 =?us-ascii?Q?xjsJ9JhCtGWrH4RrbsX/hmNN0qCOss9dBRDykqAw6htzn/GC0tNKFqtkxlju?=
 =?us-ascii?Q?cnUjKAq6nTymBMyTbYVgMTZmYteQzVlRTmHeMmnuWY2r05J3HYnCIboIl/vN?=
 =?us-ascii?Q?QM1VKcGhsVcfqsdDL0MzkwEKmKHVNcC/tmv7qSdNHiNKw6pQHWOon+kcIhXa?=
 =?us-ascii?Q?g7F0l3T2sUwe+hXpX+IHnQ+jaFblW7A9CrO4RcYFNu3cm9CJ8/EIWIvQq9aF?=
 =?us-ascii?Q?nh2nm2bik8rxP2XDroFVZL4RtgjW6M3zw+ez0r/srVQvrc06MbncuiEZ3Q1s?=
 =?us-ascii?Q?x/G4uOqkwX4xDKfjaacc74fLnqOQAGgP7EP2elpHxDIf8htJZM3RUwYKuNgv?=
 =?us-ascii?Q?w//WMHA+UoLvYpYe9ad2R6XGRupRVp1e4ikL1d4/cPQ8iZ3/vJgXgjmT6sdd?=
 =?us-ascii?Q?wJr994gIv45IhgD3lPZsB9E+HttkhxEkf1MeM6ozhXlbb1MYly7P4Ph152A5?=
 =?us-ascii?Q?/Q9I1WAT8/ZG6WUetm5dVyGZzoU7wsRLpA4AXf2bqVpLnTeV0jdlym+BrmZs?=
 =?us-ascii?Q?aRQsFuKyw3j570b3CjgJTok5/HUiJ70GZXcIwGbErejPRgLL+36xSB4YLV/c?=
 =?us-ascii?Q?Fl9+2q+SNuAQto02ExtN4SbYbJoCmomX3VCllpkknrnkkGNJFpaHyun69l9F?=
 =?us-ascii?Q?SGYWxgdXIS+J0SwBBCt/nxpDOREevYp2hYUUDU+RehrkMr1CAq9qQYOcHCpQ?=
 =?us-ascii?Q?UGTKz/u6LTi+C5k5YOZI4YWQd7ZPkdOctT05pIiOwehgKBjscldXaQLlJf65?=
 =?us-ascii?Q?z+kr6Ep4VQ1cy/PlNw5b7dr3K8R/tN+GRiUOqbGfXRkmu1wDDB4p6mJ2Ss+h?=
 =?us-ascii?Q?Q8dHk0Xzo9pCfSer/CT719/G/SvzimDSWZ9GQPfWbHB14RqdAtqrq8PS+ELH?=
 =?us-ascii?Q?RLjcbXXa9AILL08G4f0Gcqp2C70ZDrtp7jOjk7Xryyxkd+ToozWFQwt4EKdp?=
 =?us-ascii?Q?cZveIIvQN5mJU0kAnpIkdrOsHd252fWHo8jWWAP7?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8907.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 42a178b4-215d-42af-a4d9-08db6e43bbdd
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2023 08:28:59.6417
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yr86tPgrLh1rHNlfmPWU3iAXDkesR3iPl13yDO3Sg/pOGDTUFuAr8UMljlyyUov7UsBa+K5uixhK99KXjAGZZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6813
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 16, 2023 at 01:59:06PM +0800, Alison Wang wrote:
> +static int ethosu_buffer_release(struct inode *inode,
> +                              struct file *file) {
> +     struct ethosu_buffer *buf =3D file->private_data;
> +
> +     dev_info(buf->edev->dev, "Buffer release. handle=3D0x%pK\n", buf);

Oh, and please remove your debugging code that you have here, and all over =
the place in the driver.  When drivers work properly, they are quiet, NOT p=
rinting out to the information log.

Are you sure that all of those people reviewed this thing?
[Alison Wang] These codes are also written by Arm guys. I changed dev_info =
to dev_dbg in the later patches.
Ok, I will remove these code.

Thanks a lot for your review.

greg k-h