Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761321AbXJQT2s (ORCPT ); Wed, 17 Oct 2007 15:28:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751641AbXJQT2g (ORCPT ); Wed, 17 Oct 2007 15:28:36 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:52704 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755310AbXJQT2f (ORCPT ); Wed, 17 Oct 2007 15:28:35 -0400 Date: Wed, 17 Oct 2007 21:29:02 +0200 From: Adrian Bunk To: "Darrick J. Wong" , "Mark M. Hoffman" Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org Subject: [2.6 patch] hwmon/ibmpex.c: fix NULL dereference Message-ID: <20071017192902.GB3778@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 873 Lines: 27 Don't dereference "data" when we know for sure it's NULL. Spotted by the Coverity checker. Signed-off-by: Adrian Bunk --- 66bec2ef5c6d55fc30ef6ac5bb97fdfcfaf394f2 diff --git a/drivers/hwmon/ibmpex.c b/drivers/hwmon/ibmpex.c index c462824..e14ce3d 100644 --- a/drivers/hwmon/ibmpex.c +++ b/drivers/hwmon/ibmpex.c @@ -457,7 +457,7 @@ static void ibmpex_register_bmc(int iface, struct device *dev) data = kzalloc(sizeof(*data), GFP_KERNEL); if (!data) { printk(KERN_ERR DRVNAME ": Insufficient memory for BMC " - "interface %d.\n", data->interface); + "interface.\n"); return; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/