Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 12:06:29 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Edward Cree <ecree.xilinx@gmail.com>,
        Martin Habets <habetsm.xilinx@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Alejandro Lucero <alejandro.lucero-palau@amd.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>,
        netdev@vger.kernel.org, linux-net-drivers@amd.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] sfc: add CONFIG_INET dependency for TC offload
Message-ID: <ZIw0JcSb/WvcA1/+@corigine.com>
References: <20230616090844.2677815-1-arnd@kernel.org>
 <20230616090844.2677815-2-arnd@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230616090844.2677815-2-arnd@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XxzYJy+fxq7Ej4EwC+U6DT4XUMeqYJSqA+nr2UUR5uajWxdTAqkPxv9U2Z59?=
 =?us-ascii?Q?C9BP2FGaVTd04FgeaEk/ES0lJnbUan55Mo1vxq2yeJlCVRpMxGxeW8shYQxa?=
 =?us-ascii?Q?zGi3ouQ5sQSDt4Cae2OaoHrSXEeF58uP04MMfAyqdvjLW0xEAvQQ+TElzJCU?=
 =?us-ascii?Q?OAgCxs3iFDKrETsmfRNMap7U+X5vc2ZQay+/U0bWDhZZE8q+Yx1GgDdvKvSc?=
 =?us-ascii?Q?lEFyFtxxk7eYhUdlRvsNBMbvRjSzHyL0ZRbA5gxOEyKLfB6+gAOPwyvqyWbH?=
 =?us-ascii?Q?0yKuIV+B+5j+RWH7+YZnb5OUe4CgTlLlM471Ma9454rzyJKIggsmXMKOTJ/J?=
 =?us-ascii?Q?Dv5wFpVSlGOwwm5d7OQ2GsPQXlD+nyS0VBMS26Reft7gX5yKZoRt1ZymsALl?=
 =?us-ascii?Q?UnJfXTbSFJDX4qpu+BTfAS4hzRD5q/lLiO9tqiRUOKPj27R3SZA6wsgZSMHy?=
 =?us-ascii?Q?683Qn7lTXLq/uomk3v9kjDWCy20gekfOBDzi2MzDcwiQ2RzKR1CNQXUwLDT/?=
 =?us-ascii?Q?HtEMkH5WRnOaPLtYvWfojLZERFkl9pXgV7+y3Ys0h7G4+uMPxMNffQ8L/Okf?=
 =?us-ascii?Q?a+Jp8vcuK/tzphQ9lH3BZZUYG8jgSj2jFsRtFCRNmc+Fmt1IJtqXMWi/3cSZ?=
 =?us-ascii?Q?GJF9mxPX9OPrHrLnu8BbAeRn7PPQ7PoMAKnCGHipx1/7DCUK1PtvN57dlBJI?=
 =?us-ascii?Q?V5RIK0BrsqAhFEzOHPW/yNFtuIMETTDBNCfndOl5zNC+OBxMQXdpdFNDY0yn?=
 =?us-ascii?Q?r01UkKFcbtwybihFTOmyit8e+sAtiw+SVrEpSn72Nt8i2ZwPh3hFIY0PYNkt?=
 =?us-ascii?Q?BdBuhFf3j6VYHF1FDXm7tdjTPn/fzkNq3llCz2J7hBB/JQLE+2zVWgWqui63?=
 =?us-ascii?Q?qwDWvkvZRmZiNX8XdrEVB7H07J8zmaBrgXnCFT0RH1pPa78kp262qqQxq77h?=
 =?us-ascii?Q?WMwwKK/Xq6ZcX0s+rz3basCN7WMpEbJOaJbBaiFmFEMM+PcuszXRTOjAtubS?=
 =?us-ascii?Q?q32WFPks6nMDh395sGSugePA3sWh2p1XrzTcnBgWkd01NgiBbsGkbuRcO+1V?=
 =?us-ascii?Q?n999280itGaSyA+H83x2naWqGP/8UFQNvxUfux8cHVSSsfaIAZHXzwbiDEsJ?=
 =?us-ascii?Q?OurenSpiNehQhhnqxSzBSlmxStApcQlkCGC3rNSx5OiLQFXeORyyiK112JLy?=
 =?us-ascii?Q?N9t7CNZH48jrvhc78rsmAXccGG7+dvOqHpAweh6APvoz+XVLHRE+WQCWhBjI?=
 =?us-ascii?Q?K5EXRUYPCoFNXFseBkmS0gJjMZTqivpIFWcAkechWSdSCpcNpn/YKLiHdHxP?=
 =?us-ascii?Q?KaQuY7LAeVXYfupiS3yHL/5TO0wgD8pxXlnP6nMmtI5lhGuFaJHIkoAQoxPy?=
 =?us-ascii?Q?bKZX443kVMEwXwKLuFGoo5RyjPo+uYBOghgOv/WDK/7K63lkl3HZAwzJW2oQ?=
 =?us-ascii?Q?yX+M8PXLAqJZmd3owODHVNbKQbqpHuyx82N2D7ekx+VOti9JE5QiyyvJNLCK?=
 =?us-ascii?Q?MnN4pE4JjJJlsJ7aiZQTCZqJ8a9F6qhI4SpevvARbhscd/bSlwwNPX2LYjOQ?=
 =?us-ascii?Q?dLaQlSblSGnlJGA77uHKSGO6fRj+dkNLl2oBKChkcwFRSCRQAOz0RRa3v9kB?=
 =?us-ascii?Q?1R8fe04n4vGma5shNprjiJ+fI8ZQY4maJ1ArXHQ99UyaJnnMtKqqApiyagIg?=
 =?us-ascii?Q?AqqTlA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c882ff7-5469-41ba-9790-08db6e515e42
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 10:06:35.6860
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2ZmTGzCVAXmXiBCER0rYM2XGIhAEBPa6vEXQTvFx0ON2angXQY+PoRhmq4eh3lOjBwMj4aGqH8nxQbz28mz8VrwDIejA6DFTVXfKa8i+Exs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR13MB5860
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 16, 2023 at 11:08:19AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The driver now fails to link when CONFIG_INET is disabled, so
> add an explicit Kconfig dependency:
> 
> ld.lld: error: undefined symbol: ip_route_output_flow
> >>> referenced by tc_encap_actions.c
> >>>               drivers/net/ethernet/sfc/tc_encap_actions.o:(efx_tc_flower_create_encap_md) in archive vmlinux.a
> 
> ld.lld: error: undefined symbol: ip_send_check
> >>> referenced by tc_encap_actions.c
> >>>               drivers/net/ethernet/sfc/tc_encap_actions.o:(efx_gen_encap_header) in archive vmlinux.a
> >>> referenced by tc_encap_actions.c
> >>>               drivers/net/ethernet/sfc/tc_encap_actions.o:(efx_gen_encap_header) in archive vmlinux.a
> 
> ld.lld: error: undefined symbol: arp_tbl
> >>> referenced by tc_encap_actions.c
> >>>               drivers/net/ethernet/sfc/tc_encap_actions.o:(efx_tc_netevent_event) in archive vmlinux.a
> >>> referenced by tc_encap_actions.c
> >>>               drivers/net/ethernet/sfc/tc_encap_actions.o:(efx_tc_netevent_event) in archive vmlinux.a
> 
> Fixes: a1e82162af0b8 ("sfc: generate encap headers for TC offload")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Simon Horman <simon.horman@corigine.com>