Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 11:12:57 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Eric Lin <eric.lin@sifive.com>
CC:     <conor@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <palmer@dabbelt.com>,
        <paul.walmsley@sifive.com>, <aou@eecs.berkeley.edu>,
        <maz@kernel.org>, <chenhuacai@kernel.org>,
        <baolu.lu@linux.intel.com>, <will@kernel.org>,
        <kan.liang@linux.intel.com>, <nnac123@linux.ibm.com>,
        <pierre.gondois@arm.com>, <huangguangbin2@huawei.com>,
        <jgross@suse.com>, <chao.gao@intel.com>, <maobibo@loongson.cn>,
        <linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <dslin1010@gmail.com>,
        Greentime Hu <greentime.hu@sifive.com>,
        Zong Li <zong.li@sifive.com>, Nick Hu <nick.hu@sifive.com>
Subject: Re: [PATCH 2/3] soc: sifive: Add SiFive private L2 cache PMU driver
Message-ID: <20230616-revision-speed-a83dc926b334@wendy>
References: <20230616063210.19063-1-eric.lin@sifive.com>
 <20230616063210.19063-3-eric.lin@sifive.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ElvD8fTDzec/LOV5"
Content-Disposition: inline
In-Reply-To: <20230616063210.19063-3-eric.lin@sifive.com>
Precedence: bulk

--ElvD8fTDzec/LOV5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 16, 2023 at 02:32:09PM +0800, Eric Lin wrote:
> From: Greentime Hu <greentime.hu@sifive.com>
>=20
> This adds SiFive private L2 cache PMU driver. User
> can use perf tool to profile by event name and event id.
>=20
> Example:
> $ perf stat -C 0 -e /sifive_pl2_pmu/inner_acquire_block_btot/
>                 -e /sifive_pl2_pmu/inner_acquire_block_ntob/
>                 -e /sifive_pl2_pmu/inner_acquire_block_ntot/ ls
>=20
>  Performance counter stats for 'CPU(s) 0':
>=20
>                300      sifive_pl2_pmu/inner_acquire_block_btot/
>              17801      sifive_pl2_pmu/inner_acquire_block_ntob/
>               5253      sifive_pl2_pmu/inner_acquire_block_ntot/
>=20
>        0.088917326 seconds time elapsed
>=20
> $ perf stat -C 0 -e /sifive_pl2_pmu/event=3D0x10001/
>                 -e /sifive_pl2_pmu/event=3D0x4001/
>                 -e /sifive_pl2_pmu/event=3D0x8001/ ls
>=20
>  Performance counter stats for 'CPU(s) 0':
>=20
>                251      sifive_pl2_pmu/event=3D0x10001/
>               2620      sifive_pl2_pmu/event=3D0x4001/
>                644      sifive_pl2_pmu/event=3D0x8001/
>=20
>        0.092827110 seconds time elapsed
>=20
> Signed-off-by: Greentime Hu <greentime.hu@sifive.com>
> Signed-off-by: Eric Lin <eric.lin@sifive.com>
> Reviewed-by: Zong Li <zong.li@sifive.com>
> Reviewed-by: Nick Hu <nick.hu@sifive.com>
> ---
>  drivers/soc/sifive/Kconfig            |   9 +
>  drivers/soc/sifive/Makefile           |   1 +
>  drivers/soc/sifive/sifive_pl2.h       |  20 +
>  drivers/soc/sifive/sifive_pl2_cache.c |  16 +
>  drivers/soc/sifive/sifive_pl2_pmu.c   | 669 ++++++++++++++++++++++++++

Perf drivers should be in drivers/perf, no?

Cheers,
Conor.

--ElvD8fTDzec/LOV5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZIw1qQAKCRB4tDGHoIJi
0q20AP0SJ+XMu+AbrLQcuJNmsYqvVW9wc6xBagHa9pzRoEw0mwD+K5s2+gB8wow+
BqnI6l1BRUx8VsrF6VfTnTaE4ZlUJQM=
=YDC2
-----END PGP SIGNATURE-----

--ElvD8fTDzec/LOV5--