Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 13:12:10 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Srinivas Goud <srinivas.goud@amd.com>
Cc:     wg@grandegger.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, gcnu.goud@gmail.com,
        git@amd.com, michal.simek@xilinx.com, linux-can@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] can: xilinx_can: Add ECC feature support
Message-ID: <20230616-unneeded-denote-eaa4053514d8-mkl@pengutronix.de>
References: <1686570177-2836108-1-git-send-email-srinivas.goud@amd.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="e3lc5j2mdmuoewkc"
Content-Disposition: inline
In-Reply-To: <1686570177-2836108-1-git-send-email-srinivas.goud@amd.com>
Precedence: bulk


--e3lc5j2mdmuoewkc
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 12.06.2023 17:12:54, Srinivas Goud wrote:
> ECC feature added to Tx and Rx FIFO=E2=80=99s for Xilinx CAN Controller.
> Part of this feature configuration and counter registers added=20
> in Xilinx CAN Controller for 1bit/2bit ECC errors count and reset.
> Please find more details in PG096 v5.1 document.

The document "PG096 (v5.1) May 16, 2023 CAN v5.1" [1] lists the
XCAN_ECC_CFG_OFFSET as reserved, although it has a section "ECC
Configuration Register".

[1] https://docs.xilinx.com/viewer/book-attachment/Bv6XZP9HRonCGi58fl10dw/c=
h1ZLpOt4UKWNub7DXjJ7Q

The other registers (XCAN_TXTLFIFO_ECC_OFFSET, XCAN_TXOLFIFO_ECC_OFFSET,
XCAN_TXOLFIFO_ECC_OFFSET) are also listed as reserved and not even
mentioned on the document. Am I missing something?

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung N=C3=BCrnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

--e3lc5j2mdmuoewkc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEDs2BvajyNKlf9TJQvlAcSiqKBOgFAmSMQ4cACgkQvlAcSiqK
BOif0gf9ENiFw1zub+JvpO4Z15pvxtf+Ge2LoyL6btmGQClJQngT0seWbZwx+qw/
3HsN9fpCmDNQuRiujWa+1otoTC8VnFsbTewdIl3LNGe676uECIytmeptA2SFQN6J
DGSaR4rMdK7yzVlj9Ku0vQxIs8zCEdEFRXsJ4mkgfW2enDNy6CZOd4cYMd8PfaI7
0mXfcuUi4AYXqPWRZMR+ufem1daUvBBHPH77I6JzAtZKF3cc4SgFhrn1e6ywEduP
GCwTUhP4cNVHAGxTVNlXPV+uXe5wwV9WTjtTTPuMhXiAyIz1sDhm2nPaXXnKQoQi
jDvSFgZQlq+i2YRY8lOK4/f0V/FLUg==
=9ddr
-----END PGP SIGNATURE-----

--e3lc5j2mdmuoewkc--