Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 14:23:42 +0200
From:   Marco Felsch <m.felsch@pengutronix.de>
To:     Claudiu Beznea <claudiu.beznea@microchip.com>
Cc:     mchehab@kernel.org, hverkuil-cisco@xs4all.nl, olteanv@gmail.com,
        javierm@redhat.com, sakari.ailus@linux.intel.com,
        srinivas.pandruvada@linux.intel.com,
        u.kleine-koenig@pengutronix.de, laurent.pinchart@ideasonboard.com,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: i2c: tvp5150: check return value of
 devm_kasprintf()
Message-ID: <20230616122342.bc2fgwfek6gl6577@pengutronix.de>
References: <20230615103030.582531-1-claudiu.beznea@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230615103030.582531-1-claudiu.beznea@microchip.com>
User-Agent: NeoMutt/20180716
Precedence: bulk

Hi,

On 23-06-15, Claudiu Beznea wrote:
> devm_kasprintf() returns a pointer to dynamically allocated memory.
> Pointer could be NULL in case allocation fails. Check pointer validity.
> Identified with coccinelle (kmerr.cocci script).

lgtm

> Fixes: 0556f1d580d4 ("media: tvp5150: add input source selection of_graph support")
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>

Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>

> ---
> 
> Hi,
> 
> This has been addressed using kmerr.cocci script proposed for update
> at [1].
> 
> Thank you,
> Claudiu Beznea
> 
> [1] https://lore.kernel.org/all/20230530074044.1603426-1-claudiu.beznea@microchip.com/
> 
>  drivers/media/i2c/tvp5150.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
> index 859f1cb2fa74..84f87c016f9b 100644
> --- a/drivers/media/i2c/tvp5150.c
> +++ b/drivers/media/i2c/tvp5150.c
> @@ -2068,6 +2068,10 @@ static int tvp5150_parse_dt(struct tvp5150 *decoder, struct device_node *np)
>  		tvpc->ent.name = devm_kasprintf(dev, GFP_KERNEL, "%s %s",
>  						v4l2c->name, v4l2c->label ?
>  						v4l2c->label : "");
> +		if (!tvpc->ent.name) {
> +			ret = -ENOMEM;
> +			goto err_free;
> +		}
>  	}
>  
>  	ep_np = of_graph_get_endpoint_by_regs(np, TVP5150_PAD_VID_OUT, 0);
> -- 
> 2.34.1
> 
>