Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2623644rwd; Fri, 16 Jun 2023 06:16:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6RPB8kA2AgQzf84mTImgrnkVvDoDqfX+LYarx91Znj7QzAO5Q2I+/7uza8iCbFO5ZgMeRx X-Received: by 2002:a05:6870:a2c4:b0:19e:1292:c157 with SMTP id w4-20020a056870a2c400b0019e1292c157mr1990968oak.14.1686921381403; Fri, 16 Jun 2023 06:16:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686921381; cv=none; d=google.com; s=arc-20160816; b=CfMQGRu24KhIGp/A3TjH4RmyO7M07mL0Abf3nUl+EO99mUMgXwBmEe/NMYimWLgyQy IomMblvUzVxm5mESkCVMi2JaVKvFneyqVrCd03d5AL/bKF/eK+chE8NMFUGP1JFk3Z/1 DMG5iX6fN/C/ICVPbJxHQOLZvRL1NnZvPN0aJbHtEgj3DVOtuPpbrQj7rq+pr1HW9zqu 08OiO/mSCXsnhTDAGI6pXUj2FthFkeBlgwW9bcvOPl+dQ5vg08MHwzQlg3Z+JFjWPr+g LcFFSnWGoEIf3DeyzECD2bWgbN9tAtTkZi7uAAoQby6zi24oVvxOvgt0h0vNUZILfGbm mUsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=B3/jnd4YgwZcNaAYhklWCxyMxiOd1DrW5p8riYpparY=; b=zE61pihieBliftH/sqvksi1AzxDF7HN+IjpQd6+kGeAUSXqibNm0aW70iMrXiMMeQT C3v/YY+rFpHXweKn7rELy9+8akgMhfSvtMXIv9SgCU1iZi6qmAOnUZPb3dtqy7lD/3xi 9C5/RmWHmhirWLcIpv5CzR1px05mwnXclYREKD+BQY5yalC5EQ0F3pkn+4Oc1VG2EGGl 00hU1ky8mbrpGOpz40yKr33HO8vYj8sHVNdNsTHx62iHUSm/Pk7yN/ctsqrk6IrDUiq4 QfsZS/0dm1q8Ec8F58u3tl+B2289kfm+VnBYOh1tnu1pwDPw5NEWkmAsOCsYeU717qGf 7mFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UYTSwFWo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o14-20020a63920e000000b00543ec968226si11141578pgd.240.2023.06.16.06.16.09; Fri, 16 Jun 2023 06:16:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UYTSwFWo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344396AbjFPNBK (ORCPT + 99 others); Fri, 16 Jun 2023 09:01:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229540AbjFPNBH (ORCPT ); Fri, 16 Jun 2023 09:01:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE85F2133 for ; Fri, 16 Jun 2023 06:01:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3DA3E60E75 for ; Fri, 16 Jun 2023 13:01:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A4E2C433C8; Fri, 16 Jun 2023 13:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686920463; bh=VDhR3aHja601dxfffGSb2Hxfy5D9ToFNcA+dY/sI3ok=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UYTSwFWoOo7Upc91ExoaXialN89psxS6/Peaore+CVr+a1+ThiM0oNKY+RHlgWzKc fdvI6YA5G2VnpnMFXq05VZFd6EY9xT/9R23flvyMruvC/+YVPdYyvdd8NpTPEPAKet lXDIpT+PhY8sya4VbInwK5UjNYV3NMcCIZMobOqZ1ygcMGBlxhF54pWtOIoGO6p5q+ lEp/9romh4+yIXbN6yss/Nr77ru7V+bwgAMuSdne3g/3idAp7QCRD1ecg9+jtWMXTH mmTjVX0IGgp0bjRUSJ9YGCqgqQCuQarHDzmIJKL2cMsJlumdr3Dix1n6VS8jnFcnhH Idtzb/V6Fkrqg== Message-ID: Date: Fri, 16 Jun 2023 15:00:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [RFC PATCH V3 5/6] sched/fair: Add trivial fair server Content-Language: en-US To: Peter Zijlstra Cc: Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org, Luca Abeni , Tommaso Cucinotta , Thomas Gleixner , Joel Fernandes , Vineeth Pillai , Shuah Khan References: <8db5a49ea92ad8b875d331d6136721645a382fe8.1686239016.git.bristot@kernel.org> <20230616125946.GN83892@hirez.programming.kicks-ass.net> From: Daniel Bristot de Oliveira In-Reply-To: <20230616125946.GN83892@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/16/23 14:59, Peter Zijlstra wrote: > On Thu, Jun 08, 2023 at 05:58:17PM +0200, Daniel Bristot de Oliveira wrote: >> +void fair_server_init(struct rq *rq) >> +{ >> + struct sched_dl_entity *dl_se = &rq->fair_server; >> + >> + init_dl_entity(dl_se); >> + >> + dl_se->dl_runtime = TICK_NSEC; >> + dl_se->dl_deadline = 20 * TICK_NSEC; >> + dl_se->dl_period = 20 * TICK_NSEC; >> + >> + dl_server_init(dl_se, rq, fair_server_has_tasks, fair_server_pick); >> +} > > These here numbers should obviously become a tunable somewhere... :-) From sched_rt_runtime and sched_rt_period, no? -- Daniel