Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2640029rwd; Fri, 16 Jun 2023 06:28:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4mxJ3ly6LtISlDsEpn0qJlQ1QARnxx3RZ4EqCxLw0NRzJXJ7kWzSVeZWSYiQrnq05g7UsZ X-Received: by 2002:a05:6a00:3928:b0:64d:46b2:9a58 with SMTP id fh40-20020a056a00392800b0064d46b29a58mr2357728pfb.26.1686922092589; Fri, 16 Jun 2023 06:28:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686922092; cv=none; d=google.com; s=arc-20160816; b=EKcl8gvVBo7Y1IVsLe7uYBpyNAgjkiTvHFPSR4days1xorDEp+nF8ijsHpTEHb08ah TnzjG/4ZtMWb9HtuNiOtedNFejGSTblJCbTMgiUtpFL/tbx0rXPnldAby5pzlWt2uG8j XeBwyWt/qACtHTr4iKfHzzU9e2erYTpxvTyhvbTvWVmay6ZE+ONS4CiDHc/4A4Yh8Y1l 6IXcsq4ab2XXe9ixJABGDzDTu5/7V0VCOnf3kH4Y+2sxMuBj/wkiI+xiz30JcHgkefxJ dPQF62qMTg/RzEb/bc4XY6ALwgCXI1CV0Tb61M956rdLg/c7VXVgmu70kajQiPAG0TGD sLvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=qvdWMVWle3D0jO0S4SA/HhQT1FHM2fbq6dlchswpFvQ=; b=nHFvfKKlcNbVOIqL5uCI6ikBbxLq0HFGmsABlmSSz2vzJMdH0pX7j0OTIzd1KGPecH qSwaJ3uUZw0ig7rTM64o33hOcBZck7NloU4HSGUWTn8TITiQowMAj5D8gruoFKU0V5Os HlJDy88Zz6SkOF8trc290J+cBLY7nvueluSVNdkR+wkT4m0DwxwSTy5lBIYjhMQzsTuH ODdDuG9fttabp9pDRCeJxz9mArU2YTtJiikN/J5+6CyAKduaWzggqEG15kB8grbf2qu+ D+gRW8KGNh799QXPU3H9noWR/SQTPOcbGHgKE+c3NdPgA5StXVTEJLrEigmROdrxrPn+ zb3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Hx0wJI5o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 135-20020a63018d000000b0054fe4986366si4267381pgb.342.2023.06.16.06.27.58; Fri, 16 Jun 2023 06:28:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Hx0wJI5o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244736AbjFPNAc (ORCPT + 99 others); Fri, 16 Jun 2023 09:00:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345281AbjFPNA3 (ORCPT ); Fri, 16 Jun 2023 09:00:29 -0400 Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 463793A87 for ; Fri, 16 Jun 2023 06:00:26 -0700 (PDT) Received: by mail-yb1-xb36.google.com with SMTP id 3f1490d57ef6-bc4651e3838so569978276.2 for ; Fri, 16 Jun 2023 06:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686920425; x=1689512425; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qvdWMVWle3D0jO0S4SA/HhQT1FHM2fbq6dlchswpFvQ=; b=Hx0wJI5o0/Ql3BsLN/+xlaxPAaYG1vT0wNGM833HXlLHTV4nFSvJwjL06xrMfUDkaE +qawKe3EliuGv8MhIVu6FQQmnth06j73ZoHKjhT7xs6bhghiawdCS6VzLvoM1JVuA+IM xlPVWcxgYcGtwgDXG1yJJJMKAEQNLFmP+ub+1s9H4tyepnPk9ze6+PMEOHyaLEChBe0a f5E5TraslYewcPNlC6i3U7waaJQnW2nenVfaixr8AWZPMGoVgbCJfUSh+M62KSc40xBQ +jxsA/5DhAF3DPJl+XbTUPGH1rRnKa7tMIbMe2gv663TVs7hIoyJhLDe73LgRonnmRqQ afNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686920425; x=1689512425; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qvdWMVWle3D0jO0S4SA/HhQT1FHM2fbq6dlchswpFvQ=; b=c9YULhbrXmP6UQ2Lg/heZ/3fermh6bqm1cPHNfU3RHzGkag8XTyofv8ln+78bSy1co R+m5db5dp/5PCrWOg8ZgYZvYhIBFWNMS35UKEogKrDTO3vQjvruTr5aW4VxBPDRBlV6N 4Z93p/ABerBoA9oLqIeJYMP+xMp1/bchtnoc0qc5pH/MfYu2/tF2EZgQRQe+pb4b34Mm sdut5e1fz2fq9lXbN3Rcwb/sR4N0MC58Fq2Zgbk5Af8aWUklzlJ6J7Fl6W1k7WxTzhXR JtDxOdoz5c7iUgFcSIfmlJwTuARXwf3x76B3n1VuJzyhVG9ZVmRb6uiDU/cplyXkVOcI mFmQ== X-Gm-Message-State: AC+VfDyXXPjLC1OqN4iQYXDpiybtB3wcN34QxgzuWLKKZR2JpTXmycU+ 7pmxfW+YeeqxDW873lOjc4gY6RPC5k5Js6lMCb6Hlg== X-Received: by 2002:a25:8908:0:b0:bd4:e6d6:2b8e with SMTP id e8-20020a258908000000b00bd4e6d62b8emr1267863ybl.50.1686920425258; Fri, 16 Jun 2023 06:00:25 -0700 (PDT) MIME-Version: 1.0 References: <20230504233736.3766296-1-xiaolei.wang@windriver.com> In-Reply-To: <20230504233736.3766296-1-xiaolei.wang@windriver.com> From: Linus Walleij Date: Fri, 16 Jun 2023 15:00:14 +0200 Message-ID: Subject: Re: [v4][PATCH] pinctrl: freescale: Fix a memory out of bounds when num_configs is 1 To: Xiaolei Wang Cc: aisheng.dong@nxp.com, festevam@gmail.com, shawnguo@kernel.org, ping.bai@nxp.com, kernel@pengutronix.de, peng.fan@nxp.com, shenwei.wang@nxp.com, bartosz.golaszewski@linaro.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 5, 2023 at 1:38=E2=80=AFAM Xiaolei Wang wrote: > The config passed in by pad wakeup is 1, when num_configs is 1, > Configuration [1] should not be fetched, which will be detected > by KASAN as a memory out of bounds condition. Modify to get > configs[1] when num_configs is 2. > > Fixes: f60c9eac54af ("gpio: mxc: enable pad wakeup on i.MX8x platforms") > Signed-off-by: Xiaolei Wang > --- > Changes since v3: > - update commit log, delete call trace Patch applied. Right now I have applied it for the merge window for kernel v6.5, tell me if it is really urgent and should rather go in for fixes. Yours, Linus Walleij