Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Fri, 16 Jun 2023 06:39:19 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Julien Panis <jpanis@baylibre.com>
Cc:     lee@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, corbet@lwn.net, arnd@arndb.de,
        gregkh@linuxfoundation.org, derek.kiernan@xilinx.com,
        dragan.cvetic@xilinx.com, yi.l.liu@intel.com, jgg@ziepe.ca,
        razor@blackwall.org, stephen@networkplumber.org,
        prabhakar.csengg@gmail.com, contact@emersion.fr, macro@orcam.me.uk,
        dsahern@kernel.org, alex.williamson@redhat.com,
        akrowiak@linux.ibm.com, mark.rutland@arm.com,
        ye.xingchen@zte.com.cn, ojeda@kernel.org, keescook@chromium.org,
        me@kloenk.de, mhiramat@kernel.org, milan@mdaverde.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, sterzik@ti.com, u-kumar1@ti.com,
        eblanc@baylibre.com, jneanne@baylibre.com
Subject: Re: [PATCH v6 6/6] samples: Add userspace example for TI TPS6594 PFSM
Message-ID: <613d608c-8c11-497c-81ef-e061d7ab69ab@roeck-us.net>
References: <20230406075622.8990-1-jpanis@baylibre.com>
 <20230406075622.8990-7-jpanis@baylibre.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230406075622.8990-7-jpanis@baylibre.com>
Precedence: bulk

On Thu, Apr 06, 2023 at 09:56:22AM +0200, Julien Panis wrote:
> This patch adds an example showing how to use PFSM devices
> from a userspace application. The PMIC is armed to be triggered
> by a RTC alarm to execute state transition.
> 
> Signed-off-by: Julien Panis <jpanis@baylibre.com>
> ---
>  samples/Kconfig            |   6 ++
>  samples/Makefile           |   1 +
>  samples/pfsm/.gitignore    |   2 +
>  samples/pfsm/Makefile      |   4 ++
>  samples/pfsm/pfsm-wakeup.c | 125 +++++++++++++++++++++++++++++++++++++
>  5 files changed, 138 insertions(+)
>  create mode 100644 samples/pfsm/.gitignore
>  create mode 100644 samples/pfsm/Makefile
>  create mode 100644 samples/pfsm/pfsm-wakeup.c
> 
> diff --git a/samples/Kconfig b/samples/Kconfig
> index 30ef8bd48ba3..f23aa60a74cf 100644
> --- a/samples/Kconfig
> +++ b/samples/Kconfig
> @@ -253,6 +253,12 @@ config SAMPLE_INTEL_MEI
>  	help
>  	  Build a sample program to work with mei device.
>  
> +config SAMPLE_TPS6594_PFSM
> +	bool "Build example program working with TPS6594 PFSM driver"
> +	depends on HEADERS_INSTALL

This also needs to depend on CC_CAN_LINK to avoid errors such as

Building arm:allmodconfig ... failed
--------------
Error log:
samples/pfsm/pfsm-wakeup.c:12:10: fatal error: fcntl.h: No such file or directory
   12 | #include <fcntl.h>

seen when building images with kernel toolchains.

Guenter