Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5139b72e-cccb-43b3-ba37-35f0011e4a2b@solid-run.com>
Date:   Fri, 16 Jun 2023 16:32:01 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH 2/3] dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog
 Board
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Cc:     Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Li Yang <leoyang.li@nxp.com>, Marek Vasut <marex@denx.de>,
        Fabio Estevam <festevam@denx.de>,
        Stefan Wahren <stefan.wahren@chargebyte.com>,
        Frieder Schrempf <frieder.schrempf@kontron.de>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Andreas Kemnade <andreas@kemnade.info>
References: <20230616110610.32173-1-josua@solid-run.com>
 <20230616110610.32173-3-josua@solid-run.com>
 <a9098664-ac16-eddb-3e2d-78eb08ac973f@linaro.org>
From:   Josua Mayer <josua@solid-run.com>
In-Reply-To: <a9098664-ac16-eddb-3e2d-78eb08ac973f@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cDgxZFJjUElWM3A4U3BHeUkzVnZheUtmcUJ2Zk55c2VXZnptNW9oRm55M2kz?=
 =?utf-8?B?YjhxWEU1UmR4ajluSWJxYUpTWmlhY2szaHkyUVJoa2FtdGkwQThFT3ZDT09a?=
 =?utf-8?B?MTAvcEx2cm1yM0Y1MmlNSDc2d3dnbEttcGovMG1hSTVUNGVkMWpqRFF6eU0z?=
 =?utf-8?B?U2dIUmtWMDdHS0pnMFJwUXpRQ2JlUDEyTVhWRm02WFdmNnRPMnZVOGFkdUgw?=
 =?utf-8?B?bnZMUDVxeUlDaW9OdjRxWnFYalhKby8yRk9RZElVWXNlM0tNYmpETlhhSFFu?=
 =?utf-8?B?VnIrcFhTeDhmSGREYWxVR0pCVWNEaEZVZ3g2K0o3QmFzTldNaDlVSzhGOThG?=
 =?utf-8?B?cVZsQ0pRU1docUxSV1I1TzQwYWpkaVgvVWhiWjhtNHRwOHhING9BVGtZYS84?=
 =?utf-8?B?ekJRV0NnNVA4RlYybWNxNHk2M2NaRTVaeFBMdFdjME9XdUFjMkJORVZWVmkz?=
 =?utf-8?B?TE53OHJ2ekw1eW5wZmFSTmR6NGtRZWZrSElZNXBFR29OLysvd1FLWjZWKzM3?=
 =?utf-8?B?VXdYT0dVRWZkb1piZTlubkE2Y1RHdHFySk1KZm9lWWRmYlZBdDRiRXlYdUJk?=
 =?utf-8?B?R0dsenN1M0V0Q1VRZFpyZ2FUYWFET3B3Tzk5T0lROEllbGpBK05jSU1hb2pO?=
 =?utf-8?B?RzBRYlZ3WllpZnAzSmhPdXNKSTNsY1FLZm41cVFzakdxODVzaDlmWWxPdG1h?=
 =?utf-8?B?dkU2c3J6ald1STRIUWRyaTRpQUtkZFYwZGUvTjV5U1JUajA3NmgxeWJtRUtz?=
 =?utf-8?B?OXQ5WWd4aERXVWpvM25mRmU1VXRPUndUcXZrNnEvM0g2SnFOVUhPQUNMRlhS?=
 =?utf-8?B?RkhoT3RNVFpxcGRBRGJRL2pQNzdZOUZZSjdHdDlPZEgzQm9EOUVBODlxa3p4?=
 =?utf-8?B?THdObUlyWm0rOSt1aW81YVlKcFJXMy95b212S2pPOU5YSkQzdzU2dWMzVHhh?=
 =?utf-8?B?ckxENElIOCtCZXMxZW1XU1R0cm9mVDNlNjA4b3Bqbzl5TzR3QUxUVm5DcWxV?=
 =?utf-8?B?dEJnOCtRVktXbmVpT3AzdTRCemVMRW9EQnB5NXZaWWR1VURjTCsxb0FZdGJR?=
 =?utf-8?B?U1E3L0JFTlBlazZESkQvN0w2eHNhZkplSFdITEozVFpjc3NjRW5kdjhCL2NY?=
 =?utf-8?B?YnRRZXB4cUNFcVhFQk1hc3kyVTVGQlBGQ3hCWngrc1RUU2FWQXFjajRwOTJy?=
 =?utf-8?B?VUdtRWhUSU84NXRocDFiUElILzRLeU9NVVkxcElFRTRkYndHdkZ6b0VPTHZW?=
 =?utf-8?B?ckZXRzlhTlJ6a05jK0FUdnYxeXN0R3RDZERzYkpPWkFsSnVpbkxzSFZrMEFB?=
 =?utf-8?B?NThpZjBuOHpzYzB0dFRtTXVjKzNJU3J0dmhMeXBHK1VGSkpFS1pMSDRYZTd4?=
 =?utf-8?B?YjgxN3lFL1hIU1ErbjVLV1BwMG9VVlZVVEFQVzlhVEdpSXY5ZkNwMGRyc0o5?=
 =?utf-8?B?Uy9WQmtETVJwUWJpOXl6RjF3VTFobmV3dHRMTUdYZUNNOUJXRjFaT3daWHNF?=
 =?utf-8?B?cGxGMnMrL1grU24xbGYwWjZ0dGNjRXNCdFdSMnRzTHVVV09vbHFCV1l5QU5W?=
 =?utf-8?B?aWIvcmU0SVFOeGEwSlFaODJtd3drQ1k3djdOdzdjRDRBbzNHYnRxWlN5ZUM4?=
 =?utf-8?B?VGtpc29jWG9nQ0oxTWV6NTBvSnBleEJpQ1Y0VWFzZW5YZVNJUktGemY3ZGZQ?=
 =?utf-8?B?dDhqSU85L2JVQmxGdDVCZVEzN1NzS2k2U0k3OEVRQWtxZ1F4UVNGVlAzb3ZX?=
 =?utf-8?B?SkRGT1I0b2NQbngyTGJZZllMRTBHTTVSUDM0b1lrZFU1WXB2TVkyTGZPa0FQ?=
 =?utf-8?B?ZFZodmVpR2pBVVZTelc0OVhhcDJ6aUZYaWFYRUxtTXVZdVlKdTFDUWpoYko0?=
 =?utf-8?B?d2I4NG9YOG85NHJ6MC9xNE9NSEwzcW45enFRVGh3Z0FJVWZWZUVSNm1mWHlh?=
 =?utf-8?B?ai9SRWZCK09iWlhDNks4VEJtbzRqOHo3dXVCSkU0TG5CQXE3cGFSaHAvRjBs?=
 =?utf-8?B?QnE5VGw4SWxpMXRVUWVDVWxtM3ViSWpZNVBnVkg4SXlGRWNNR3hReksyNDFx?=
 =?utf-8?B?VXN3WTJwUlhxWmZWQU51ZE5YM0tOVktNbC9DNk15KzZYTStjbHBBb09FQVRW?=
 =?utf-8?Q?lJ1GjRlNrLPpHp97MOhbRWkPX?=
X-OriginatorOrg: solid-run.com
X-MS-Exchange-CrossTenant-Network-Message-Id: acbaa567-7786-4868-7210-08db6e6e1462
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8963.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 13:32:07.2958
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a4a8aaf3-fd27-4e27-add2-604707ce5b82
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O21qSd2Vn6WZyi1iCDpTEidfYEMi5w/iLO4Cvn7N8fZwfGtkrbi8UuaFPtJJSOBb0GFFYcfjj/bFqb43jntJKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6840
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

HI Krzysztof,

Am 16.06.23 um 14:36 schrieb Krzysztof Kozlowski:
> On 16/06/2023 13:06, Josua Mayer wrote:
>> Add DT compatible for SolidRun LX2162A SoM and Clearfog board.
>>
>> Signed-off-by: Josua Mayer <josua@solid-run.com>
>> ---
>>   Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>> index 15d411084065..438a4ece8157 100644
>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>> @@ -1373,9 +1373,11 @@ properties:
>>         - description: SolidRun LX2160A based Boards
>>           items:
>>             - enum:
>> +              - solidrun,clearfog
>>                 - solidrun,clearfog-cx
>>                 - solidrun,honeycomb
>>             - const: solidrun,lx2160a-cex7
>> +          - const: solidrun,lx2162a-som
>>             - const: fsl,lx2160a
> You change existing entries, breaking boards and changing the meaning,
> without any explanation in commit msg. That's not how it is done. Please
> provide rationale in commit msg.

I'm sorry. Given your comment I think I did not understand how these 
entries are supposed to work.
So perhaps you can provide some guidance based on my explanation?:

- NXP LX2162 is a smaller physical package of the same LX2160 SoC, with 
reduced IOs and some silicon blocks disabled.
- SolidRun LX2162 SoM is essentially a different form factor of LX2160 CEX
- SolidRun LX2162 Clearfog is the reference platform for the SoM. 
Despite it's naming similarity to clearfog-cx, it has a different 
feature set more similar to SolidRun Armada 388 Clearfog Pro

So I believed I could just add to the existing entry "SolidRun LX2160A 
based Boards" also the new LX2162 Board & SoM.
I see now that adding a fourth const messes upthe existing 3-part 
compatible for those already existing boards.

Please can you confirm if it would have been more correct to replace 
"const: solidrun,lx2160a-cex7" with an enum?:
enum:
   - solidrun,lx2160a-cex7
   - solidrun,lx2162a-som

Finally, is it okay to add a "solidrun,clearfog" given my explanation 
above, or should it be more specific "solidrun,lx2162a-clearfog"?

> Best regards,
> Krzysztof
Sincerely
Josua Mayer