Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 17:13:39 +0300
From:   Andy Shevchenko <andy@kernel.org>
To:     Michael Walle <mwalle@kernel.org>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jiawen Wu <jiawenwu@trustnetic.com>
Subject: Re: [PATCH] gpiolib: Fix irq_domain resource tracking for
 gpiochip_irqchip_add_domain()
Message-ID: <ZIxuExRypHsUejFI@smile.fi.intel.com>
References: <20230616-fixes-gpiolib-irq-domain-v1-1-27fe870db961@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230616-fixes-gpiolib-irq-domain-v1-1-27fe870db961@kernel.org>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Fri, Jun 16, 2023 at 09:30:06AM +0200, Michael Walle wrote:
> Up until commit 6a45b0e2589f ("gpiolib: Introduce
> gpiochip_irqchip_add_domain()") all irq_domains were allocated
> by gpiolib itself and thus gpiolib also takes care of freeing it.
> 
> With gpiochip_irqchip_add_domain() a user of gpiolib can associate an
> irq_domain with the gpio_chip. This irq_domain is not managed by
> gpiolib and therefore must not be freed by gpiolib.

With or without below nit-pick
Reviewed-by: Andy Shevchenko <andy@kernel.org>

...

>  	/* Remove all IRQ mappings and delete the domain */
> -	if (gc->irq.domain) {
> +	if (!gc->irq.domain_is_ext && gc->irq.domain) {

Looking at this, perhaps positive about allocation?

	domain_is_allocated?

-- 
With Best Regards,
Andy Shevchenko