Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933724AbXJQUcA (ORCPT ); Wed, 17 Oct 2007 16:32:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933357AbXJQUbs (ORCPT ); Wed, 17 Oct 2007 16:31:48 -0400 Received: from brick.kernel.dk ([87.55.233.238]:20375 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760919AbXJQUbq (ORCPT ); Wed, 17 Oct 2007 16:31:46 -0400 Date: Wed, 17 Oct 2007 22:31:41 +0200 From: Jens Axboe To: Linus Torvalds Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Jeff Garzik , Alan Cox Subject: Re: [bug] ata subsystem related crash with latest -git Message-ID: <20071017203140.GF15552@kernel.dk> References: <20071017174503.GA4622@elte.hu> <20071017175337.GN15552@kernel.dk> <20071017183716.GU15552@kernel.dk> <20071017190901.GA13780@elte.hu> <20071017193542.GA15552@kernel.dk> <20071017195659.GD15552@kernel.dk> <20071017200638.GE15552@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1025 Lines: 27 On Wed, Oct 17 2007, Linus Torvalds wrote: > > > On Wed, 17 Oct 2007, Jens Axboe wrote: > > > > So until that is fixed up, how about this? Should cover all block > > devices, and I don't think sg_next()/for_each_sg() has spread outside of > > that yet. > > Heh. Not good. There are drivers that set max phys segmsnts to 1. Either > through some host-specific setting (MMC), or explicitly (eg a grep shows > viodasd uses just a constant 1 there). That would hurt... Care to commit your for_each_sg() uglification fixup for now then? Or disable the allocation debug config entry, so that the sg+1 deref wont crash? Whichever your prefer, just don't want to cause crash pains for the unfortunate souls that happen to run into this before the real fix is done. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/