Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 07:13:08 -0700
From:   Ashok Raj <ashok.raj@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>
CC:     LKML <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        Mario Limonciello <mario.limonciello@amd.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "Tony Battersby" <tonyb@cybernetics.com>,
        Ashok Raj <ashok.raj@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Arjan van de Veen <arjan@linux.intel.com>,
        Eric Biederman <ebiederm@xmission.com>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [patch v3 1/7] x86/smp: Make stop_other_cpus() more robust
Message-ID: <ZIxt9Er5nJRjCUXh@a4bf019067fa.jf.intel.com>
References: <20230615190036.898273129@linutronix.de>
 <20230615193330.263684884@linutronix.de>
 <ZIvByEFqiJZOyau2@a4bf019067fa.jf.intel.com>
 <87mt0z7si2.ffs@tglx>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <87mt0z7si2.ffs@tglx>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EWgB9Nj0iWNrr5GoInyvZUL0MSk9ddnAFxN2P+SxGkfZKYLd/Oa7JGT7rHQI?=
 =?us-ascii?Q?UF2+aBKdZkxOagogkeup5AyNBSojxZQzSkALIz7W4dk+yJwLzEzyyS3A/Jv7?=
 =?us-ascii?Q?kFiDJIvrjRJvlgUBtUnDMvQ7e45mND9/4kjkEW+Scnc/Oy9KUgD+RjbRslw5?=
 =?us-ascii?Q?3w8M0J4C9DMzmJuRawYWSnqFkCm76ZJRCPSIIBw7w8cY1HOFLSlUkQVwC584?=
 =?us-ascii?Q?zW9Dos0B8qUZdby4XHLPdi5eqmgnlwlPyuOxuNn3ZsCwxLlpzDTpq09ODy7z?=
 =?us-ascii?Q?xi/sdpADtLm75NQSI3mFDMed2ki4oIJ7VvIk+fSXdZIekmJRFZNd6wGspVnm?=
 =?us-ascii?Q?2WRVaV55bzskwKjpLXVLW1Jk1QHLjIaobB6JAAzfOQIoPmSamJnNmckr88C8?=
 =?us-ascii?Q?iRlOnmvcaMT6MQz2igcnfVMNglnYn2Gu5jZsT1viJRqDqhPcXBn4QrVC04td?=
 =?us-ascii?Q?7ESVs5h/DhbIDJW9Gx3yW3cRSyaVRNPwMOVie7tb61FKdlAm1RwJOWwRKic4?=
 =?us-ascii?Q?uwHSUBuJqSbOVJOfMZ2upZ4vfDBxR3VP4M3XdDKPs0niGPpDpfLzpXlrIpB2?=
 =?us-ascii?Q?jsp3etz8zRo1P8Yaokj19DTNVzjj5RGNSV8XKgBilkX8wRbW1ZzEvE0elE7M?=
 =?us-ascii?Q?p4AsUh/MydkOtc7lZJb6O/CSGddluarOqY38EtM6IKWnT7S/Y4OnZ49/a86z?=
 =?us-ascii?Q?ORBibPM91UEhtFhHD7nJ2Qw7PpZN4a0oTbi2RX7oWKKXEG8WrkZ/QJGo5PnD?=
 =?us-ascii?Q?yBK/8wbgv/gpzvJ+SR6NEOkZj/7DQ1z6uKpIWQIXu9LWlqUF8tarN+Iid7Ut?=
 =?us-ascii?Q?80TAwwGbXEmnJ4lQlTy8FKBBivJxYCZ+Xpw2UGbZucnIy66bKuqQTtocKbXZ?=
 =?us-ascii?Q?HbOZ4YhEkwjWDLHri/EH/6HD8PQoCon/KWcwg6cj9sjE42/awI8RCLeRLYQo?=
 =?us-ascii?Q?dFgM3WdVl5mSXi6tXVo37sE8Gi3yC9EZWZqDTSXe5SsCwHmMsw9I07q5wSWJ?=
 =?us-ascii?Q?rlD2XfLYQHPODPaiMb+IOE4rIoEE0p5P0MaJfxHZokZdRN71y7B5kskmdtti?=
 =?us-ascii?Q?lPnhaKHIno+FN7gqr7Cit9ngfFmuUqPIFd4OdrHANhSmuasKLDah3Sfdr+PW?=
 =?us-ascii?Q?oa7f2f1TRhPqoorCY7jkweGgds1T0u3rxCQ/P+7EtqoV51i3AY9cYjsKJQlz?=
 =?us-ascii?Q?gTRIpA+P/vClE/kUghFWsgmo8NWLrvJ3k+63Z9YfaNEQ/AH/BJ9AuT6/Hmbj?=
 =?us-ascii?Q?3++S9zokQBh4dSo2Ns6OV8JEtZHHedSMxPHz2BVev+1Qkj4EBxnzGIwcU39m?=
 =?us-ascii?Q?Ghlw3FI09S5RAmkbicmB7pe+o028BcBNymuo6xNET2rZEqeUF7Y6cD4lPPg0?=
 =?us-ascii?Q?EW14yLifcFSUb1rUBr4NbKHn6sqXbPRpl5TjKbhALW98GY2QiDLYjIUojx9J?=
 =?us-ascii?Q?iNUYJy6u/m/QZLELasTS1n0v3rhj8Dc81t9nZacK3JTFFLmltnshljNjEy4J?=
 =?us-ascii?Q?3GxdW5IBcFqsKLk4mPS4gXXbpaGJP2aD/zRskQ/O+rssDaD8QLx+r96cgL9c?=
 =?us-ascii?Q?x7Khko0Vi0Q+BeSk1WAaOoK9dJOebOHiGhZDKIVukYdcYgUATOccLv/L59Gy?=
 =?us-ascii?Q?TQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fd98ee7b-3d56-4e06-2248-08db6e73d2db
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 14:13:14.2751
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vgPFMjlhFtq93F4e6Z7qftEqcDsBeOuoPfhECng3zz6OBaF0CHI0BV3weX+1w6eFAUoT0uP5fYrtYK4hTP2wSA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4684
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 16, 2023 at 09:53:25AM +0200, Thomas Gleixner wrote:
> On Thu, Jun 15 2023 at 18:58, Ashok Raj wrote:
> > On Thu, Jun 15, 2023 at 10:33:50PM +0200, Thomas Gleixner wrote:
> >> +			dm = apic->dest_mode_logical ? APIC_DEST_LOGICAL : APIC_DEST_PHYSICAL;
> >> +			dm |= APIC_DM_NMI;
> >> +
> >> +			for_each_cpu(cpu, &cpus_stop_mask) {
> >> +				u32 apicid = apic->cpu_present_to_apicid(cpu);
> >> +
> >> +				apic_icr_write(dm, apicid);
> >> +				apic_wait_icr_idle();
> >
> > can we simplify this by just apic->send_IPI(cpu, NMI_VECTOR); ??
> 
> That would not set APIC_DM_NMI in delivery mode and the IPI would be
> sent with APIC_DM_FIXED.

That's correct. 

Maybe if we use apic->send_IPI_mask(cpumask_of(cpu), NMI_VECTOR)

apic->send_IPI_mask(cpumask_of(cpu),NMI_VECTOR)
   __x2apic_send_IPI_mask() 
      __x2apic_send_IPI_dest()
	  unsigned long cfg = __prepare_ICR(0, vector, dest);
	  native_x2apic_icr_write(cfg, apicid);

__prepare_ICR() seems to have the magic for APIC_DM_NMI?

I suppose this works for non-x2apic parts as well

Cheers,
Ashok