Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 17:17:28 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc:     linux-media@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
        Luca Ceresoli <luca.ceresoli@bootlin.com>,
        Matti Vaittinen <Matti.Vaittinen@fi.rohmeurope.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Wolfram Sang <wsa@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Peter Rosin <peda@axentia.se>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Michael Tretter <m.tretter@pengutronix.de>,
        Hans Verkuil <hverkuil@xs4all.nl>,
        Mike Pagano <mpagano@gentoo.org>,
        Krzysztof =?utf-8?Q?Ha=C5=82asa?= <khalasa@piap.pl>,
        Marek Vasut <marex@denx.de>,
        Satish Nagireddy <satish.nagireddy@getcruise.com>
Subject: Re: [PATCH v14 11/18] media: i2c: ds90ub9xx: Select GPIOLIB rather
 than OF_GPIO
Message-ID: <ZIxu+IvTSaFW3erU@smile.fi.intel.com>
References: <20230616135922.442979-1-tomi.valkeinen@ideasonboard.com>
 <20230616135922.442979-12-tomi.valkeinen@ideasonboard.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230616135922.442979-12-tomi.valkeinen@ideasonboard.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Fri, Jun 16, 2023 at 04:59:15PM +0300, Tomi Valkeinen wrote:
> Select GPIOLIB rather than OF_GPIO, as the drivers use gpiolib
> functionality, but no of_gpio (directly).

This is useful change, but has to be folded in the original code.
We do not want even a trace of newly added OF_GPIO.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> ---
>  drivers/media/i2c/Kconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index 8a5f09a3de6c..29fc00e30d8b 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -1622,7 +1622,7 @@ config VIDEO_DS90UB913
>  	depends on OF && I2C && VIDEO_DEV && COMMON_CLK
>  	select I2C_ATR
>  	select MEDIA_CONTROLLER
> -	select OF_GPIO
> +	select GPIOLIB
>  	select REGMAP_I2C
>  	select V4L2_FWNODE
>  	select VIDEO_V4L2_SUBDEV_API
> @@ -1635,7 +1635,7 @@ config VIDEO_DS90UB953
>  	depends on OF && I2C && VIDEO_DEV && COMMON_CLK
>  	select I2C_ATR
>  	select MEDIA_CONTROLLER
> -	select OF_GPIO
> +	select GPIOLIB
>  	select REGMAP_I2C
>  	select V4L2_FWNODE
>  	select VIDEO_V4L2_SUBDEV_API
> @@ -1648,7 +1648,7 @@ config VIDEO_DS90UB960
>  	depends on OF && I2C && VIDEO_DEV && COMMON_CLK
>  	select I2C_ATR
>  	select MEDIA_CONTROLLER
> -	select OF_GPIO
> +	select GPIOLIB
>  	select REGMAP_I2C
>  	select V4L2_FWNODE
>  	select VIDEO_V4L2_SUBDEV_API
> -- 
> 2.34.1
> 

-- 
With Best Regards,
Andy Shevchenko