Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 16:50:28 +0200
From:   Samuel Thibault <samuel.thibault@ens-lyon.org>
To:     Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc:     William Hubbs <w.d.hubbs@gmail.com>,
        Chris Brannon <chris@the-brannons.com>,
        Kirk Reiser <kirk@reisers.ca>, kernel@collabora.com,
        kernel-janitors@vger.kernel.org, speakup@linux-speakup.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] accessibility: speakup: remove linux/version.h
Message-ID: <20230616145028.7rzrbqfj7wmoenj6@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Muhammad Usama Anjum <usama.anjum@collabora.com>,
        William Hubbs <w.d.hubbs@gmail.com>,
        Chris Brannon <chris@the-brannons.com>,
        Kirk Reiser <kirk@reisers.ca>, kernel@collabora.com,
        kernel-janitors@vger.kernel.org, speakup@linux-speakup.org,
        linux-kernel@vger.kernel.org
References: <20230303125152.2030241-1-usama.anjum@collabora.com>
 <fb6121fc-101f-0779-b752-ac8202eb761e@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <fb6121fc-101f-0779-b752-ac8202eb761e@collabora.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
Precedence: bulk

Muhammad Usama Anjum, le ven. 16 juin 2023 17:53:12 +0500, a ecrit:
> Soft reminder.

It somehow hadn't appeared in my inbox.

> On 3/3/23 5:51 PM, Muhammad Usama Anjum wrote:
> > make versioncheck reports the following:
> > ./drivers/accessibility/speakup/genmap.c: 13 linux/version.h not needed.
> > ./drivers/accessibility/speakup/makemapdata.c: 13 linux/version.h not needed.
> > 
> > So remove linux/version.h from both of these files.
> > 
> > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Thanks!

> > ---
> >  drivers/accessibility/speakup/genmap.c      | 1 -
> >  drivers/accessibility/speakup/makemapdata.c | 1 -
> >  2 files changed, 2 deletions(-)
> > 
> > diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
> > index 0125000e00d9..0882bab10fb8 100644
> > --- a/drivers/accessibility/speakup/genmap.c
> > +++ b/drivers/accessibility/speakup/genmap.c
> > @@ -10,7 +10,6 @@
> >  #include <stdio.h>
> >  #include <libgen.h>
> >  #include <string.h>
> > -#include <linux/version.h>
> >  #include <ctype.h>
> >  #include "utils.h"
> >  
> > diff --git a/drivers/accessibility/speakup/makemapdata.c b/drivers/accessibility/speakup/makemapdata.c
> > index d7d41bb9b05f..55e4ef8a93dc 100644
> > --- a/drivers/accessibility/speakup/makemapdata.c
> > +++ b/drivers/accessibility/speakup/makemapdata.c
> > @@ -10,7 +10,6 @@
> >  #include <stdio.h>
> >  #include <libgen.h>
> >  #include <string.h>
> > -#include <linux/version.h>
> >  #include <ctype.h>
> >  #include "utils.h"
> >  
> 
> -- 
> BR,
> Muhammad Usama Anjum
> 

-- 
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.