Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 15:59:06 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Martin Fuzzey <martin.fuzzey@flowbird.group>
Cc:     Support Opensource <support.opensource@diasemi.com>,
        Benjamin Bara <benjamin.bara@skidata.com>,
        Adam Ward <DLG-Adam.Ward.opensource@dm.renesas.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: da9063: fix null pointer deref with partial
 DT config
Message-ID: <49ba8434-f16e-415a-9059-1af532854cb0@sirena.org.uk>
References: <20230616143736.2946173-1-martin.fuzzey@flowbird.group>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="G7fWAiFF1Z1ENwIb"
Content-Disposition: inline
In-Reply-To: <20230616143736.2946173-1-martin.fuzzey@flowbird.group>
Precedence: bulk


--G7fWAiFF1Z1ENwIb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 16, 2023 at 04:36:28PM +0200, Martin Fuzzey wrote:

>  	const struct notification_limit *uv_l =3D &constr->under_voltage_limits;
>  	const struct notification_limit *ov_l =3D &constr->over_voltage_limits;
> =20
> +	if (!config->init_data) /* No config in DT, pointers will be invalid */
> +		return 0;
> +

We already dereferenced above when we were initialising the variables,
the compiler might still generate dereferences before it does the checks
here.

>  	/* make sure that only one severity is used to clarify if unchanged, en=
abled or disabled */
>  	if ((!!uv_l->prot + !!uv_l->err + !!uv_l->warn) > 1) {
>  		dev_err(config->dev, "%s: at most one voltage monitoring severity allo=
wed!\n",
> --=20
> 2.25.1
>=20

--G7fWAiFF1Z1ENwIb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSMeLkACgkQJNaLcl1U
h9ARsAf/WXcWbB5wGqNklpDm3RFefRMp0Gw0WHwRklLY2iZf8u2D7MEevfYB6rVu
g2fG5MPw8Bz1EyABS4NmVLBbqd/7spjvuSvSgfCCAjeHiCtE8OjuylZJdl/ZN/Du
3otyM9JhTO2sBIkFW7OEfCZ2vDiPUP5zUrcrgFu/1Gh8pB3Hz9KQqnA09anoBewW
8KseAkv+yM6t2YquHD2Q0ymAFznlf799VtKTMRJ6RUQdVdxUYh2tKu3NEyaAGa+R
Jbv3uYYP8vL5z0+w7uGJokBNODaTs7seg0OYdEZGGXo658VG1qF+IKAHYIIzEyfg
vTbiL2xiv9MRmuwgcp0rnihyO+hgcQ==
=XvwL
-----END PGP SIGNATURE-----

--G7fWAiFF1Z1ENwIb--