Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 08:07:48 -0700
From:   Ashok Raj <ashok.raj@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     Ashok Raj <ashok_raj@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        Ashok Raj <ashok.raj@linux.intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>,
        "Arjan van de Veen" <arjan@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        "Eric Biederman" <ebiederm@xmission.com>,
        Ashok Raj <ashok.raj@intel.com>,
        "Dhanraj, Vijay" <vijay.dhanraj@intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Laszlo Ersek <lersek@redhat.com>,
        Gerd Hoffmann <kraxel@redhat.com>,
        Andrea Bolognani <abologna@redhat.com>,
        Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= <berrange@redhat.com>
Subject: Re: [patch 0/6] Cure kexec() vs. mwait_play_dead() troubles
Message-ID: <ZIx6xCgdILbjcw7H@a4bf019067fa.jf.intel.com>
References: <20230603193439.502645149@linutronix.de>
 <ZH4eNL4Bf7yPItee@google.com>
 <87pm694jmg.ffs@tglx>
 <ZICuhZHCqSYvR4IO@araj-dh-work>
 <ZIC/b+AwvH2wIz/o@google.com>
 <ZIECZMHxtEYnuBAJ@araj-dh-work>
 <ZIFPDvsKGZ7MVSMt@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZIFPDvsKGZ7MVSMt@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DN4/pxxTA7YFubAyu8eJTerMWrxxh1oVldjT1pRkw1ux6JJFCYaJXSAqEoum?=
 =?us-ascii?Q?z9FXicQfZ7/5opX1jQAQHzji0RJ8HuOKjJEA5HEX31aR5DLq//GitXO9hxpP?=
 =?us-ascii?Q?saBBdqS2wPv3k5u8Z5Fx2JiQMilAS1ShplqU2CEpIFgATrKFqGVWCo+bh07x?=
 =?us-ascii?Q?ajXGsC1WK+QxBe0WSSplVGU+TLblUtsDqEsidTzyNfwqOMCiEMvD7y+e1K9H?=
 =?us-ascii?Q?NUWs1jBzVdCgcMw0uzrYKagcpID5bWI2iR225C7N2I1J+K+E5xXb8Lz17xMi?=
 =?us-ascii?Q?Mdha5ZfI1YgZQORTEcJWATvGnC59lK1UeCJceev/g39HvK0FOzTtyW9G0m+W?=
 =?us-ascii?Q?2PjSr0He+6NO7yfXgKOKYfi5OrT6KMbYz7M+/qOuZSP0akklatGJBm+e2Cc4?=
 =?us-ascii?Q?mVN3EWA0ci9v1RV4UcN3m7UKYRZMC/34O5mg2SCtFOkI9aCzWouruJOFyEYc?=
 =?us-ascii?Q?P2oZxBihuXIxMr27I39DJECU9nLchDDpo9NrulBbGGzBQD5X2nIc+0cH8EYq?=
 =?us-ascii?Q?QLlayzWeSLi0d+ZvWv5Gtqo1U6CgUC9ccQMHaTg1vGPm9t+YUH699vwzyCVH?=
 =?us-ascii?Q?jq1aOlJRFqY0GFoi67WxxcueW1SGOReWop/7ltMddjCU5ZvEYnzgMQqrF2AB?=
 =?us-ascii?Q?8dT2ENQus2/lfN1+7IqKZm8cD5czDA1HhcLlXGUSLia0O4NaTA8x8iHlUXYe?=
 =?us-ascii?Q?4/trKJNDlnsiYPDvyq3C6KWYGp1mKqQw3QY/yD2pn64GKDSBO3KsJDhJuean?=
 =?us-ascii?Q?PaRKMhJErj/Af3UZoCK5OM7MzZazchJzqh5MGAbhbmBImXkp8bg9jje6ShTY?=
 =?us-ascii?Q?1Y0ZBSznLvj+Kgbva0KFls8FyCkeWW4qNoAqpRZRgG+pJsiEgNaXHwTd/1qi?=
 =?us-ascii?Q?4M2yoBvsOzmgy9NVqaPEd0muTu4Tun6jHo1Ft/mO8aLDo4SKbKDloFkDSB0X?=
 =?us-ascii?Q?7RsxLBuXXPjKRUQEmu3gCyarPif66Nxexyi7rK/Alblgd0jDgpxOjGfC/kzO?=
 =?us-ascii?Q?zUZyRNsGxXQit+Sn7s7imPp0cSyqVMICYdBpv2dUP2pcAgB38OEC5ZvZ7dko?=
 =?us-ascii?Q?6fVEM5JDwP6r6W029k+eedteOPMx66zyBXwVtLM1hjrNgQKadfCzRkPPLFBI?=
 =?us-ascii?Q?FS6WmgauMv06VnxfbiN96uHnAxyaEhckJaDWZLYzNCabBQHqLoJ0BeOgj+Bt?=
 =?us-ascii?Q?+uGzhI7y4CGKspwq5tZlOaehB/nMMetbBnsEEj390QFkEmxHgEAoZ8rnUiUR?=
 =?us-ascii?Q?rlFPiUogxbtDp0z+eEsoOC4JXFmQ88bR0vGmCT6lVHdbDf7yLAQkkqdoZTQN?=
 =?us-ascii?Q?Nw0gSO56JJ5enquYrfCsZnBswNCRcCIexKh9VqayU3YVBvgPX600AJTuFLZu?=
 =?us-ascii?Q?wJwpRar9k1dHqc2Ng/2y1O5L9l/K3BAR9dL/Db4D2CVXe9ow6SrWREC06cBR?=
 =?us-ascii?Q?mDdVxF8Gpt1blO1pgyMwnz2UWRSwJa25bsH/0MlBbkkwNGSK96UkKaKy3kHT?=
 =?us-ascii?Q?1ZeGm9h7NTZtiGTvFlZAt0idEM9BOO2eWKGyXbQq+JicLfvLSFEaJ/y+EyEr?=
 =?us-ascii?Q?7m2HF0sn5/LwCgcd4WagGOldeMNvdgtcqrjWl7oT+t0rCB6OK70Ih0ieiIvC?=
 =?us-ascii?Q?FA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c24f839-f049-4f47-ea0a-08db6e7b7616
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 15:07:54.6684
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UpPUon6LL9THR/ZP4Rb+TdD3rzYvCEaty3WtaBvBsyanA5KGqU8nzyXLwTylSkkiXuidy9mdIKIVM4RC2xWSYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4834
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 07, 2023 at 08:46:22PM -0700, Sean Christopherson wrote:
> 
> https://lore.kernel.org/all/BYAPR12MB301441A16CE6CFFE17147888A0A09@BYAPR12MB3014.namprd12.prod.outlook.com
> 
> > If there is a specific test you want done, let me know.
> 
> Smoke testing is all I was thinking.  I wouldn't put too much effort into trying
> to make sure this all works.  Like I said earlier, nice to have, but certainly not
> necessary.

+ Vijay who was helping with testing this inside the VM.
+ Paolo, Laszlo 

I haven't found the exact method to test with secure boot/trusted boot yet.
But here is what we were able to test thus far.

Vijay was able to get OVMF recompiled with SMM included.

Thanks to Laszlo for pointing me in the right direction. And Paolo for
helping with some basic questions.

https://github.com/tianocore/tianocore.github.io/wiki/Testing-SMM-with-QEMU,-KVM-and-libvirt

Surprisingly SMM emulation is sadly damn good :-) 

Recipe is to generate SMI by writing to port 0xb2. 

- On native, this does generate a broadcast SMI, the SMI_COUNT MSR 0x34
  goes up by 1 on all logical CPUs.
- Turn off SMT by #echo off > /sys/devices/system/cpu/smt/control
- Do another port 0xb2, we don't see any hangs
- Bring up SMT by echo on > control, and we can see even the offline CPUs
  got the SMI as indicated by MSR 0x34. (Which is as expected)

On guest, the only difference was when we turn on HT again, waking the CPUs
from INIT, SMI_COUNT has zeroed as opposed to the native. (Which is
perfectly fine) All I was looking for was "no hang". And a normal kexec
with newly updated code works well inside a guest.

Would this qualify for the smoke test pass? I'll continue to look for a
secure boot install if this doesn't close it, just haven't landed at the
right spot yet.

-- 
Cheers,
Ashok