Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230329090403.5274-1-clamor95@gmail.com> <20230329090403.5274-2-clamor95@gmail.com>
In-Reply-To: <20230329090403.5274-2-clamor95@gmail.com>
From:   Svyatoslav Ryhel <clamor95@gmail.com>
Date:   Fri, 16 Jun 2023 18:24:10 +0300
Message-ID: <CAPVz0n3XAonUH-d4hZ7JsWcgQd+fmq_WRPPajbOopq8E6y6TNQ@mail.gmail.com>
Subject: Re: [PATCH v3 1/4] ARM: tegra: transformer: use labels for mmc in aliases
To:     Thierry Reding <thierry.reding@gmail.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Dmitry Osipenko <digetx@gmail.com>,
        Svyatoslav Ryhel <clamor95@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Maxim Schwalm <maxim.schwalm@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

=D1=81=D1=80, 29 =D0=B1=D0=B5=D1=80. 2023=E2=80=AF=D1=80. =D0=BE 12:04 Svya=
toslav Ryhel <clamor95@gmail.com> =D0=BF=D0=B8=D1=88=D0=B5:
>
> Use phandle references for mmc instead of path in aliases.
>
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
>  arch/arm/boot/dts/tegra114-asus-tf701t.dts           | 12 ++++++------
>  .../boot/dts/tegra30-asus-transformer-common.dtsi    | 12 ++++++------
>  2 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra114-asus-tf701t.dts b/arch/arm/boot/d=
ts/tegra114-asus-tf701t.dts
> index 84a3eb38e71d..3a420ac969ff 100644
> --- a/arch/arm/boot/dts/tegra114-asus-tf701t.dts
> +++ b/arch/arm/boot/dts/tegra114-asus-tf701t.dts
> @@ -13,9 +13,9 @@ / {
>         chassis-type =3D "convertible";
>
>         aliases {
> -               mmc0 =3D "/mmc@78000600"; /* eMMC */
> -               mmc1 =3D "/mmc@78000400"; /* uSD slot */
> -               mmc2 =3D "/mmc@78000000"; /* WiFi */
> +               mmc0 =3D &sdmmc4; /* eMMC */
> +               mmc1 =3D &sdmmc3; /* uSD slot */
> +               mmc2 =3D &sdmmc1; /* WiFi */
>
>                 rtc0 =3D &palmas;
>                 rtc1 =3D "/rtc@7000e000";
> @@ -605,12 +605,12 @@ i2s@70080300 {
>                 };
>         };
>
> -       mmc@78000000 {
> +       sdmmc1: mmc@78000000 {
>                 /* WiFi */
>         };
>
>         /* MicroSD card */
> -       mmc@78000400 {
> +       sdmmc3: mmc@78000400 {
>                 status =3D "okay";
>
>                 bus-width =3D <4>;
> @@ -626,7 +626,7 @@ mmc@78000400 {
>                 pinctrl-0 =3D <&sdmmc3_default>;
>         };
>
> -       mmc@78000600 {
> +       sdmmc4: mmc@78000600 {
>                 /* eMMC */
>         };
>
> diff --git a/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi b/arc=
h/arm/boot/dts/tegra30-asus-transformer-common.dtsi
> index 1861b2de2dc3..f32806f07989 100644
> --- a/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
> +++ b/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
> @@ -12,9 +12,9 @@ / {
>         chassis-type =3D "convertible";
>
>         aliases {
> -               mmc0 =3D "/mmc@78000600"; /* eMMC */
> -               mmc1 =3D "/mmc@78000000"; /* uSD slot */
> -               mmc2 =3D "/mmc@78000400"; /* WiFi */
> +               mmc0 =3D &sdmmc4; /* eMMC */
> +               mmc1 =3D &sdmmc1; /* uSD slot */
> +               mmc2 =3D &sdmmc3; /* WiFi */
>
>                 rtc0 =3D &pmic;
>                 rtc1 =3D "/rtc@7000e000";
> @@ -1388,7 +1388,7 @@ i2s@70080600 {            /* i2s3 */
>                 };
>         };
>
> -       mmc@78000000 {
> +       sdmmc1: mmc@78000000 {
>                 status =3D "okay";
>
>                 /* FIXME: Full 208Mhz clock rate doesn't work reliably */
> @@ -1401,7 +1401,7 @@ mmc@78000000 {
>                 vqmmc-supply =3D <&vddio_usd>;    /* ldo3 */
>         };
>
> -       mmc@78000400 {
> +       sdmmc3: mmc@78000400 {
>                 status =3D "okay";
>
>                 #address-cells =3D <1>;
> @@ -1431,7 +1431,7 @@ wifi@1 {
>                 };
>         };
>
> -       mmc@78000600 {
> +       sdmmc4: mmc@78000600 {
>                 status =3D "okay";
>                 bus-width =3D <8>;
>                 vmmc-supply =3D <&vcore_emmc>;
> --
> 2.37.2
>

Hello Thierry!
For some reason this commit was not picked while all others in
the patchset were. May I know why and how to fix this?

Best regards,
Svyatoslav R.