Date: Wed, 17 Oct 2007 23:00:27 +0200
From: Jean Delvare <khali@linux-fr.org>
To: Jochen Friedrich <jochen@scram.de>
Cc: Scott Wood <scottwood@freescale.com>, Carsten Juttner <carjay@gmx.net>,
       linux-kernel@vger.kernel.org, i2c@lm-sensors.org,
       linuxppc-embedded@ozlabs.org
Subject: Re: [i2c] [PATCH take2] [POWERPC] i2c: adds support for i2c bus on
  8xx
Message-ID: <20071017230027.334a5f48@hyperion.delvare>
In-Reply-To: <47166085.1010608@scram.de>
References: <47134A94.60606@scram.de>
	<20071015183107.GA4361@loki.buserror.net>
	<47166085.1010608@scram.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 798
Lines: 23

On Wed, 17 Oct 2007 21:20:37 +0200, Jochen Friedrich wrote:
> >> +	/* Select an arbitrary address.  Just make sure it is unique.
> >> +	 */
> >> +	out_8(&i2c->i2c_i2add, 0xfe);
> >>     
> >
> > It's a 7-bit address...  and are you sure that 0x7e is unique?  Does this
> > driver even support slave operation?
> >   
> 
> It's in fact 0x7F << 1. The same value is used in the 2.4 driver and
> in u-boot, as well. Slave operation is not supported.

I'm not sure what exactly you are doing here, but 0x7f isn't a valid
7-bit I2C address.

-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/