Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Zulkifli, Muhammad Husaini" <muhammad.husaini.zulkifli@intel.com>
To:     Florian Kauer <florian.kauer@linutronix.de>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "Gomes, Vinicius" <vinicius.gomes@intel.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "Tan Tee Min" <tee.min.tan@linux.intel.com>,
        "Gunasekaran, Aravindhan" <aravindhan.gunasekaran@intel.com>,
        "Chilakala, Mallikarjuna" <mallikarjuna.chilakala@intel.com>
CC:     "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kurt@linutronix.de" <kurt@linutronix.de>
Subject: RE: [PATCH net-next 3/6] igc: Handle already enabled taprio offload
 for basetime 0
Thread-Topic: [PATCH net-next 3/6] igc: Handle already enabled taprio offload
 for basetime 0
Thread-Index: AQHZnsmaW64TyiErrEqDiGUn7XvA66+Nmr3g
Date:   Fri, 16 Jun 2023 16:06:14 +0000
Message-ID: <SJ1PR11MB6180D857F9169FB6C3E1146CB858A@SJ1PR11MB6180.namprd11.prod.outlook.com>
References: <20230614140714.14443-1-florian.kauer@linutronix.de>
 <20230614140714.14443-4-florian.kauer@linutronix.de>
In-Reply-To: <20230614140714.14443-4-florian.kauer@linutronix.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0PXd7xjfG5gaPOK6CkZUY7B6gD4CZbptlKyNZ/QUnHZ+Nwsf51oaGwTi5XmI?=
 =?us-ascii?Q?XNEZ0yhQKTFNclVvGZ+JTk2xoepAKPHh+dU+bY6aUISDR7iYwvqEsavcJ4uk?=
 =?us-ascii?Q?a8KWKbr/xvVcK0cB2S4KlZ0hqqgkOSQELnAgAKAclcJefRsQ2QIZvGa65bJv?=
 =?us-ascii?Q?t2nxGn0qUNGjYuuL0QgWRIKxkhlHLGmkCsYi1A0P8K89nsUNL5fhMwz7E4PV?=
 =?us-ascii?Q?ueEou/PP6sluWQONXw/XDf5OoheT0wd72KTavPU1BrNqi7dOPGcNjjpwpreV?=
 =?us-ascii?Q?BPfmH+m2xms2xGz7JLUC1bpSNGs8qiOBZWJWxP9r7ixqRXeZjwbQ1XE9tueo?=
 =?us-ascii?Q?1KJiig51TADStRlOtXWhJqMViPmi5+SXE3kOvgFJPoCKEFfz7wejqCFg3EDX?=
 =?us-ascii?Q?QkKPLYQe/0cYonRRIM6FjGab5ez0BIyoS7VDypH+DN/7TsvFQ0TP2yqon8fq?=
 =?us-ascii?Q?fb5zcoDtTUo5Gq9swpZ+3CUB8mumr4bPwHtOtlDPEnaQ1Vr1vexdpVQxtd9A?=
 =?us-ascii?Q?EdB6uUsz8bq3JmQ2VydWD9NAMNO+gCPAsiu20v6lnzJBYHr4At3t/nHa0lmH?=
 =?us-ascii?Q?qqs9igDftJE07SH3zFj+dZnCh41dU1kX2pIDdZsKMcYDfNVWO640TZsizn9E?=
 =?us-ascii?Q?Q//QN8Lr6L2kDZS8Xt4ltlrTsN+JUjnOHslTIUlTSE/XgcHBVJHQi7YrpQ9D?=
 =?us-ascii?Q?p0kvLFq8oF0JGzEv9LhzxMXYiPXQhtd63xsEaMSdBG2G1hdXl+9TkFj9DhtC?=
 =?us-ascii?Q?R5KF5Rp1BCq/F6ChPmkjUquzttXlpZlIEGYpKY5Kg+iSIFLvdkDZslsf9AXs?=
 =?us-ascii?Q?1jnfMxHaGNYVKq9u7xBa7I7aJOJlyrsvnH6SwnU7gBr+G56uOFjuknE2Nu9J?=
 =?us-ascii?Q?8WWymGGRofsJ1scQOf0I89Ng7dKXtNIw46ZWIlUjEfxwQNECte5ZzqxHKBEs?=
 =?us-ascii?Q?q95ZpqZJyTLopeBjfUx3rhTgnTnEkjZpoKThw/rGYg4VX0XBoSxb+OcyrCcY?=
 =?us-ascii?Q?mVM3MONp4Z1V6SjO3fO4QU4GmENzr0pzl0S8yJotQiOQez5Y6hDodim4KG9N?=
 =?us-ascii?Q?xWG9xXTS+ABXt6Hgz3HR4Fdyg3YrylX4Fi5/w+9UWrx8riQEss2P543EacXl?=
 =?us-ascii?Q?4M1hXZIr+dHzQ9Tdlr3mILkyZtEQDX0c3BwMwlt+CC1c5M2gI1Lhhd6AB3Eo?=
 =?us-ascii?Q?W3fwh2T4GH1n9vOnIW/MmClCNSUI72HnfGyvl76UQqE6DT209m5B7+l2Ec2q?=
 =?us-ascii?Q?6zQBbtgnYGLZ/5X066Il3hoE8fl9lThJ7G8thnerbNM9THaiyRl0Fq+jQKG+?=
 =?us-ascii?Q?tKi7XDD6kn7Gm4cylr0ksHU+5/dfFKsjyyRuFE4LnIIRyG3QD+7MhY3/M++o?=
 =?us-ascii?Q?lFEL9F06SZqLWfwAoMs7QA7BnlJY3e6tDdSjpU/e6kTJekr0HyHvxai40Clb?=
 =?us-ascii?Q?ExA8pT4tlZ/zXyrJWke8xEkyezAGL7tdawWU++RgQT36D7jlVdTJXVZwCrZU?=
 =?us-ascii?Q?OD4OKYksQehE1x+wwlMMHimFxI/gwSBoK0u6LHQW0rcJcNZ90wiN9W5EJ+Hx?=
 =?us-ascii?Q?9L7TEycd4PUI5Y+0nuHY1upCOT0kfQweFs6Tg2ZMGCxMErVXJg38FiQ+MRWb?=
 =?us-ascii?Q?UxWmRB6pPSLI0049Q3p8bus=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6180.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8db5d197-b734-4235-3365-08db6e839c42
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2023 16:06:14.4149
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: L79XoYdvcaSXAbsdkxF7ZstDep/JKC2pAF9CVC94ENh1/BypvzQE0BQh/gKpU1O8q9h1IQ5vK71RLkS3CnoN/pBIZGAJEPystKZLMC7uDdpNfPkn0Hflp2mHCzkipICZ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8279
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Dear Florian,

> -----Original Message-----
> From: Florian Kauer <florian.kauer@linutronix.de>
> Sent: Wednesday, 14 June, 2023 10:07 PM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; Gomes, Vinicius <vinicius.gomes@intel.com>;
> David S . Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>; Tan Tee Min <tee.min.tan@linux.intel.com>; Zulkifli,
> Muhammad Husaini <muhammad.husaini.zulkifli@intel.com>; Gunasekaran,
> Aravindhan <aravindhan.gunasekaran@intel.com>; Chilakala, Mallikarjuna
> <mallikarjuna.chilakala@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; kurt@linutronix.de; florian.kauer@linutronix.de
> Subject: [PATCH net-next 3/6] igc: Handle already enabled taprio offload =
for
> basetime 0
>=20
> Since commit e17090eb2494 ("igc: allow BaseTime 0 enrollment for Qbv") it=
 is
> possible to enable taprio offload with a basetime of 0.
> However, the check if taprio offload is already enabled (and thus -EALREA=
DY
> should be returned for igc_save_qbv_schedule) still relied on
> adapter->base_time > 0.
>=20
> This can be reproduced as follows:
>=20
>     # TAPRIO offload (flags =3D=3D 0x2) and base-time =3D 0
>     sudo tc qdisc replace dev enp1s0 parent root handle 100 stab overhead=
 24
> taprio \
> 	    num_tc 1 \
> 	    map 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 \
> 	    queues 1@0 \
> 	    base-time 0 \
> 	    sched-entry S 01 300000 \
> 	    flags 0x2
>=20
>     # The second call should fail with "Error: Device failed to setup tap=
rio offload."
>     # But that only happens if base-time was !=3D 0
>     sudo tc qdisc replace dev enp1s0 parent root handle 100 stab overhead=
 24
> taprio \
> 	    num_tc 1 \
> 	    map 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 \
> 	    queues 1@0 \
> 	    base-time 0 \
> 	    sched-entry S 01 300000 \
> 	    flags 0x2
>=20
> Fixes: e17090eb2494 ("igc: allow BaseTime 0 enrollment for Qbv")
> Signed-off-by: Florian Kauer <florian.kauer@linutronix.de>
> Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
> ---
>  drivers/net/ethernet/intel/igc/igc_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c
> b/drivers/net/ethernet/intel/igc/igc_main.c
> index 122158b321d5..35ace8d338a5 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -6123,7 +6123,7 @@ static int igc_save_qbv_schedule(struct igc_adapter
> *adapter,
>  	if (qopt->base_time < 0)
>  		return -ERANGE;
>=20
> -	if (igc_is_device_id_i225(hw) && adapter->base_time)
> +	if (igc_is_device_id_i225(hw) && adapter->taprio_offload_enable)
>  		return -EALREADY;

I appreciate you catching that. Only i225 is affected by this; i226 is unaf=
fected.

>=20
>  	if (!validate_schedule(adapter, qopt))
> --
> 2.39.2