Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230614082626.45467-1-luojianhong@cdjrlc.com> <f629797b0b525095352acbf565b48481@208suo.com>
In-Reply-To: <f629797b0b525095352acbf565b48481@208suo.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Fri, 16 Jun 2023 09:36:30 -0700
Message-ID: <CAEf4Bzbs5m6Pt4VZC8LBj5Cnw1--cgMRcR1vqOOTVi1o9yKoqg@mail.gmail.com>
Subject: Re: [PATCH] libbpf: zip: Remove unneeded semicolon from zip_archive_open()
To:     baomingtong001@208suo.com
Cc:     ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
        martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
        john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
        haoluo@google.com, jolsa@kernel.org, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jun 14, 2023 at 1:29=E2=80=AFAM <baomingtong001@208suo.com> wrote:
>
> ./tools/lib/bpf/zip.c:226:2-3: Unneeded semicolon

This is not a very human-readable commit message. Something like

Drop unnecessary semicolon, which triggers (presumable coccicheck?) warning=
:

./tools/lib/bpf/zip.c:226:2-3: Unneeded semicolon


But also this doesn't apply cleanly to bpf-next tree. Please rebase
and resend. Also make sure to have [PATCH bpf-next] prefix in email
subject. Thanks.

>
> Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
> ---
>   tools/lib/bpf/zip.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/zip.c b/tools/lib/bpf/zip.c
> index 3f26d629b2b4..88c376a8348d 100644
> --- a/tools/lib/bpf/zip.c
> +++ b/tools/lib/bpf/zip.c
> @@ -223,7 +223,7 @@ struct zip_archive *zip_archive_open(const char
> *path)
>       if (!archive) {
>           munmap(data, size);
>           return ERR_PTR(-ENOMEM);
> -    };
> +    }
>
>       archive->data =3D data;
>       archive->size =3D size;