Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 10:59:53 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Ben Dooks <ben.dooks@codethink.co.uk>, <nvdimm@lists.linux.dev>
CC:     <linux-kernel@vger.kernel.org>, <dan.j.williams@intel.com>,
        <vishal.l.verma@intel.com>, <dave.jiang@intel.com>,
        <ira.weiny@intel.com>, Ben Dooks <ben.dooks@codethink.co.uk>
Subject: Re: [PATCH] nvdimm: make nd_class variable static
Message-ID: <648ca319ba772_1da39e2948@iweiny-mobl.notmuch>
References: <20230616160628.11801-1-ben.dooks@codethink.co.uk>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230616160628.11801-1-ben.dooks@codethink.co.uk>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oaPaA1rhuKLzeUHr4bXUa/C5f6L5uU2mNCNpPPZxTICbylBHltQoIaVVGXMo?=
 =?us-ascii?Q?WIIOV/d2zNbCyts0QTo5D7cThiiXlSuUSZoywV3bKYxLSCwSU6phaGcQx844?=
 =?us-ascii?Q?MSv9S3IuvdmYxrQWzATZszJQL+YxjXFiZPMm8cL/7BmAqNPPZQqaR1Fe20gr?=
 =?us-ascii?Q?5jLvdre7v6G6rIQOdcs3bHWRFQuj5/eYyaSQSm3g6meF828Yx/WAc6TYNwez?=
 =?us-ascii?Q?IsTBHsuQQc0bcSqbVoUkYbBK4jmdpZU0Ti8RZ1f3bs8ZG7ssGb1Hr63MzCpR?=
 =?us-ascii?Q?Sb9YnkqHl54DareIIXe04bUY5bZMTPib70u1wrKBcCc5KrbX3RoPJcRCD1iu?=
 =?us-ascii?Q?gxcB3u4ETpO1urgVGdoxd609BecbM6HLohzyZnHJ0c9JY/iPYb3ULWx90ZZf?=
 =?us-ascii?Q?I/ZHxIR9E4mJrqUNJHRRfgVBw0Sn9h0GMaXEnCrhme/H3KgYFxhJ14enCbeP?=
 =?us-ascii?Q?9jdxf6vN9V23AyaOAUNNrbH/xjBMv3fH2CwFJmBUGOEAkhsMDsrzAOSGAspv?=
 =?us-ascii?Q?LZmJM0aVxaScFlGzncksBNHMgXQFXV3HGF/YiI6DQa7cgYs+VZgm02nfFH1n?=
 =?us-ascii?Q?4ckXNoNMPBJR54T1t+pz63ERmMmxYrCwxZSY/Mf051L9KoH7V/02s23dje39?=
 =?us-ascii?Q?pj2TofTQLeVu5WLoPTIo6q++ogKf5fNtji8/WZlwd1Z6/yZHlVEnYxvq8ldN?=
 =?us-ascii?Q?z1tRSrcETgHB6MSlywaxIQeBuMTo8K4aJ212K8Ld6y9JLGFyjq3mIIaNkhLx?=
 =?us-ascii?Q?kRiKApVfe1xb9c787RJ8WZeCprqEYW07v60bd3Yq2GXSM0LET66+t0E2knDs?=
 =?us-ascii?Q?3DmvJJpy/g3BVn0n68+QR7eT9IH1HP7H7LG1yKWRTzW1egZ95ypUFtE/DRmL?=
 =?us-ascii?Q?ZHLm+8+KGdo8M35KHt5ipXHgZ0Wl+YB5AMoM2QcgB5e08rkAQ4vFZ5bQWuUt?=
 =?us-ascii?Q?b4ZIs4T2ykg8NHp4TIHC5i4E7RFudS7iQ/YgdP3dtp+QmQmbDrVTjAm8RvS/?=
 =?us-ascii?Q?6TE0kKdzFRF5iUuOLh59qhTOxY81crtStQfkcwCUxoAf7QGmwO8M1FyQ/xwf?=
 =?us-ascii?Q?OAtuPgNJomedQmXh3qugcEqup3f/vhl7Y8H4vnYsbiHuBJz3PuC6140dI3kn?=
 =?us-ascii?Q?yddtEs6i96bjA/CkP6ENFwmgQqk1ZO86Y4z4iV3+WLU/98KXg3yROan1aif3?=
 =?us-ascii?Q?wxOo61DqTrNL7SFwC0RE3aP2mPz/QSPEWU7101AQgnZvAkxEts8gLlKavn0G?=
 =?us-ascii?Q?+1syorHARKXbySSKmSS0qaj3xWMwtHXEpdWJe/7+UQ9WV8lAFZmApp4yikll?=
 =?us-ascii?Q?rSfK9qLSnWbI+f7JXjtY+uQMnN253j6Ig7LUuoaDFkbCsSY8/ybE5VAJbkiC?=
 =?us-ascii?Q?7hiVjh8S0MR69fVZa266r7hzAqD3tERycfGs9XcMw4DipdhsFWdRDa/wcG1u?=
 =?us-ascii?Q?9SAPpJPwhy18MDX5A5I4qtH1EJKv521jYZP6SA3cqXaPfvFFVPHjaL41hhUc?=
 =?us-ascii?Q?cV9Bh7yJ2a+Zix5R9gdz8QIOAlBDq47twGD7CE/KfLqAGfreOIJJRVeKEV4n?=
 =?us-ascii?Q?VZpy/giho0c1m2HmSvA0AIGUL1t+v6fwwoO+7G5feW3QxhNSoUc6J86PzIXz?=
 =?us-ascii?Q?Rc6Dx9/USkLWhcoGZxTJw2MV8a7TRukRYlLj2cexTCcy?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ea59fdf8-d735-4a32-a4b1-08db6e937faf
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 17:59:58.5688
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MPOlADff7TdMplDDtYKYgn8SJXEhdaU4nkFeAlfWCy+FFzUyYBXICvZPKDMUCPkXso2xS7Ko7H/zeHMbkpxLtQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7425
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ben Dooks wrote:
> The nd_class is not used outside of drivers/nvdimm/bus.c and thus sparse
> is generating the following warning. Remove this by making it static:
> 
> drivers/nvdimm/bus.c:28:14: warning: symbol 'nd_class' was not declared. Should it be static?
 
Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
>  drivers/nvdimm/bus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c
> index 954dbc105fc8..5852fe290523 100644
> --- a/drivers/nvdimm/bus.c
> +++ b/drivers/nvdimm/bus.c
> @@ -25,7 +25,7 @@
>  
>  int nvdimm_major;
>  static int nvdimm_bus_major;
> -struct class *nd_class;
> +static struct class *nd_class;
>  static DEFINE_IDA(nd_ida);
>  
>  static int to_nd_device_type(const struct device *dev)
> -- 
> 2.39.2
>