Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230530114216.1420790-1-yimingtseng@google.com>
In-Reply-To: <20230530114216.1420790-1-yimingtseng@google.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Fri, 16 Jun 2023 19:43:50 +0200
Message-ID: <CAJZ5v0gmmyLMWwzn8q_DCrKVg6mNJ+mHFcLt2AY8LJJ_4dt7dg@mail.gmail.com>
Subject: Re: [PATCH] PM: domains: fix overflow in genpd_parse_state
To:     YiMing Tseng <yimingtseng@google.com>,
        Ulf Hansson <ulf.hansson@linaro.org>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Kevin Hilman <khilman@kernel.org>,
        Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        marscheng@google.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Tue, May 30, 2023 at 1:42 PM YiMing Tseng <yimingtseng@google.com> wrote:
>
> Add type casters to prevent 32-bit overflow before assigning to s64
> variables. It allows full 32-bit range support for latency and
> residency.

OK, but is it really a practical problem?

Ulf, what do you think?

> Signed-off-by: YiMing Tseng <yimingtseng@google.com>
> ---
>  drivers/base/power/domain.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 32084e38b73d..26a04cd8d8dc 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -2939,10 +2939,10 @@ static int genpd_parse_state(struct genpd_power_state *genpd_state,
>
>         err = of_property_read_u32(state_node, "min-residency-us", &residency);
>         if (!err)
> -               genpd_state->residency_ns = 1000 * residency;
> +               genpd_state->residency_ns = (s64)1000 * residency;
>
> -       genpd_state->power_on_latency_ns = 1000 * exit_latency;
> -       genpd_state->power_off_latency_ns = 1000 * entry_latency;
> +       genpd_state->power_on_latency_ns = (s64)1000 * exit_latency;
> +       genpd_state->power_off_latency_ns = (s64)1000 * entry_latency;
>         genpd_state->fwnode = &state_node->fwnode;
>
>         return 0;
> --