Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 11:25:20 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Ben Dooks <ben.dooks@codethink.co.uk>, <nvdimm@lists.linux.dev>
CC:     <linux-kernel@vger.kernel.org>, <dan.j.williams@intel.com>,
        <vishal.l.verma@intel.com>, <dave.jiang@intel.com>,
        <ira.weiny@intel.com>, <linux-cxl@vger.kernel.org>,
        Ben Dooks <ben.dooks@codethink.co.uk>
Subject: Re: [PATCH] dax: include bus.h for definition of run_dax()
Message-ID: <648ca9102ec9a_1da39e294d@iweiny-mobl.notmuch>
References: <20230616161309.22387-1-ben.dooks@codethink.co.uk>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230616161309.22387-1-ben.dooks@codethink.co.uk>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LWifi2Bc6ZwUJSOlljaPgj6ZkSdpxa8LSkNNqJWFbGGVuKWOrp55LTXOPbM/?=
 =?us-ascii?Q?XRDD+8cpRRzs0JejzcT6mOBgq55kEThFcp/GsjidP/8ntyWC6CNDKhce7SGw?=
 =?us-ascii?Q?qllpfcdjyY+AvQLDNhW7gkepBO7PW9oSNyjK6sOZNARK8EVYjJWZjpCIJgTw?=
 =?us-ascii?Q?Xe5wWBMAnPXqCwgShP5Hs/ipulzuyi8qd4Jk9Ue1mE0VjL2xBkulBn3Bznr0?=
 =?us-ascii?Q?B3VyyMl0Am9Vs/QZSoMD3umw/EwYSAj5GYvL2Pvxyoto8bm0dnCkDyKmJF3r?=
 =?us-ascii?Q?qQ2tfng9L44zVtnAYriBjrwwutxclI8Z6zw5XtSuSPP9q+YHd7YB3pInVMzZ?=
 =?us-ascii?Q?QysvihHFC5T0ucXCNMP4WkNujabL1aSQBUuk+LPaDM35Vf8ZTMN37l4tcosy?=
 =?us-ascii?Q?HhsxiYU7A8kiTxX7AUrcsC5qvZQ4JJmxgeHRum2XFvkToug+k9Zc+3HxGEEt?=
 =?us-ascii?Q?zobGXUrjgcXyj+YgggrBfH0CdEIpaE35Mc3OSY7O6BD+STYfjSFl8Y96TgDZ?=
 =?us-ascii?Q?jK4g6uuS6U0hrmpBF8RqniMCEqHtl9lQ/ErYY4I1uPVhU8T7wU4X3LjZdkby?=
 =?us-ascii?Q?0TJ1gGF0xhAOKydBaxb1iqWUy1uExbMmD01CO0ZnBacLpsMz6R3IEz6JYHQM?=
 =?us-ascii?Q?rQHKf1+HMADc6Y/6mk78r2DucxSS3k73FoFakWKP/SBOyoovwGWbEuLhBUFP?=
 =?us-ascii?Q?dKTFYt/KNLXypcX/kFZy2p4pTwnfw1ifxWo4oUY4PCM2CIMVJrOlIck7Y94F?=
 =?us-ascii?Q?zVbUZGAKw2KjKvwxwUMRWhV0aFFho8/mT+fPYxfG198QPqa7+LfeAiyryg34?=
 =?us-ascii?Q?BfZjBba/RhdXfCce3uMy+NpmXRdsxhXV73R4BmNbzFNpCt2yfvol5uFQcawY?=
 =?us-ascii?Q?lXgwyTyfmyX0KhP43rdlH7kWZFAdL4xI/ZK1bxX1WK5XZOEP0V8s2SE2e9po?=
 =?us-ascii?Q?R2ykwsx6qnDjSbVyumy59dfKVkAygGoW8WafrRAx4sMwGJK1MPAIz5PY9hO9?=
 =?us-ascii?Q?hB+m7EGfqzUVoTDtY6k3skSg1gI0SceDoeANu9kIz7ssGREXamBliJxMN4iF?=
 =?us-ascii?Q?85sQo0WzE9Ut7XdymB1RN/5fsgrIzavuVFqxvd7yFLiWMpA0UXWZMCwl1K/7?=
 =?us-ascii?Q?DuRLK512a5u2XjV1QnMgWPxo33VTKnnpSH8XrJrcpIFk7ZyJxyXR6UKHDa+j?=
 =?us-ascii?Q?nF/JeujObRl36P4vbQsUlQEoU+jBtbVZH+h7/doK6YVQxRW9G7wkJh7jfUtp?=
 =?us-ascii?Q?nqs9fsATmJ83Ba3Yv0dfxCLGBYk0CM3JO6WZ3hJwIcLwdvf7kjSI+ee79MOI?=
 =?us-ascii?Q?qMnJTsE+RWRX1R34lzQB0fHuvGI5x3wQ34l1e6cVWZQIjo1gNLTDHYmG4YM/?=
 =?us-ascii?Q?lEumejqb+4Rx6vKaQWCnqTUopl8h8PnuedEnlQCZq0FJtyqk+6klHwL5oMjh?=
 =?us-ascii?Q?jAtMfMrFJWIiO+khPncbS4SMXixt8c0gGbdhfXdQZNbb6pvzQDePvdsQpCtu?=
 =?us-ascii?Q?zTdf/U++Mqs49IDiZN29+EIZY9csPC3MBilkSxzmO9pj+VwfBQ8BNFt5NO4B?=
 =?us-ascii?Q?rLi8Q3KCubCONWgm+xk+bX4AxoYwPl3ZhIPzF2AjFdd0u1NmyQvGiH1TvG4H?=
 =?us-ascii?Q?KzE0iw7LMgzjQt+Z30ZQXqRZ9OIe5P4utl5XBaDkmJzn?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 11b33137-0569-42dc-b423-08db6e970e15
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 18:25:26.0615
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3y6oPAe+qWoaG/9g9RKLf0KQLFCUXmW+Y7jknprynI2SrzcjQwYDaeO0Ay9E0E7EI+O7KwUNSR5YFpzVWmLRPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6719
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ben Dooks wrote:
> The run_dax() prototype is defined in "bus.h" but drivers/dax/super.c
> does not include this. Include bus.h to silece the following sparse
> warning:
> 
> drivers/dax/super.c:337:6: warning: symbol 'run_dax' was not declared. Should it be static?

A different version of this fix has already been queued up.

https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git/commit/?h=libnvdimm-fixes&id=2d5153526f929838b0912ded26862840f72745f4

Thank you anyway,
Ira