Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 21:49:45 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     David Howells <dhowells@redhat.com>
Cc:     netdev@vger.kernel.org,
        Alexander Duyck <alexander.duyck@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
        David Ahern <dsahern@kernel.org>,
        Matthew Wilcox <willy@infradead.org>,
        Jens Axboe <axboe@kernel.dk>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Menglong Dong <imagedong@tencent.com>
Subject: Re: [PATCH net-next 01/17] net: Copy slab data for
 sendmsg(MSG_SPLICE_PAGES)
Message-ID: <ZIy82RjpmQMTNafS@corigine.com>
References: <20230616161301.622169-1-dhowells@redhat.com>
 <20230616161301.622169-2-dhowells@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230616161301.622169-2-dhowells@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7sHqMvRM3PTiHT5VWFmvIcaPGEOeVNSchiIrYaZUp5TAQBy/+iA2hR5yE7VP?=
 =?us-ascii?Q?UQSblo8cqUAgOCFQrEiA8N6YArZeaPN/6j1Uq/Xj/2lRvqxd74RFTRFCzXsk?=
 =?us-ascii?Q?KcG93Z3NX5Gnsv5JrCWdolKkheUgh2f15aYqUoYuxmPNdlQQYNRNPeXWOkQf?=
 =?us-ascii?Q?f0Gh+n39chpjLGhnqtQ4SBWFow8MHYMUMg4lq3gMCOX8isEoH/8yFk9YJpXZ?=
 =?us-ascii?Q?9DIxLb/PELf/wH/h1aD7R9gMXr/doKS2Xpo3Qp9MPLdUpv/sSu/gHcF7SE2p?=
 =?us-ascii?Q?ktNeYiv5GUmi5nn3IDrIq4TQdnzW9DPc/jF+0LMscFniWm+yMu3JHdmLj9KF?=
 =?us-ascii?Q?0bMXS41OW4I6a8/ccWnd+b+29uI5IKcRuAtEEcQ/uDCxq3YONI4dsrgbhn1R?=
 =?us-ascii?Q?qwW18prch79OD4IMxVYVNqXWPFnkLXGuC4D+oQ4grnDSLDtot9HeKLpECU7j?=
 =?us-ascii?Q?iKTEjdlqtCqQiR50qir5KPw8ZJCdUyaUsvi6hdCr5fIYGNAhikvFwhnH/oME?=
 =?us-ascii?Q?5ZeRat9a6NoMmjmdmw+esjUvfhSHxIOpnuj00QnsL76E8ABQggL6ZH+7Sjq6?=
 =?us-ascii?Q?n3YY6N9nEjFOwRPug52q9lg00jFXvoAjVx2lUI7RdzKkpI+bUJVlj+LAx2fV?=
 =?us-ascii?Q?J5sE+VlsAfvCaOkQ4y71t4AVDjXibHjehsLhL6JFjvMj0EpozMhWc3ueTdQm?=
 =?us-ascii?Q?K3fz5eMgcd9r/OCXBXkWozmi1pNo+aBJ+CuueK7XA30aLTYgQhGvSWrmTom5?=
 =?us-ascii?Q?XlCmzP5h3iQG+lkdEF/DAqA001lawFvGZw0uDJo0KKWceDBEkCh3WYdx0hYL?=
 =?us-ascii?Q?IOeQuZv4EmCwCAHYp0SALcMBgIVIFttjxeIH2nT7GpHMKup2lfxSoSqPv8e2?=
 =?us-ascii?Q?wCsJ3XyrTGazMHJV47757O4WIwVbCIzf75SmtXvGhiGTlemS+SJLqr5mRedU?=
 =?us-ascii?Q?dY+fK64u87cQd7T67Hrc2N/GkuTzRAN6A2M+ZFOfhOaEf+Swc9CjYY1jV9SP?=
 =?us-ascii?Q?0GHVtdyxmPMiegVgcPwbMtJcWlNOn+uFY02IveJTc9ngpARpeAArVE9UE7qp?=
 =?us-ascii?Q?4sxtWOmTyJrcRGFLj4ENLYm6Ak57EGpmfrdc8FBJ27xwgN/72o8hzIAvzcil?=
 =?us-ascii?Q?mLnGcq3w/+n8vc+JSHjP393Z5Slt+QkwHtg5tpHzreRfP6kH+Gma/0kAuhTG?=
 =?us-ascii?Q?o4s+jm89klwrzyISBTWOxlG+QlWvCkHUdntU9OY6IKRUvgYzzuH49CYBoaKp?=
 =?us-ascii?Q?2GutbaJiTUoI+4wGLTRR4HEnSvulatbzWWLhMhi13Pdb464NGi6IfQmJd47+?=
 =?us-ascii?Q?qsgi3acAiuwVZl8hpjkCy6JT3vbrx0AfhyTlw1K25bDbMDHUtXnf4d09q4Eg?=
 =?us-ascii?Q?cS/GFH33/eMw8qU4p7fmwb5ruzFe7pXcwx8x9XXo/21x7WIt7upBygig4i9W?=
 =?us-ascii?Q?ITVNYctO+OsEZ+9I6n4iOu1297K+Rf8I+S1Lcpla1jEZz5kYZXnQ6ViczcLz?=
 =?us-ascii?Q?QqfdDlPsxaPcdzlwmW0/lWCAxaSEqrQgwUsIk/vp4Lk9g7Ieb25JpUl1oKig?=
 =?us-ascii?Q?zhF/0WfX5EHzPy2u0TqcDzVOHcclHADp9UnMggAodZ0X3JnRsk6fcSoLVw2O?=
 =?us-ascii?Q?tgWoz+JEi1EPNUW+wAaqphZRX7Ky1OTKrzPaYVs+AAQAmghMF7o4rFrxlHY0?=
 =?us-ascii?Q?1mL/fw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bce14373-aea6-43b4-ae89-08db6ea2da70
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 19:49:53.4116
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AhVrALmfh7TF7n0HlM9pdGXhIq0XHaMjpJT/+uQrWc2MD2Cl1K3y3rgV8qM2oQ7SpkFY0CK1WgSk3RH6lPmb/BrZpyRNRKvjXd+GfTeuoeo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB4037
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 16, 2023 at 05:12:44PM +0100, David Howells wrote:

...

> +/**
> + * alloc_skb_frag - Allocate a page fragment for using in a socket
> + * @fragsz: The size of fragment required
> + * @gfp: Allocation flags
> + */
> +void *alloc_skb_frag(size_t fragsz, gfp_t gfp)
> +{
> +	struct skb_splice_frag_cache *cache;
> +	struct folio *folio, *spare = NULL;
> +	size_t offset, fsize;
> +	void *p;
> +
> +	if (WARN_ON_ONCE(fragsz == 0))
> +		fragsz = 1;
> +
> +	cache = get_cpu_ptr(&skb_splice_frag_cache);
> +reload:
> +	folio = cache->folio;
> +	offset = cache->offset;
> +try_again:
> +	if (fragsz > offset)
> +		goto insufficient_space;
> +
> +	/* Make the allocation. */
> +	cache->pagecnt_bias--;
> +	offset = ALIGN_DOWN(offset - fragsz, SMP_CACHE_BYTES);
> +	cache->offset = offset;
> +	p = cache->virt + offset;
> +	put_cpu_ptr(skb_splice_frag_cache);

Hi David,

I don't think it makes any difference at run-time.
But to keep Sparse happy, perhaps this ought to be put_cpu_var()

...