Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-496-g8c46984af0-fm-20230615.001-g8c46984a
Mime-Version: 1.0
Message-Id: <c2f3656f-b831-4009-8ee6-a2430c4ac8c7@app.fastmail.com>
In-Reply-To: <20230616183120.1706378-1-sohil.mehta@intel.com>
References: <20230616183120.1706378-1-sohil.mehta@intel.com>
Date:   Fri, 16 Jun 2023 22:11:49 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Sohil Mehta" <sohil.mehta@intel.com>
Cc:     linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
        Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH] syscalls: Fix file path names in the header comments
Content-Type: text/plain
Precedence: bulk

On Fri, Jun 16, 2023, at 20:31, Sohil Mehta wrote:
> Some of the syscall definitions have moved due to the original source
> file being moved into a sub-directory. Update the file path names to
> reflect that.
>
> A couple of syscalls such as lookup_dcookie() and nfsservctl() don't
> have a syscall definition anymore. Clear the filename and leave the
> original subsystem name intact for reference.
>
> Signed-off-by: Sohil Mehta <sohil.mehta@intel.com>

Thanks for going through these!

> Arguably, having filenames in comments might not be the best idea.  If the
> intention is to make it easier to find a syscall definition, it is probably
> faster to just use 'git grep SYSCALL_DEFINE | grep <syscall_name>'.  Please let
> me know if it would be preferable to just get rid of these comments all
> together.

It's probably not worth trying to keep the comments in sync, I'd be in
favor of just removing them all.

     Arnd