Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 12:52:19 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Wang Ming <machel@vivo.com>
Cc:     Mike Rapoport <rppt@kernel.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
Subject: Re: [PATCH v1] mm:Using div64_ul replaces do_div() function
Message-Id: <20230616125219.dc2346534d6f279a7527c0b0@linux-foundation.org>
In-Reply-To: <20230615075127.6832-1-machel@vivo.com>
References: <20230615075127.6832-1-machel@vivo.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 15 Jun 2023 15:51:14 +0800 Wang Ming <machel@vivo.com> wrote:

> Fix the following coccicheck warning:
> 
> mm/mm_init.c:2492:2-8: WARNING: do_div() does a
> 64-by-32 division, please consider using div64_ul instead.

I guess coccicheck was fooled by the incorrect comment over do_div(). 
do_div() returns an unsigned long.

alloc_large_system_hash() should be using a u64 for `max'.  Nobody uses
unsigned long long any more.

> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -2508,7 +2508,7 @@ void *__init alloc_large_system_hash(const char *tablename,
>         /* limit allocation size to 1/16 total memory by default */
>         if (max == 0) {
>                 max = ((unsigned long long)nr_all_pages << PAGE_SHIFT) >> 4;
> -               do_div(max, bucketsize);
> +               div64_ul(max, bucketsize);
>         }
>         max = min(max, 0x80000000ULL);