Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3221509rwd; Fri, 16 Jun 2023 14:11:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4+VBUUAfUIwux/ugG24EC1kxDPOKFrbn63u6PbCpcZm+fcNcZJSzX8Gt9AX7ja+1F0P5l6 X-Received: by 2002:a17:90a:850c:b0:25e:87af:a9ff with SMTP id l12-20020a17090a850c00b0025e87afa9ffmr2495601pjn.13.1686949909077; Fri, 16 Jun 2023 14:11:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686949909; cv=none; d=google.com; s=arc-20160816; b=Xe1PBq43rBWnmzJINi26yW03CxW26OORxPgycL5uKbcAfDiIAd41LH9jMk15RkR/2y g0wuzfl/w+ouOs8202BE+5JkDPN9tt+VOKTzEg91BTyuL3uKTEPOAsrtyMAaAk8l3+Oi Bfb7bV6d1ejglBRIkQ48R0VqHdDg7L8RLnugYYTtckiQhYDWhSJepb/CxE9KlJTtrF2f A48LSD/x7uZdRCpcv5nvlOkR9g8N/3a6YzV7B10LM+RVlBGZgTVXNGtRgAmbrvj+Lg4s akxtTLk3CJOYJ8Iv+gt9eZCkEe75Qs/PIa7aPPBhnHhGXdaKlpkuGejyGE+M4BDRHkWn OCRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=ivIgUdp6sPgYFFh8hMcp0Gstm0CEoesBooKN/iQfx78=; b=r2pEUZUsl5YP4yL6MofQG/KQQUb47/71yWRrkRuNdC++8O5LSHiyfoyxt7w/AuSK0x H9MhXQ3McnZOW7qj1uE+U2nmGumkuo5uMvVJ/ct2OSaT3lBwh1ZF1btl68DF8dJjGmLi 7Mu7s7y0bgBWTVmWGOJtlzR92XNZ2h0KOw/lgdd5A7RiPRNv2SyHDK2nwT6HyQAK0RPT PHDSrdC5wjRQ6yrvDvehwQ4g0fHs8gO+C68oQysAVQKdBNAiCNDekm30K1hrgk8x42Da XDKo0OJNJNDaclkRV0GPDJw47h+Tm9OfhIaXrcI46gtrydMeTvVMPqhxr+37QX3UfRJ5 yBGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ac68FdO8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f18-20020a637552000000b00547b25ea09asi2716291pgn.685.2023.06.16.14.11.34; Fri, 16 Jun 2023 14:11:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ac68FdO8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233074AbjFPUfO (ORCPT + 99 others); Fri, 16 Jun 2023 16:35:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233180AbjFPUey (ORCPT ); Fri, 16 Jun 2023 16:34:54 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E8DF3A9B; Fri, 16 Jun 2023 13:34:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686947693; x=1718483693; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=gqFVDbmVob3I2MoqOIXVaTRuNrQ5hYWbmLsucJsf0nY=; b=ac68FdO8tQy5GdqPGg00jlGyicPp/O8zg5oDTh5gS4tMXn750INuM/qg aAvSFlkz+zEwD0rarNEzT0po+jYyQYSqwZ/G4pPIFrcIxwVCwYyz8C2l8 xWF+2pRQxXK/K1acH47LnR3ZSEFiB6T+Qinj84DLbg9BZeIgpFJ2wJu8v d3IUrGzcWAV9pVMtVpgI1L7oRkJJCIe40cpjegMzty6r4Z8o5cud8r2Jb nSvlAAWfkUW+vNHpGDzO8OZWR490D6C2Z1421c0O5wfDHX22berNG1ST0 ilcfGTtjilIQbijl+HODZQ7IQVTjE0JpH8H6FT/WTTXk/KYygBoHyq+kF g==; X-IronPort-AV: E=McAfee;i="6600,9927,10743"; a="358181776" X-IronPort-AV: E=Sophos;i="6.00,248,1681196400"; d="scan'208";a="358181776" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2023 13:34:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10743"; a="802964400" X-IronPort-AV: E=Sophos;i="6.00,248,1681196400"; d="scan'208";a="802964400" Received: from inesxmail01.iind.intel.com ([10.223.154.20]) by FMSMGA003.fm.intel.com with ESMTP; 16 Jun 2023 13:34:50 -0700 Received: from inlubt0316.iind.intel.com (inlubt0316.iind.intel.com [10.191.20.213]) by inesxmail01.iind.intel.com (Postfix) with ESMTP id 57A7B911EA; Sat, 17 Jun 2023 02:04:49 +0530 (IST) Received: by inlubt0316.iind.intel.com (Postfix, from userid 12101951) id 5461CCA; Sat, 17 Jun 2023 02:04:49 +0530 (IST) From: Raag Jadav To: linus.walleij@linaro.org, mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, mallikarjunappa.sangannavar@intel.com, pandith.n@intel.com, Raag Jadav Subject: [PATCH for-next v1 3/3] pinctrl: baytrail: invert if condition Date: Sat, 17 Jun 2023 02:03:56 +0530 Message-Id: <20230616203356.27343-4-raag.jadav@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230616203356.27343-1-raag.jadav@intel.com> References: <20230616203356.27343-1-raag.jadav@intel.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Invert if condition and get rid of redundant else. Signed-off-by: Raag Jadav --- drivers/pinctrl/intel/pinctrl-baytrail.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c index 97ead2c58b66..27aef62fc7c0 100644 --- a/drivers/pinctrl/intel/pinctrl-baytrail.c +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c @@ -753,9 +753,7 @@ static void byt_gpio_clear_triggering(struct intel_pinctrl *vg, unsigned int off value = readl(reg); /* Do not clear direct-irq enabled IRQs (from gpio_disable_free) */ - if (value & BYT_DIRECT_IRQ_EN) - /* nothing to do */ ; - else + if (!(value & BYT_DIRECT_IRQ_EN)) value &= ~(BYT_TRIG_POS | BYT_TRIG_NEG | BYT_TRIG_LVL); writel(value, reg); -- 2.17.1