Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3221965rwd; Fri, 16 Jun 2023 14:12:19 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4yGSwGz0za/OKvXFLaWILBmQdWVaXDbnetHZxbDgc3Mo6JXrzyiVh/v9311dOWud+cXobv X-Received: by 2002:a17:903:2643:b0:1a6:45e5:a26a with SMTP id je3-20020a170903264300b001a645e5a26amr2128053plb.27.1686949938520; Fri, 16 Jun 2023 14:12:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686949938; cv=none; d=google.com; s=arc-20160816; b=y3RsVM7TAFxW5yED/6f0BLJJmRTPSyPoctqIX753G0/0VHkBBG/hVgTAvs5LodrpVW e+ci5qKwOPGcboX9ZVkAR+uysWs6M337336w90dI3Q8RGiukR+X+w1Yl6UTCJaZpyNeh r5O6Gr3AfTNZOJoh/0KYWjonj0q7k1ZxjqjxA/XMphJ6354tYeV4g+DeEFULmdXLy+RB qthSSWnBb+0Dl+Co370IftomVnJQhd5gE7Z/dOX6M7Gubd6FTv2Jcb+0yOV3nZc8bysH UMPed5x5RsJNX5jSNuRdEQZJiacHV8IMxZknxp6rDDZl/lztfiuV4vipM1uSE6ZeNnIe RRfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=za7Wba2fM/qIMMUatKDGea50zMmcCuEOpPbahiJJj7U=; b=J0crAAN6qS17spPTopwW++OJgYSXSQFdZ7lgjJu25BVM9V3SveKdi6wKupxYT27ShK L1LJ5JQi8RgQ5Wva5kiXQUfxLF0PuBirSvXegU24gUD1YVsIjQQ4S/lx6BUnEuZtbi1V rCQ4M5K2tUddYLSBqf5eYOrT3Op6bWrP61SqdWspGpsYLPTYd1Ojg7uhorwnrcdQKFcV 6jQuxi2JfrUGb4umf8U/65JGXi7qB3ncrs7EJ/mU77PqeYot1eZA2UFr30Q/2WP8XsWZ /pfpWvrLAJruv/tIWJ8K9t+vQGugM8bqCSj8patjkNehU3pmVxD2S38MJLyJQXrMoQ05 OxQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=HOKyVUOV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b13-20020a170902d50d00b001b3c40cae6dsi11355246plg.342.2023.06.16.14.12.04; Fri, 16 Jun 2023 14:12:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=HOKyVUOV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231144AbjFPVHC (ORCPT + 99 others); Fri, 16 Jun 2023 17:07:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229928AbjFPVHA (ORCPT ); Fri, 16 Jun 2023 17:07:00 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B664D8; Fri, 16 Jun 2023 14:06:58 -0700 (PDT) Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35GKTG1s004082; Fri, 16 Jun 2023 21:06:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=za7Wba2fM/qIMMUatKDGea50zMmcCuEOpPbahiJJj7U=; b=HOKyVUOV1UfUXzD2/zA3/8BidtYYDu8GRfKRBgqdSPyqnac28z10ZgmccdGsyPPtnhuR mfVvrTiwkviVO19JqrqyjbCjZezQlPl/9h82qg9MhgdONdZ5hJCEiNb1nqa/khcVBAcU z/TW3IsBmE7s44fx3db7dlPC6DQS6p1ClDavAaXAjEz/vtuPRLzEvAnGAbhhpmbYQpm9 DEigdG+HgJMuJ2OFp7IC8+QRaVAH+0dFtZfl587qaX0UADqKn8qrAfQmEf6VP2SbCjj6 1EDMa8dC++rEuyba2MIvT7jeiliTAmzW8r94Do+b3VzQBmAsx8aid9kdM6pz5R+OyJ05 pg== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3r8mt0sgyd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Jun 2023 21:06:51 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 35GL6n09006248 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Jun 2023 21:06:49 GMT Received: from [10.110.47.14] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Fri, 16 Jun 2023 14:06:48 -0700 Message-ID: <3791f18c-89f1-f066-38c4-d8d13a3ab611@quicinc.com> Date: Fri, 16 Jun 2023 14:06:47 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/3] drm/msm/dpu: Add DPU_INTF_DATABUS_WIDEN feature flag for DPU >= 5.0 Content-Language: en-US To: Marijn Suijten , Dmitry Baryshkov CC: Jessica Zhang , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , , , , References: <20230525-add-widebus-support-v1-0-c7069f2efca1@quicinc.com> <20230525-add-widebus-support-v1-1-c7069f2efca1@quicinc.com> From: Abhinav Kumar In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: aGrCF_1cbB0Bk6TJHXfvFuyKpruSru8c X-Proofpoint-GUID: aGrCF_1cbB0Bk6TJHXfvFuyKpruSru8c X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-16_14,2023-06-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 clxscore=1015 mlxlogscore=423 malwarescore=0 spamscore=0 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306160191 X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/14/2023 3:49 PM, Marijn Suijten wrote: > On 2023-06-14 14:23:38, Marijn Suijten wrote: > >> Tested this on SM8350 which actually has DSI 2.5, and it is also >> corrupted with this series so something else on this series might be >> broken. > > Never mind, this was a bad conflict-resolve. Jessica's original > BURST_MODE patch was RMW'ing MDP_CTRL2, but the upstreamed patch was > only writing, and the way I conflict-resolved that caused the write of > BURST_MODE to overwrite the RMW DATABUS_WIDEN. > > If both are moved to dsi_ctrl_config(), we could do a read, add both > flags in conditionally, and write. > So just to confirm, there is no issue on your 8350 setup with widebus enabled right? > - Marijn