Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3302537rwd; Fri, 16 Jun 2023 15:36:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7DqGPaL5v1ayaXfZhQDQJIxbFybU/lakUgHizZZK350Ax02pWO1vGMXIYfZUmanguY55/g X-Received: by 2002:a17:903:22cc:b0:1b3:cdfc:3e28 with SMTP id y12-20020a17090322cc00b001b3cdfc3e28mr3831595plg.23.1686954999701; Fri, 16 Jun 2023 15:36:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686954999; cv=none; d=google.com; s=arc-20160816; b=WWv1dB6htVqK2PISZn6F4m9VuPinbpSBk08by2/MaM9XesziGSToJ0pJpe8qddVuEa 0zlC58oLyP2zuey45C44a7I7H/glizpBrfn5IMZhjG+QDh1+7SNcLgZOFTACEFiNpD1i nBpOny2nkgQUnv8VScviFzLmbZBdEDIUTYa0VI3I3FDVCt94GW7XKzsmErAgNNbGTohk qrbiIVK358CC2bMp9+ArFC98HuYa0auJNIDDq959avM5E/CYyeUejhPEHo7W0yzQPPwL RBUzI6xIUdoViFPrz3d4u0gW6gb01RDVPhcQGaSlvndjSJXc0NPt3/4AFZz1zL9rK2ml 1VxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=DVH+JdXK4DvC5OS8h9tQNde0jis9k3m3SiXqDJVBRzc=; b=0b96tpfX/FvbxAw1JvnPi2MF1jcz5rLYzzn+4ZZGxBMLj3/8r6S/HoIrCDRP3eJt3B E3NEu4HNhny0MX6NNFawUZNATqc1EVfbYlUPgwaOTuxdJ7B/aXzDiUZ9acplfLkpPNWm rUe3Zd6X2eVY7td5tyOMFdrPVEF2EIWRiMIt9vrvniF0ITV757uXftXf4qMZBDT7R1Io gKCu7Awi1fArKOgyUM73mPQRhgAkKRfcbgEQjsbVCKpMuiIi7Pu6meEP+p7zQgrpLd8z zWTYDnv70siRUDUh18A+LOyLS1kFGcH+eM2ux3GkQE8FdEhdOrJGppgH3dp5C+sN73EP fLVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oBZlngyk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kw3-20020a170902f90300b001b53d40cee3si706062plb.206.2023.06.16.15.36.25; Fri, 16 Jun 2023 15:36:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oBZlngyk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233060AbjFPWC6 (ORCPT + 99 others); Fri, 16 Jun 2023 18:02:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229952AbjFPWC5 (ORCPT ); Fri, 16 Jun 2023 18:02:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4C08119 for ; Fri, 16 Jun 2023 15:02:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 396D16157B for ; Fri, 16 Jun 2023 22:02:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30A07C433C8; Fri, 16 Jun 2023 22:02:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686952975; bh=zcOm/QwiBNheO0cSdv1r2bufZYMqBBT/qtFj2cPBYJo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oBZlngykMVNo8QKpI0x7rcvf+9r21iMCxXk0GqYiwk6XeMzPbLUo8/KdzeO1EWfPZ E4jPmrJn4et7kdyCpAJVOnC6qo3Bwm6lVQZLFDSUIztrDA5iiGLOk3sPELjOPGzDlq iqqQtKXlE62shQspLarYnQe5IS7cVThNCHNSwvCSWQq+FQpolOhzkmHPMDlCg/DryO ApqTLyeQ3HezzxdiPqtBnaM8IWFZKz3o9a8qlDrZaWpjFaElW4rbZeQ7bWZYphnllc LlmORlj2QuFlY7qKMf/e/iyUoW1K80O+shHBGZZulDEk5zmNPCZpT5iUvQwdkC3U1U rI2ffhgyFj26A== Date: Fri, 16 Jun 2023 23:02:51 +0100 From: Mark Brown To: Russ Weight Cc: Jim Wylder , "Gerlach, Matthew" , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "Rafael J. Wysocki" Subject: Re: [BUG] _regmap_raw_write() - divide-by-zero Message-ID: References: <02da121f-d6f1-73de-1805-4b331ccbc547@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LXUNKlwqyb2J9CuH" Content-Disposition: inline In-Reply-To: <02da121f-d6f1-73de-1805-4b331ccbc547@intel.com> X-Cookie: P-K4 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --LXUNKlwqyb2J9CuH Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 16, 2023 at 02:58:24PM -0700, Russ Weight wrote: > > +=A0=A0=A0=A0 size_t max_data =3D map->max_raw_write - map->format.reg_= bytes - > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 map->form= at.pad_bytes; > For the SPI-Avalon implementation, the values used to calculate max_data = are: > regmap->max_raw_write =3D 4 > regmap->format->reg_bytes =3D 4 > regmap->format->pad_bytes =3D 0 >=20 > So the above calculation for max_data is: max_data =3D (4 - 4 - 0) =3D 0 How does this bus work? The device can accept a maximum of 4 bytes of data but the register is 4 bytes in length so there's no space to transmit a value. --LXUNKlwqyb2J9CuH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSM3AoACgkQJNaLcl1U h9C04wf/R0aO0xgZLnWO5ZY88919MwHEhk1/1ihZOO2yafV9hBbq3r/BplYs2LSX IxdT8oTT90bNxK7knllKOLyDbZXSYsKlwQ5O68Uj5/Cj4Np3WlREstIVTP5kGdxb mm81K9DDY2Cu02QqsCTtcRxXrIEhZc9xECOYxT61CQykSBMvRyL22Y+jO3XQWuDI IayCDwhv/74WR8+FxvceW1CTUdlqDhjNj+xOGkt5e3A3TJC9jw3qlNMhDGImFY31 UhMIALWEI1LvX2TvOeb7HegdKsKzEmsVDU/o6oZUf/NHHw1eBr6kJcWsUtaNaI7N 3N4SH5Wbp5XBsV5n3pos/QtLl+F95g== =7syZ -----END PGP SIGNATURE----- --LXUNKlwqyb2J9CuH--