Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <20230607204120.89416-1-vishal.moola@gmail.com>
References: <20230607204120.89416-1-vishal.moola@gmail.com>
To:     "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
Cc:     dhowells@redhat.com, linux-afs@lists.infradead.org,
        linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] afs: Fix dangling folio ref counts in writeback
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <700315.1686954643.1@warthog.procyon.org.uk>
Date:   Fri, 16 Jun 2023 23:30:43 +0100
Message-ID: <700316.1686954643@warthog.procyon.org.uk>
Precedence: bulk

Vishal Moola (Oracle) <vishal.moola@gmail.com> wrote:

>  					if (skips >= 5 || need_resched()) {
>  						*_next = start;
>  						_leave(" = 0 [%llx]", *_next);
> +						folio_batch_release(&fbatch);

This should go before the _leave().

>  						return 0;
>  					}

Looks okay otherwise.

David