Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3303976rwd; Fri, 16 Jun 2023 15:38:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6IkgCyPXAX2DZA9TFhPwoFtVYSWm5ZbGEl3bHdNbeg6dXg3AcSQWRNs4nQmL/REVy3JL4D X-Received: by 2002:a05:6a20:748c:b0:106:9266:4448 with SMTP id p12-20020a056a20748c00b0010692664448mr4741307pzd.16.1686955093632; Fri, 16 Jun 2023 15:38:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686955093; cv=none; d=google.com; s=arc-20160816; b=ULeiZ7ncOGURE+RdDfpjbcQIRaglNWAzeUKRYSxxewmt8JudbaKZG0m+b/bt+IZ9Mr v8jiXwteLiWeOiEawGNMPDcxQHAXbe5Vqc8jBIUQu/B3wM8A1cFhhE/mAD80GxvULQXg qfWhK/WOodDD327rH6elhAZkdOws2tyJ/MHdMwdfhfWXbF0tDk7/FrJH/RsSZFoSEbOP 6yB+yIiyFCDE04Xjfrc6vBLtLm9FNzbPViokx9Zg/uhyFt41/6/YEV9iwxuONqdRQDAi /2yJiGXXM85JTM5IbY8d1FWkw7O8Tr5GPy6E0Oh/JXensCtG9o6Oa/yNyKJJEFz9RZGG ggNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=C9ymQeewtuah2yRIl5I+JcRwbiBaty41/wJFelw3mgY=; b=0xuAXDT02p9UcebMk9FHMkwm6AsiFrHtFxfLSno94YE0dKumIOAfk20L1KQFAq0sx4 hs/D+m6cJQCCcwU66fVmzn5I/cP7kYWQkwttROzE02Ya7BmOxdWEOToqoUB1PPUqoR+P Mrzp/B3vAp1bMv/MZmOzzSrlrWcTFf7BlH5A84mo0G9GtUU+wdYhpAj4Ql5j5+D0PNrS 81nMXq3GXY+TaMMW2xiLjcBsmrnviMgMl/wASO+36Q7gpPaQT3IHvAkAITX66dljh6jR K2z70I0JOtqEE0qGU0Vu/KuT12SZHF3BGQzh1KMGU4l8y2f1s+5pUIqhWK7KvEfdA17S ygnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=B64tS+Ju; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a16-20020a637f10000000b0051a8a22a42dsi15391585pgd.268.2023.06.16.15.38.01; Fri, 16 Jun 2023 15:38:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=B64tS+Ju; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232072AbjFPWbk (ORCPT + 99 others); Fri, 16 Jun 2023 18:31:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbjFPWbj (ORCPT ); Fri, 16 Jun 2023 18:31:39 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D84330EA for ; Fri, 16 Jun 2023 15:30:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686954649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C9ymQeewtuah2yRIl5I+JcRwbiBaty41/wJFelw3mgY=; b=B64tS+Ju6woSBfX404RNtypefR8j95DIgVYJzAXDlk5reoIbE4rp7G76GakvjgRJUGc2sa cIZ/o6Dfi3h9ZuNAyEx342TdsKLRIT3Z/eyr/7nJrXJDexUdfgNT5g/MKjRpJwqQOPG883 lcpyMZX30c6SDIHyRQlUrPsnMI0ekfQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-371-oIaXkHctNTWA7Ta8_FZlxQ-1; Fri, 16 Jun 2023 18:30:45 -0400 X-MC-Unique: oIaXkHctNTWA7Ta8_FZlxQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 21E451C05EAA; Fri, 16 Jun 2023 22:30:45 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id 83D4248FB01; Fri, 16 Jun 2023 22:30:44 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230607204120.89416-1-vishal.moola@gmail.com> References: <20230607204120.89416-1-vishal.moola@gmail.com> To: "Vishal Moola (Oracle)" Cc: dhowells@redhat.com, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH] afs: Fix dangling folio ref counts in writeback MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <700315.1686954643.1@warthog.procyon.org.uk> Date: Fri, 16 Jun 2023 23:30:43 +0100 Message-ID: <700316.1686954643@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vishal Moola (Oracle) wrote: > if (skips >= 5 || need_resched()) { > *_next = start; > _leave(" = 0 [%llx]", *_next); > + folio_batch_release(&fbatch); This should go before the _leave(). > return 0; > } Looks okay otherwise. David