Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3408798rwd; Fri, 16 Jun 2023 17:34:54 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4f6TwHjgwDUjr1azOZdO6UB21ogdKiJf/onM1txCS9QnnKmE1pP8wjGg+SUXT+ud1ltKUU X-Received: by 2002:a05:6808:3009:b0:396:4977:e148 with SMTP id ay9-20020a056808300900b003964977e148mr3980553oib.9.1686962094085; Fri, 16 Jun 2023 17:34:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686962094; cv=none; d=google.com; s=arc-20160816; b=egKvk9LG1AWx4kAZ+VZK1G2+h+JwEGYftJl9wrb8Tphc74RCDtyBb36YuQoRAdLO8J DJbo9MQdOB/GRorQkEINRc41QssVdXdqERibiIFhAT+SVySKLE+c0Gfg9KzAI2d+SOiv em9auEVo4PiQ2wwHZ3gwP2ipq7LniompKY7diA/jlrEmDrmqukr4ATR5Kb4LzBCTSQej U8HuhSZChhyy7d4Oq4TvJAdQwoDVn39LDg3gjBgZGpO1S3ttJs08uhOu6Uz4b/h28zbp YJL7+D2gT/KgqUTX0tE444kAiURqQbcc/eOrQOzqmTwLqBuntr7nZrr/x9DluoPygfvK 1jmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=WY5Vy149BoEkkQUZaVVbx5XdSZR9rg2xiRp0ZWIjbCY=; b=VN8YH9BFKnamt9H71ueKXaYdRUiLfIYuvvTSBcYnF4rhBFNHb2vDNqDHXdZ6MtnTg/ 93gHtFG8nQw6WZNoa/nCBlS4oagxYIgsa7V6cudiFkto64FaBm5wGs8LStMmCOoHd+n3 6nBJARjQoQxnrnmKx1nGNu6KmnfomaFtTj7OI4fo4D+fNj3iQMUWLl3WYhTFwkXr/91B ijo4zeygkZ6nUD0y3c1SRWbRUnh78VIsZqrgfB2mRH6OaUnBG2wJkKUN0jHn72P8/QZO cPFL53/a1UoxR070QkV05qYbbc3x4B+rMD/noYRyqfvDY1Q1kL4lZRmpexPepmGT2Sff pr7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NPZkzVr+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n1-20020a170902e54100b001ab23ced2d2si13468532plf.613.2023.06.16.17.34.42; Fri, 16 Jun 2023 17:34:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NPZkzVr+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233880AbjFPX1o (ORCPT + 99 others); Fri, 16 Jun 2023 19:27:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbjFPX1k (ORCPT ); Fri, 16 Jun 2023 19:27:40 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B60F03599 for ; Fri, 16 Jun 2023 16:26:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686958012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WY5Vy149BoEkkQUZaVVbx5XdSZR9rg2xiRp0ZWIjbCY=; b=NPZkzVr+Z/nmMUk1D7KG8zKCLlfClWoCcpp2I0BMswJsX5gnK3QbB+0ctFkq1HqFgqsFcp OwalOeqEVkFr4khc7KmPHTQS6oMJsppL+ETNwJEvWub8Iy+WsSBKWcmtDljNUVDVaxKI0T tjMUSLwybNYsm23HBjamljr68bNyxII= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-347-Ow6ffnNVNRieoul6One7EA-1; Fri, 16 Jun 2023 19:26:47 -0400 X-MC-Unique: Ow6ffnNVNRieoul6One7EA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3162A85A5A6; Fri, 16 Jun 2023 23:26:47 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8F9E51C559; Fri, 16 Jun 2023 23:26:46 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230616162202.f46e1279d6b638406fd0eecd@linux-foundation.org> References: <20230616162202.f46e1279d6b638406fd0eecd@linux-foundation.org> <20230608175031.9c534e7f554de89e3d972ab2@linux-foundation.org> <20230607204120.89416-1-vishal.moola@gmail.com> <20230607204120.89416-2-vishal.moola@gmail.com> <702179.1686955382@warthog.procyon.org.uk> To: Andrew Morton Cc: dhowells@redhat.com, "Vishal Moola (Oracle)" , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] afs: Fix waiting for writeback then skipping folio MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <702770.1686958006.1@warthog.procyon.org.uk> Date: Sat, 17 Jun 2023 00:26:46 +0100 Message-ID: <702771.1686958006@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton wrote: > Well, what I'm really asking is the thing I ask seven times a day: > > - what are the end-user visible effects of the bug A third party might see an incomplete flush after they've done a sync - which amounts to temporary file corruption. > - should be fix be backported into earlier kernels Yes. David