Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230615193546.949657149@infradead.org>
In-Reply-To: <20230615193546.949657149@infradead.org>
From:   Sami Tolvanen <samitolvanen@google.com>
Date:   Fri, 16 Jun 2023 16:24:17 -0700
Message-ID: <CABCJKueEgA3UQUzeWP-T9fuo9KbfngCxaF2Uz7Xy2NX5=dpJgw@mail.gmail.com>
Subject: Re: [PATCH 0/2] x86/cfi: Fix FineIBT
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     x86@kernel.org, alyssa.milburn@linux.intel.com,
        linux-kernel@vger.kernel.org, keescook@chromium.org,
        jpoimboe@kernel.org, joao@overdrivepizza.com,
        tim.c.chen@linux.intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jun 15, 2023 at 12:40=E2=80=AFPM Peter Zijlstra <peterz@infradead.o=
rg> wrote:
>
> Hi!
>
> Alyssa reported a FineIBT issue; these patches sort that.
>
> Basically the morale of the story is that CALL_NOSPEC and JMP_NOSPEC are
> suspect and likely not what you want. The remaining users are:
>
> arch/x86/crypto/crc32c-pcl-intel-asm_64.S:      JMP_NOSPEC bufp
>
> This is broken on anything IBT afaict.
>
> arch/x86/include/asm/mshyperv.h:                             CALL_NOSPEC
> arch/x86/include/asm/mshyperv.h:        __asm__ __volatile__(CALL_NOSPEC
> arch/x86/include/asm/mshyperv.h:                __asm__ __volatile__(CALL=
_NOSPEC
> arch/x86/include/asm/mshyperv.h:                __asm__ __volatile__ (CAL=
L_NOSPEC
> arch/x86/include/asm/mshyperv.h:                                     CALL=
_NOSPEC
> arch/x86/include/asm/mshyperv.h:                __asm__ __volatile__ (CAL=
L_NOSPEC
> arch/x86/include/asm/xen/hypercall.h:   asm volatile(CALL_NOSPEC
>
> These are hypercalls and supposedly the targets are having ENDBR on.
>
> arch/x86/kernel/ftrace_64.S:    CALL_NOSPEC r8
>
> The thing is !DYNAMIC_FTRACE only, which we can fix with a Kconfig
> dependency I suppose.
>
> arch/x86/kvm/emulate.c: asm("push %[flags]; popf; " CALL_NOSPEC
> arch/x86/kvm/emulate.c: asm("push %[flags]; popf; " CALL_NOSPEC " ; pushf=
; pop %[flags]\n"
>
> calls into the magic fastop stuff and should be ok, those have explicit
> ENDBR + IBT_NOSEAL() annotations.
>
> arch/x86/kvm/vmx/vmenter.S:     VMX_DO_EVENT_IRQOFF CALL_NOSPEC _ASM_ARG1
>
> calls the IDT vectors manually, so should be ok (gross, but not broken
> from this pov).
>
> arch/x86/platform/efi/efi_stub_64.S:    CALL_NOSPEC rdi
>
> effectively a nocfi call, so should be ok.

Thanks, this looks good to me. For the series:

Reviewed-by: Sami Tolvanen <samitolvanen@google.com>

Sami