Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 16:41:25 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, songmuchun@bytedance.com,
        willy@infradead.org, david@redhat.com, nphamcs@gmail.com,
        jthoughton@google.com
Subject: Re: [PATCH 2/2] mm/hugetlb: add wrapper functions for interactions
 with page cache
Message-ID: <20230616234125.GC7371@monkey>
References: <20230609194947.37196-1-sidhartha.kumar@oracle.com>
 <20230609194947.37196-3-sidhartha.kumar@oracle.com>
 <b3faab36-370c-1635-3ccf-33d51f53859c@oracle.com>
 <20230615233624.GB29046@monkey>
 <b9ba6f95-5da5-2cf6-00d0-77650ba2e7f3@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b9ba6f95-5da5-2cf6-00d0-77650ba2e7f3@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tQshehlwCvMJS4nudC7Y8qgD3BFeW4ACrK7ikgLNcxaI90BVjscjUJqWiqj9?=
 =?us-ascii?Q?4hHFgtqoJ16dQX7tvhFp24nP1GqcAshwLz+h1GjGG023govjx2uyICpDtWvw?=
 =?us-ascii?Q?s/28mNGjP+dxYh8A/mYPXCvSneZ4H4dawn6QnBBNCMeuCt51jf8W7ax2HcDC?=
 =?us-ascii?Q?vncJGeM6/OHuAEcszW5Y3Pzw5+CEHZrn4fy7zb17wkMf5TOYzCaXfmnjg2Sk?=
 =?us-ascii?Q?UYj5M9BIIvtarwRoVKnfkrnMN6tMj5/7pF5tEqamCAKzJCpbrj4dXV8xP88y?=
 =?us-ascii?Q?b68wrLfhF5z9Gv228jLo4S2KFLSp5mRfkIy1UKO3+gbqtQ+cASBBeHY4nlF3?=
 =?us-ascii?Q?+1oPpZcYHBXtDrDcFKzKo0OBPJkCIEIccq5wzbLmx++3/yr2oUr8eBd01VqV?=
 =?us-ascii?Q?QVlyzkfXv616VEiKh6uwPheoIyvn2UNrPZp5GMQsc6NoXm1yaQ1U/JGTR7jV?=
 =?us-ascii?Q?bmM8Au5SH9xHOU+D1kL+gRi7JvHHOCTuNMxkdFyiD2/muXJwN53HuQAk20DF?=
 =?us-ascii?Q?AKjz1U95VtwtLYzkA2yzXN1G3IQyUtbs+GG9x8bS658hjOdR+LKfCN3sNJcN?=
 =?us-ascii?Q?EFbbgxm4zTnDwdF9AtAMwEfNMwQ62sO2fiDuScDPNu2dE2cpK6pzISTOpywq?=
 =?us-ascii?Q?f3ZyZ2msks2oNmNtRvMPi5fC7ZYhz+2xHmBsi1ObbUVa1PnXYYboeUJvYm1w?=
 =?us-ascii?Q?KCMqEoh5jl7IZr2+5oC1ed4Qla7iGbn2eaia/lJgz8zMa2XQ1h+ic0iSn8ia?=
 =?us-ascii?Q?JlLzZKy9YncWMy8u6Ep/rB3fcU1q2Uictq2OKHd206HewC3O2ESk7PbeARwu?=
 =?us-ascii?Q?Gv9uQnyHqDOHq3cpuND/0b1sI1l/uZHzpXo1Ld8H3QfaoY91soFI1NG6LPeN?=
 =?us-ascii?Q?PNfg07+UVWiBWV7AphIxM09mcFsaA0U5PSBlcuI4LaaDB1pOsRZMCWeYwHD1?=
 =?us-ascii?Q?ecl9xa0XTXoll9lA+gSzE6mJUv4eUKfQkKseAUkXs/cRKqb1uh6+STn3ArWf?=
 =?us-ascii?Q?Idz8ur5sOK8lOEjdRmTnt1QwbNdcq94cKIRBYJ5/7R6QkxryKo7DpGGv3N1Z?=
 =?us-ascii?Q?145V+zo6w5lMpTW36vjlxzOeYzAjQc/AsnSAP7NgmiDrSDX4zon+Pk7J+PqX?=
 =?us-ascii?Q?gkCYxJr/C4ZtfTYZ7BmysykXJB05O0nCz7PHGjAzk6Dg7MSDlJFx+jjUJAsP?=
 =?us-ascii?Q?NhuhI23nsY/9YZ1RmbA8ZUsHdi4VIRmW7k/lTvsG+/HjzaVYXegjEVg2dsrQ?=
 =?us-ascii?Q?5/QiUtnmQakZOJJscykEelpvEIDec8rCQuBYYKo0neuf5WvYnaGfuJz8mE1J?=
 =?us-ascii?Q?pIBUrtJkcYzR833NSpkcekbA71z8Gsq7WIOIic6u1Ly+STsQpQ3YyGra1Gfy?=
 =?us-ascii?Q?0QmSOh1xracu0yGvzqQrn5Ix5IrnyMAKZ5pnj2vpPOJai2hU3m5AVVX5zQd6?=
 =?us-ascii?Q?Ya53kAnU8LR+AQJkcI7bD4iCfEZB5jgU20E8rnpr4EMAq2IF+znpZjYlpbHL?=
 =?us-ascii?Q?K2tJTcEsOrI8yw5CJ34NFZOH+J3stL4GV422unBVhQnwPtkltvQfGNT/BLF1?=
 =?us-ascii?Q?6ZdIY3aaVBmyeY8RHVBrzRID/s9AGPGJIChO9NKsDAUlAiy0kZC2zc1v0QJ8?=
 =?us-ascii?Q?ng=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?DUjUviwrNfeXu4u6x5W4RY+nWZR1o3eO5dFRDc0jnQ05uDA33IQpCDn8VtEC?=
 =?us-ascii?Q?+uOI5VMooQXom1uBFF5yTKqCONlhm+4zLDJtnggLRMD/vrkEsi+9+VdJsk9n?=
 =?us-ascii?Q?NUBuHob8wYEIcsq7nGoPYvrMIR7X/OPk3n/z4tEovwRmbIK6XkSZSwOaYsSk?=
 =?us-ascii?Q?qviosa4Zu25u6zSm31obMPkT4xmUgPwTx9U/hy4+onwSWVODHYfjMAwnXqk9?=
 =?us-ascii?Q?V1N9o/ABPZSPeMmtp11niUqLk6ectXGiWnpVqsYsIn/dAEkaDkTKS3OcPD6g?=
 =?us-ascii?Q?vkgN6YWMMayhRtBRgZUixkGg5X1Tbjeqpxo00p3fICsMxcmrn10xDN3AYwb6?=
 =?us-ascii?Q?B/UjuqxJitGOJ133TgInDhrSkyoLNE8loBDlXT2EieuDtZUzDu87JgOEJNSU?=
 =?us-ascii?Q?kj14cNhr+x1BWU7gxQeacuJQmFD/QYbYagIx+CPJRXq/Fh0FyuIDTRg7cZfo?=
 =?us-ascii?Q?JSe11V7KlvV3pXYSQpoxPJsMbzlmZoZJPFBcYtreFNQ6S4LuWoAUch0jv1M1?=
 =?us-ascii?Q?Nskr2290r/SNWqmxenZyBsBl2wudiPEGYztTy5Wgtg6TVZxJJ1J+7NKEHZyJ?=
 =?us-ascii?Q?QqRH9SnIoIbteb9q8+xR1nvTBfzhAH6GsGPHy7gZO4wC/ulbKjtP7I6fgv81?=
 =?us-ascii?Q?7npL+L5FHKLm/fzueOGxFGqNvUYHAY1BigXCeWf5u/QpzXNnUAWmsEccc6QF?=
 =?us-ascii?Q?O63hLFZrKH+bAXE+aTeKH8qm5CEEglqm8fFYmrI7fubWYxGGXANhIvcqU4ay?=
 =?us-ascii?Q?O8p5ANjZxlGdyRgEof8DnvaBzM8xIcLOqOBZAmBjYgwVaCYmubogJrr1ZqW9?=
 =?us-ascii?Q?eHljjuJJa1cJllM88oPsQnZ6sOs+3cbBOrF20gWEewkWJCH54okhav8AEeXZ?=
 =?us-ascii?Q?9y1mrBd/x61s5xHqQNFGOKJwEAd9I+IqONO33DMYdfIr2HjXLfWtPUHtrv0Y?=
 =?us-ascii?Q?E4wpPtqwDGh/ZjSd01LGt0u0QH309K/ieTPVHDTpkiN+ZHMl5JWi1jlHwCc+?=
 =?us-ascii?Q?e8Cv?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 307cd0c7-3071-402f-69a1-08db6ec334ba
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 23:41:28.7488
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mQTs7COYQColcPvnqDBM1Bp7/NrWI+m2pvAa0QD6vqojM1Mfbh9+aDSSorW/wVWpujjXhyt6WTsI651X+oot/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6305
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-06-16_14,2023-06-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 phishscore=0
 suspectscore=0 mlxlogscore=999 bulkscore=0 spamscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2306160215
X-Proofpoint-GUID: aycEheQcMR_MCy001-xQPOcdYc-fObs1
X-Proofpoint-ORIG-GUID: aycEheQcMR_MCy001-xQPOcdYc-fObs1
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/16/23 11:52, Sidhartha Kumar wrote:
> On 6/15/23 4:36 PM, Mike Kravetz wrote:
> > On 06/09/23 12:52, Sidhartha Kumar wrote:
> > > On 6/9/23 12:49 PM, Sidhartha Kumar wrote:
> > > > Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> > 
> > Like filemap_lock_hugetlb_folio(), can you just add hstate to existing
> > hugetlb_add_to_page_cache() arguments and do arithmetic to convert index
> > to PAGE_SIZE based index?
> > 
> 
> I wanted to avoid using "magic numbers" through doing arithmetic shifts to
> convert the index and instead explicitly use the linear_page_index() helper
> function. However this does add more complexity as the function parameters
> are changed. I can change it to doing the arithmetic shift to minimize code
> changes for v2.
> 

I would prefer the arithmetic shifts.  The only magic is that it assumes the
page cache is managed in PAGE_SIZE units.  My guess is more code this this
would break if that was changed.

Matthew may have a more forward thinking opinion.
-- 
Mike Kravetz