Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3438001rwd; Fri, 16 Jun 2023 18:10:59 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5i/yC0gDoeh2LAXadP7XIXEj5uyLUIlb9JjXF78cFNY9PNHF+805AiPwcOcSfVfoPG6hIw X-Received: by 2002:a05:6a00:2d09:b0:656:e7a2:5322 with SMTP id fa9-20020a056a002d0900b00656e7a25322mr4138380pfb.26.1686964259081; Fri, 16 Jun 2023 18:10:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686964259; cv=none; d=google.com; s=arc-20160816; b=HtJ//KH8z1M0zeoW6utSi4tmuRB9Ogv6huGf5EwRJVgLNebVLih4+DyCy7H8Oh20Ah DtQWHEtM2GxFq0d+MZCJ46G9yW+hBGQ9eyjPv0PI2LNPl/xyh7YmfIn2ZYpqRwO28V2Q 52ddrSLwQtaI04gs4vR3tq5f2aB6sJEzh0HS+NZel4rfaNG5clm8vpF6ZdEeHagQ4Apu 4AT7KJ89PbYajT7W0p7RXJlP9+zpp83p2EWJOrrkxGD1W/5U+aIqmdIksl04uSl7Gj6c qPj6QQEOLKvUYHRFFn6x1lz8PYdPSr7WjAXqOnTltCo8EwIaDnbElg4MbRSs+/VXTY4p 8lHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=cszALHYSeI7dIli/xZoXLXNFlOmkeWHMkASD1ujijPw=; b=Ii4QyAEk2lMQHtqzO/zw2xW8RMiLykN+Q9hGd2blS/esTPxWYVEj7jK9lsqr8yYT/5 1zCQnKQh9YaOd8woIrEMRocxYUfDJ46yai/0xMYhLXRvQbND5GTTGzUKsKwuMtA4mH0t PtGBQwkvcWSQ4xQgGwznMnmlWW15DZETUB2v9je4/cDSIPHdymJOsJRWkbDaPn60InSN 4WbHhepPn4NWWtVcf2qky6Cl1J7iON0gy3nRxKPHejJnwbIn+d9Y0WHLm+7qUBEltZbE NqmzaTxj1DOp87H8BS4XawoiUmXyaoPH5REHrIjXnf4hGQUUDaT0N+rmSfzyeXQQiREl W6/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=nmJ5S18K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j2-20020a633c02000000b00543ad8b8807si6512469pga.826.2023.06.16.18.10.29; Fri, 16 Jun 2023 18:10:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=nmJ5S18K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230254AbjFQApH (ORCPT + 99 others); Fri, 16 Jun 2023 20:45:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229493AbjFQApF (ORCPT ); Fri, 16 Jun 2023 20:45:05 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3A423A92 for ; Fri, 16 Jun 2023 17:45:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=cszALHYSeI7dIli/xZoXLXNFlOmkeWHMkASD1ujijPw=; b=nmJ5S18KN8QJqxlk12F8Nkt1es TVWXxAbwC0HOZvexLboqUuF+NfzHwyQ2pakRl2XVBW9ifpd67VmDF14KOO4AJGeuZJahfH53QVp7l s3QZa+56kqmwgDXZOyCEY42DWB3l/D+s7PuJFl4A+SqgYM40t4PDuPazmIuahi3f1ZLBQvhKuKxEC 4uAhQGn+UJ9RPPlq56a/wJjfMH2koVfDWaZ2hUI9rzX3zlBhReXSZQKwkcmyWF2p9eU7a2d1aX3ls QUr2H+TG9vcE6uEAiRzVWOTHi6QHWZd2hkL/bbPpIH5x/drQaZiFEkaGDOLIof8lRHsQK+O/6VTty w5+Ta3sw==; Received: from [2601:1c2:980:9ec0::2764] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qAK3o-002GI7-0B; Sat, 17 Jun 2023 00:45:00 +0000 Message-ID: <3cd3fc67-fb39-f483-3a6f-94ddfbbcf652@infradead.org> Date: Fri, 16 Jun 2023 17:44:58 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] drm/i915: make i915_drm_client_fdinfo() reference conditional again Content-Language: en-US To: Arnd Bergmann , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Andi Shyti Cc: Arnd Bergmann , Matt Roper , Lucas De Marchi , Imre Deak , Alan Previn , Anshuman Gupta , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20230616093158.3568480-1-arnd@kernel.org> From: Randy Dunlap In-Reply-To: <20230616093158.3568480-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/16/23 02:31, Arnd Bergmann wrote: > From: Arnd Bergmann > > The function is only defined if CONFIG_PROC_FS is enabled: > > ld.lld: error: undefined symbol: i915_drm_client_fdinfo >>>> referenced by i915_driver.c >>>> drivers/gpu/drm/i915/i915_driver.o:(i915_drm_driver) in archive vmlinux.a > > Use the PTR_IF() helper to make the reference NULL otherwise. > > Fixes: e894b724c316d ("drm/i915: Use the fdinfo helper") > Signed-off-by: Arnd Bergmann Acked-by: Randy Dunlap Tested-by: Randy Dunlap # build-tested Thanks. > --- > drivers/gpu/drm/i915/i915_driver.c | 2 +- > drivers/gpu/drm/i915/i915_drm_client.h | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c > index 75cbc43b326dd..0ad0c5885ec27 100644 > --- a/drivers/gpu/drm/i915/i915_driver.c > +++ b/drivers/gpu/drm/i915/i915_driver.c > @@ -1816,7 +1816,7 @@ static const struct drm_driver i915_drm_driver = { > .open = i915_driver_open, > .lastclose = i915_driver_lastclose, > .postclose = i915_driver_postclose, > - .show_fdinfo = i915_drm_client_fdinfo, > + .show_fdinfo = PTR_IF(IS_ENABLED(CONFIG_PROC_FS), i915_drm_client_fdinfo), > > .prime_handle_to_fd = drm_gem_prime_handle_to_fd, > .prime_fd_to_handle = drm_gem_prime_fd_to_handle, > diff --git a/drivers/gpu/drm/i915/i915_drm_client.h b/drivers/gpu/drm/i915/i915_drm_client.h > index 4c18b99e10a4e..67816c912bca1 100644 > --- a/drivers/gpu/drm/i915/i915_drm_client.h > +++ b/drivers/gpu/drm/i915/i915_drm_client.h > @@ -47,8 +47,6 @@ static inline void i915_drm_client_put(struct i915_drm_client *client) > > struct i915_drm_client *i915_drm_client_alloc(void); > > -#ifdef CONFIG_PROC_FS > void i915_drm_client_fdinfo(struct drm_printer *p, struct drm_file *file); > -#endif > > #endif /* !__I915_DRM_CLIENT_H__ */ -- ~Randy