Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <03c3df36-203b-591e-c0bb-05bfde54be77@gmail.com>
Date:   Sat, 17 Jun 2023 10:13:26 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH V5 0/2] irqchip: loongson-eiointc: Add DT init support
To:     Huacai Chen <chenhuacai@kernel.org>,
        WANG Xuerui <kernel@xen0n.name>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     Jianmin Lv <lvjianmin@loongson.cn>,
        Huacai Chen <chenhuacai@loongson.cn>,
        linux-kernel@vger.kernel.org, loongarch@lists.linux.dev,
        devicetree@vger.kernel.org, loongson-kernel@lists.loongnix.cn,
        zhoubinbin@loongson.cn
References: <cover.1683279769.git.zhoubinbin@loongson.cn>
From:   Binbin Zhou <zhoubb.aaron@gmail.com>
In-Reply-To: <cover.1683279769.git.zhoubinbin@loongson.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Marc:

The dt-binding part of the patchset looks good now, do you have any more 
comments on the driver part?

Thanks.
Binbin

On 2023/5/5 17:46, Binbin Zhou wrote:
> Hi all:
>
> Add EIOINTC irqchip DT support, which is needed for Loongson chips
> that are DT-based and support EIOINTC, such as the Loongson-2K0500 chip.
>
> Thanks.
>
> ---
> V5:
> - patch(2/2)
>    - Rebased on top of latest loongarch-next(v6.3.0).
>
> V4:
> - patch(1/2)
>    - Simplify the definition of the reg attribute by declaring the entire
>      chip configuration space directly.
>
> V3:
> - patch(1/2)
>    - Drop quotes;
>    - Drop interrupt-names;
>    - Drop loongson,eio-num-vecs;
>    - SoC-based compatibles instead of version-based compatibles.
> - patch (2/2)
>    - irq_set_handler_data() is used to get parent irq form DTS;
>    - Set vec_count by judging compatibles.
>
> V2:
> - Add the dt-bindings file (1/2);
> - patch(2/2)
>    - Remove forgotten debugging messages;
>    - Change compatible string name to "loongson,eiointc-1.0".
>
> Binbin Zhou (2):
>    dt-bindings: interrupt-controller: Add Loongson EIOINTC
>    irqchip/loongson-eiointc: Add DT init support
>
>   .../loongson,eiointc.yaml                     |  59 ++++++++
>   drivers/irqchip/irq-loongson-eiointc.c        | 133 +++++++++++++-----
>   2 files changed, 157 insertions(+), 35 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/interrupt-controller/loongson,eiointc.yaml
>