Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f2c19379-4d1a-e5c4-1452-103dd693735b@linaro.org>
Date:   Sat, 17 Jun 2023 10:04:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v3 05/13] dt-bindings: remoteproc: glink-rpm-edge: Use
 "glink-edge" as node name
Content-Language: en-US
To:     Stephan Gerhold <stephan@gerhold.net>,
        Bjorn Andersson <andersson@kernel.org>
Cc:     Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org
References: <20230531-rpm-rproc-v3-0-a07dcdefd918@gerhold.net>
 <20230531-rpm-rproc-v3-5-a07dcdefd918@gerhold.net>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230531-rpm-rproc-v3-5-a07dcdefd918@gerhold.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 15/06/2023 18:50, Stephan Gerhold wrote:
> Semantically glink-edge and glink-rpm-edge are similar: Both describe
> the communication channels to a remote processor. The RPM glink-edge is
> a special case that needs slightly different properties but otherwise
> it is used exactly the same.
> 
> To improve consistency use the same "glink-edge" node name also for
> glink-rpm-edge. Drop the $nodename from qcom,glink-edge.yaml to avoid
> matching the wrong schema. qcom,glink-edge.yaml is always referenced
> explicitly from other schemas. This will already ensure that the nodes
> are being checked, so it's not necessary to bind to all nodes named
> "glink-edge".
> 
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof