Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3763160rwd; Sat, 17 Jun 2023 01:35:54 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6Zi5YYDILS/AkSyTUSLDtFvtkdS4KmiLyt1g/cDm7CPJcs3P5rYDM+4XBoYZWadffFl2wc X-Received: by 2002:a05:6808:4d9:b0:39c:c952:9310 with SMTP id a25-20020a05680804d900b0039cc9529310mr4460747oie.5.1686990954034; Sat, 17 Jun 2023 01:35:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686990954; cv=none; d=google.com; s=arc-20160816; b=UtvQ74tGdv2A/XOGcuDfR9EOjQ1Gxj3gS4iH4fq1yRt28XezjW1g64Ph4I8SJUMMTp +9eoHhlfa0AnaEzgYydqzLuCdS0x58vByFKAA5jiqcTyuhnUZYwPhfPrd3lPUNWQ2P+8 V7oManlhQqH0rdwQIljl4PItOihcNYpRK6HxVABX1cgTXiPrUdkutrakrmn8B+2x0bqK wAaHSyr75RflGdBmpe+zaoWuBYV8nx56Drik7FXmng3zrGwd09VyAm3khTnXem6m7UjB gKcIL40KPXrXOqjmE2ig1WsTrwkmGOg9j4k+2+uPEX53jupMBmSwzYm/6GE6srmusy90 MhzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=JGVT2whgEPansm/X+6phYYYexkfUcgwTyDWnrkL+doM=; b=tXS4BnQKL+tyVw9GFrh6mnLEf/++bjcOlYN2BAv1+Gs9SgMPqYxp+7YcBlFDExjYO4 HiNsHSjM95JSGcMLTxTWn8ySXvjdEA6NV4gOU94GhA5FQAR4vqNPPecnG2PAdyuVlNS5 P6xtr9+ERPyXgmPxsEoOs/cFOxF9VVg7LpAEloSryGmpkjbBunowJwJcPD+OnDTbYWBH 5bW4AOibME1pDW2k5pbFLS8ZZ4ww1ta+T3SuvUjgdXFBFwlEdFEz51qKHKRCKPnItvnK 0LPBxT/ENJbDgAETzuAc7IpmyIwuIrRa7WOI5DUIbSti95ZPTvHE9zCbNnR8zPO7HCy9 S0XQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i17-20020a17090332d100b001ac82e60516si8183464plr.323.2023.06.17.01.35.40; Sat, 17 Jun 2023 01:35:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345770AbjFQIbT (ORCPT + 99 others); Sat, 17 Jun 2023 04:31:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234669AbjFQIbQ (ORCPT ); Sat, 17 Jun 2023 04:31:16 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DE3A10CF; Sat, 17 Jun 2023 01:31:14 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Qjq4F2MQpzqSNm; Sat, 17 Jun 2023 16:31:09 +0800 (CST) Received: from huawei.com (10.175.104.170) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sat, 17 Jun 2023 16:31:11 +0800 From: Miaohe Lin To: , , , CC: , , Subject: [PATCH] cgroup/cpuset: remove unneeded nodes_or() in cpuset_change_task_nodemask() Date: Sat, 17 Jun 2023 16:30:43 +0800 Message-ID: <20230617083043.2065556-1-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.104.170] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The tsk->mems_allowed is changed before calling mpol_rebind_task() and being reassigned right after it. But tsk->mems_allowed is not needed inside mpol_rebind_task(). So remove unneeded tsk->mems_allowed modify via nodes_or() here. Signed-off-by: Miaohe Lin --- kernel/cgroup/cpuset.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index 58e6f18f01c1..33a429c1179f 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -1941,7 +1941,6 @@ static void cpuset_change_task_nodemask(struct task_struct *tsk, local_irq_disable(); write_seqcount_begin(&tsk->mems_allowed_seq); - nodes_or(tsk->mems_allowed, tsk->mems_allowed, *newmems); mpol_rebind_task(tsk, newmems); tsk->mems_allowed = *newmems; -- 2.27.0