Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 17 Jun 2023 11:23:17 +0100
Message-ID: <87y1kipeui.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Thierry Reding <treding@nvidia.com>,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Andy Shevchenko <andy@kernel.org>
Subject: Re: [PATCH v1 1/1] gpiolib: Drop unused domain_ops memeber of GPIO IRQ chip
In-Reply-To: <CACRpkdbPEvVvaehB521gdjkkzh+wFnFxsCNm36PD-hnTb1Na_w@mail.gmail.com>
References: <20230616135313.76338-1-andriy.shevchenko@linux.intel.com>
        <CACRpkdbPEvVvaehB521gdjkkzh+wFnFxsCNm36PD-hnTb1Na_w@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, 17 Jun 2023 10:08:10 +0100,
Linus Walleij <linus.walleij@linaro.org> wrote:
>=20
> On Fri, Jun 16, 2023 at 3:53=E2=80=AFPM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>=20
> > It seems there is no driver that requires custom IRQ chip
> > domain options. Drop the member and respective code.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> (...)
> > -               /* Some drivers provide custom irqdomain ops */
> >                 gc->irq.domain =3D irq_domain_create_simple(fwnode,
> >                         gc->ngpio,
> >                         gc->irq.first,
> > -                       gc->irq.domain_ops ?: &gpiochip_domain_ops,
> > +                       &gpiochip_domain_ops,
>=20
> We better run this by Marc Zyngier, and Thierry who introduced it.
>=20
> But some grepping and looking seems to conclude you are righ!
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

No objection from my end. If this is unused, let's kill it.

Acked-by: Marc Zyngier <maz@kernel.org>

	M.

--=20
Without deviation from the norm, progress is not possible.