Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5d2cb3e3-c957-4b70-f83c-ad9d8653925d@solid-run.com>
Date:   Sat, 17 Jun 2023 16:34:15 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH 2/3] dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog
 Board
Content-Language: en-US
To:     Andreas Kemnade <andreas@kemnade.info>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Li Yang <leoyang.li@nxp.com>, Marek Vasut <marex@denx.de>,
        Fabio Estevam <festevam@denx.de>,
        Stefan Wahren <stefan.wahren@chargebyte.com>,
        Frieder Schrempf <frieder.schrempf@kontron.de>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>
References: <20230616110610.32173-1-josua@solid-run.com>
 <20230616110610.32173-3-josua@solid-run.com>
 <a9098664-ac16-eddb-3e2d-78eb08ac973f@linaro.org>
 <5139b72e-cccb-43b3-ba37-35f0011e4a2b@solid-run.com>
 <20230616185728.7f0de1a3@aktux>
From:   Josua Mayer <josua@solid-run.com>
In-Reply-To: <20230616185728.7f0de1a3@aktux>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmhyMzlTbk1NUHk3Um52ZTdvc3cvaU1FZVQrQXFhcFRIdDIrS1VHR29vS05s?=
 =?utf-8?B?S1BpaERqS1IwbUY3NVl3YUJnUDlzWVo5THZqVGdCN1dpTjBEQ3cyUUtabEll?=
 =?utf-8?B?TUhsaDE1cXlraC9nc2ZxZFBxbmVDT3lvdEY0VWJPQllCSndzdFlyUHR4T0dl?=
 =?utf-8?B?WURxRWZNdnhUbkF3RXJxYytxeTR3aEx0NHR4RkNBblh5V0VPNVlhZjZJclBn?=
 =?utf-8?B?bkJIc3poRUNrb0s2SzVZT29RUGpNUThNWDNISzhsVDc1a3ZLUkFLSnZ4V3NU?=
 =?utf-8?B?ZW0wbUwxQjY3OGh2UjdoZmorRFlOQWUxL1Jyc2lUMStEYWg2SjIzQWlSYjhh?=
 =?utf-8?B?UG9LVGRsWlo3aXlqQ2JtbFpDZ0xENVYwM3lZbEZVVEszTXBRQXBwaVNSNzFr?=
 =?utf-8?B?T3FQamxNL2M2NEcvMmtYYm5TODQ5Vnc3V0lrc1doenE0VGdHVFlJNEtJZnlE?=
 =?utf-8?B?NGFqaE5kUHNXVlZFeTRNYlNjUUZZVUhSMTg2NVpnOGZBTk5jY3FQbTlrNzUy?=
 =?utf-8?B?dGxCZ29QTXlOSnE2VFNyaEQvYXlWTm9LTDF4c29KZXlHd1R3THZlREp2eHo2?=
 =?utf-8?B?Yit5VkdzcmRwVzJrbmJ3NUdXRDlLakNmRXJJdnFoQTBucTN6ZnU3VlNSY1Bt?=
 =?utf-8?B?N1RiS2ZzdTE4QjZHWm5HK2FqdXZNTW8vU21nL0kxNm42RVV0UC9LbDhxQlhi?=
 =?utf-8?B?cmtDRjdiaXlheFdZUWdKK2xvczNTeHVVSVZha1g4dnQ3dHJVbVJhOUFNejVu?=
 =?utf-8?B?R2xOZUJFMjhyOUVRNEFyRkN6dTRJNFdCdElyNDhubmdGY2hwQTNQZUpMbkp3?=
 =?utf-8?B?TGFZc2Z5WVUwV3NYTmhMNy82OTcvU3B1R1R2L3BocjU1V0hrcTUrTUREWHFi?=
 =?utf-8?B?RHZpS0Fra2ZrTVZ4eW0wWlBqaVNUMmppNVhuczE0VktrUzVjRHhld2J4a2Vp?=
 =?utf-8?B?cTdMZDNIL2xYa1hvL3VMY1dkVlJvcDlWSmFZZjB2VlZSV2drMUV0OTFOaUQr?=
 =?utf-8?B?UlcvZEdUbGVhNlRTY0xTYTZHanltQXpITThJTU5MZm9vZXhRbWNoR3B4ZEs0?=
 =?utf-8?B?SDQ1RHZicU93aytKbmxjdkIvQUZPbHRXakxONFVOUi9ML0UwSEZ0eTArcWR0?=
 =?utf-8?B?cXQvT2N0Z3FXUFREWlJKbzlOYk9YTUZyK2l0VjZTZVkxdHVmNTREaml3WXh0?=
 =?utf-8?B?NkY0ZDgzd1BQUnpxcUpUTFZrR3d0ZWllaXJSeEQrMmE5SUs3WmtvN2dKZjNP?=
 =?utf-8?B?d084MHVjaHNmUW1IUGtqUjNuU1VNUTZVTzY5SjNUTlBBVmFaSE5MdXB6cC9a?=
 =?utf-8?B?SlZFUWFwM05oYm9MUDV6SVhhQ3ZyUmcwamQwcmZaT3lLY3g2NWNaMXFJck9E?=
 =?utf-8?B?NE9aRVhMRmcwSHZLSXV0QmZmMUovRU9SelM3aVRCdkphek12NkNGMjFiMGUy?=
 =?utf-8?B?QU1nT0cvSHlYaXVaVnlvajlCL2s2SWxRQnlHQjVuTEgwdHlNcVY2QUgybUg4?=
 =?utf-8?B?NlFFNFkyYzhiRk16QXRzc1BMQ2o1bHNIL2pobFZhQnd2QUJwb00rN3hsOEVs?=
 =?utf-8?B?M210RFplR0l3YStQRE0vSHhVVk5HZTJCanc3c2RmNHNqLzJiVkJrQTd6ZXFo?=
 =?utf-8?B?ckJPcHpENGNpSm00Mk01M08xN1BQNnFDS1lGaDlkRnRHa2VQaWZQV2drQk1C?=
 =?utf-8?B?aVVZSVZPOHd6eTJhTFhGdjQySzBkcFhwanB4MWlKOGVlNmhldzA0b0VRMmZG?=
 =?utf-8?B?cEl4Rld6Vkhhd2dDMlJWL3VsMy94TEdNQWJwM1cvZlJpVlZId3QwMThwM3Rq?=
 =?utf-8?B?ZFYvVUNrM3RyQ1QwTzMyYy9wZjJpOWF4ZXE5YVVQS1R6Y0R4MGlSZ2NkVGxF?=
 =?utf-8?B?WjBjNmYxT2JKNFljUC9VYmY4MVdxZW5xR0ViV2l2TS9TM3hlRHJmeGdPUGpl?=
 =?utf-8?B?T2JKWThDK2tVakJJZzhuQ1NVUStoSVdvOS9uRXYwZlY0TTNENmhSdXRCSnBR?=
 =?utf-8?B?YmFFOFBkMnR3VWxydjJEQlRLT2dHOUJDdUxpNDNMWitWS0JTakEvbHFkSWVU?=
 =?utf-8?B?RUlZZ3pmK01YK0dtRlpOeFl6Z0gwNzJveGtUNG50VkNTZ0JhelB2aUQ0cjZl?=
 =?utf-8?Q?IfmTj0/B0M880CGhgRG0oP6JJ?=
X-OriginatorOrg: solid-run.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f2aed86-77e9-4560-a9df-08db6f378de5
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8963.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2023 13:34:19.9223
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a4a8aaf3-fd27-4e27-add2-604707ce5b82
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JkFjDw2QT6L/Tf1utOXd49IHmwtKgQ4P/6JyDfu16PBiXkTGPwV5xvFRJgh5qaEf18f03on8C6In1yGU/PfUCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8220
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andreas,

Am 16.06.23 um 19:57 schrieb Andreas Kemnade:
> On Fri, 16 Jun 2023 16:32:01 +0300
> Josua Mayer <josua@solid-run.com> wrote:
>
>> HI Krzysztof,
>>
>> Am 16.06.23 um 14:36 schrieb Krzysztof Kozlowski:
>>> On 16/06/2023 13:06, Josua Mayer wrote:
>>>> Add DT compatible for SolidRun LX2162A SoM and Clearfog board.
>>>>
>>>> Signed-off-by: Josua Mayer <josua@solid-run.com>
>>>> ---
>>>>    Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
>>>>    1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>>>> index 15d411084065..438a4ece8157 100644
>>>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>>>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>>>> @@ -1373,9 +1373,11 @@ properties:
>>>>          - description: SolidRun LX2160A based Boards
>>>>            items:
>>>>              - enum:
>>>> +              - solidrun,clearfog
>>>>                  - solidrun,clearfog-cx
>>>>                  - solidrun,honeycomb
>>>>              - const: solidrun,lx2160a-cex7
>>>> +          - const: solidrun,lx2162a-som
>>>>              - const: fsl,lx2160a
>>> You change existing entries, breaking boards and changing the meaning,
>>> without any explanation in commit msg. That's not how it is done. Please
>>> provide rationale in commit msg.
>> I'm sorry. Given your comment I think I did not understand how these
>> entries are supposed to work.
>> So perhaps you can provide some guidance based on my explanation?:
>>
> it breaks:
> arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
> compatible = "solidrun,clearfog-cx",
>                  "solidrun,lx2160a-cex7", "fsl,lx2160a";
>
> now you would require:
> compatible = "solidrun,clearfog-cx",
>                  "solidrun,lx2160a-cex7", "solidrun,lx2162a-som", "fsl,lx2160a"
I see, thanks!
The more I look at it, the more logical this behaviour seems.
> which is probably not what you want.

Yep. I wanted to keep the 3 components, and allow forking in the middle:

"solidrun,<board>", "solidrun,<module>", "fsl,lx2160a"

This however creates many combinations that are undesirable.
Existing boards using com express don't suddenly become compatible with 
the new SoM.
Therefore I prepared a different approach vor v2 now.

> Regards,
> Andreas
- Josua Mayer